Re: [Linaro-acpi] [PATCH v17 08/15] clocksource/drivers/arm_arch_timer: move arch_timer_needs_of_probing into DT init call
Hi ,
On 25 November 2016 at 22:32, kbuild test robot lkp@intel.com wrote:
Hi Fu,
[auto build test ERROR on pm/linux-next] [also build test ERROR on v4.9-rc6] [cannot apply to tip/timers/core next-20161125] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/fu-wei-linaro-org/acpi-clocksource-... base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/ma... -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64
Note: the linux-review/fu-wei-linaro-org/acpi-clocksource-add-GTDT-driver-and-GTDT-support-in-arm_arch_timer/20161125-171111 HEAD 498f1f2503da21841b0e7679ddbdb86a40451bdb builds fine. It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/clocksource/arm_arch_timer.c: In function 'arch_timer_acpi_init':
Sorry, again,
a "+ int ret;" should be move from [12/15] to here, I have fix the problem in my repo, it would happen in next patchset
https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-time...
drivers/clocksource/arm_arch_timer.c:1071:2: error: 'ret' undeclared (first use in this function)
ret = arch_timer_register(); ^~~drivers/clocksource/arm_arch_timer.c:1071:2: note: each undeclared identifier is reported only once for each function it appears in
vim +/ret +1071 drivers/clocksource/arm_arch_timer.c
1065 return -EINVAL; 1066 } 1067 1068 /* Always-on capability */ 1069 arch_timer_c3stop = !(gtdt->non_secure_el1_flags & ACPI_GTDT_ALWAYS_ON); 1070
1071 ret = arch_timer_register();
1072 if (ret) 1073 return ret; 1074
0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
On Fri, Nov 25, 2016 at 9:06 AM, Fu Wei fu.wei@linaro.org wrote:
a "+ int ret;" should be move from [12/15] to here, I have fix the problem in my repo, it would happen in next patchset
https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-time...
Fu, please post v18 to the mailing list so that it can be picked up for 4.10 (if it's not too late already).
Hi Timur,
On 8 December 2016 at 01:25, Timur Tabi timur@codeaurora.org wrote:
On Fri, Nov 25, 2016 at 9:06 AM, Fu Wei fu.wei@linaro.org wrote:
a "+ int ret;" should be move from [12/15] to here, I have fix the problem in my repo, it would happen in next patchset
https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-time...
Fu, please post v18 to the mailing list so that it can be picked up for 4.10 (if it's not too late already).
Great thanks for your suggestion! :-) yes, you are right, I would love to post v18 ASAP.
But I am still waiting for more feedback from the maintainers. For Now, the only feedback is this fix from "kbuild test robot" :-(
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
On Thu, Dec 08, 2016 at 11:16:21AM +0800, Fu Wei wrote:
Hi Timur,
On 8 December 2016 at 01:25, Timur Tabi timur@codeaurora.org wrote:
On Fri, Nov 25, 2016 at 9:06 AM, Fu Wei fu.wei@linaro.org wrote:
a "+ int ret;" should be move from [12/15] to here, I have fix the problem in my repo, it would happen in next patchset
https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-time...
Fu, please post v18 to the mailing list so that it can be picked up for 4.10 (if it's not too late already).
Unfortunately, it's too late for v4.10. It hasn't been sat in linux-next at all, and we've seen kbuild test failures.
Hopefully there's time to beat this into shape and get it into linux-next so that it's ready to queue for v4.11, though.
Great thanks for your suggestion! :-) yes, you are right, I would love to post v18 ASAP.
But I am still waiting for more feedback from the maintainers.
Please post a version which passes inspection by the kbuild test robot. I haven't had a chance to look at this yet, and it'll be better to look at a version that actually works.
Thanks, Mark.
Hi Mark,
On 8 December 2016 at 19:04, Mark Rutland mark.rutland@arm.com wrote:
On Thu, Dec 08, 2016 at 11:16:21AM +0800, Fu Wei wrote:
Hi Timur,
On 8 December 2016 at 01:25, Timur Tabi timur@codeaurora.org wrote:
On Fri, Nov 25, 2016 at 9:06 AM, Fu Wei fu.wei@linaro.org wrote:
a "+ int ret;" should be move from [12/15] to here, I have fix the problem in my repo, it would happen in next patchset
https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-time...
Fu, please post v18 to the mailing list so that it can be picked up for 4.10 (if it's not too late already).
Unfortunately, it's too late for v4.10. It hasn't been sat in linux-next at all, and we've seen kbuild test failures.
Hopefully there's time to beat this into shape and get it into linux-next so that it's ready to queue for v4.11, though.
cross fingers for getting into v4.11 :-)
Great thanks for your suggestion! :-) yes, you are right, I would love to post v18 ASAP.
But I am still waiting for more feedback from the maintainers.
Please post a version which passes inspection by the kbuild test robot. I haven't had a chance to look at this yet, and it'll be better to look at a version that actually works.
OK, NP, will post them in several hours Great thanks for your feedback.
Thanks, Mark.
-
Fu Wei -
Mark Rutland -
Timur Tabi