--- tools/common/include/acpi.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/common/include/acpi.h b/tools/common/include/acpi.h index c06bafb..ba8004b 100644 --- a/tools/common/include/acpi.h +++ b/tools/common/include/acpi.h @@ -18,6 +18,8 @@ #define ACPI_OEM_ID_SIZE 6 #define ACPI_OEM_TABLE_ID_SIZE 8
+#pragma pack(1) + /* Generic ACPI table header */
struct acpi_table_header { @@ -295,4 +297,7 @@ struct acpi_whea_header { uint64_t mask; /* Bitmask required for this register instruction */ };
+/* Reset to default packing */ +#pragma pack() + #endif /* ACPI_H_ */
ACPI header is not necessary for blob any more. --- platforms/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/platforms/Makefile b/platforms/Makefile index a94fbdb..b99132c 100644 --- a/platforms/Makefile +++ b/platforms/Makefile @@ -3,7 +3,7 @@ ifdef PADDR endif
%.acpi : FORCE - $(MAB) -d $@ $(PADDR_ARG) -i $(basename $@).manifest -o $@ + $(MAB) -H -d $@ $(PADDR_ARG) -i $(basename $@).manifest -o $@ ifdef APEI $(BFAPEI) -d $@ -i $(basename $@).manifest -t $(APEI) -o apei.acpi endif
Acked-by: Naresh Bhat naresh.bhat@linaro.org
On 19 November 2013 14:05, Tomasz Nowicki tomasz.nowicki@linaro.org wrote:
ACPI header is not necessary for blob any more.
platforms/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/platforms/Makefile b/platforms/Makefile index a94fbdb..b99132c 100644 --- a/platforms/Makefile +++ b/platforms/Makefile @@ -3,7 +3,7 @@ ifdef PADDR endif
%.acpi : FORCE
$(MAB) -d $@ $(PADDR_ARG) -i $(basename $@).manifest -o $@
$(MAB) -H -d $@ $(PADDR_ARG) -i $(basename $@).manifest -o $@ifdef APEI $(BFAPEI) -d $@ -i $(basename $@).manifest -t $(APEI) -o apei.acpi endif -- 1.7.9.5
Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi
Acked-by: Naresh Bhat naresh.bhat@linaro.org
On 19 November 2013 14:05, Tomasz Nowicki tomasz.nowicki@linaro.org wrote:
tools/common/include/acpi.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/common/include/acpi.h b/tools/common/include/acpi.h index c06bafb..ba8004b 100644 --- a/tools/common/include/acpi.h +++ b/tools/common/include/acpi.h @@ -18,6 +18,8 @@ #define ACPI_OEM_ID_SIZE 6 #define ACPI_OEM_TABLE_ID_SIZE 8
+#pragma pack(1)
/* Generic ACPI table header */
struct acpi_table_header { @@ -295,4 +297,7 @@ struct acpi_whea_header { uint64_t mask; /* Bitmask required for this register instruction */ };
+/* Reset to default packing */ +#pragma pack()
#endif /* ACPI_H_ */
1.7.9.5
Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi
--- changelog.txt | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 changelog.txt
diff --git a/changelog.txt b/changelog.txt new file mode 100644 index 0000000..199d487 --- /dev/null +++ b/changelog.txt @@ -0,0 +1,9 @@ +---------------------------------------- +19 November 2013. Summary of changes: + +1) ACPI structures alignment to 1 byte + +ACPI structures are taken directly from Linux tree. They are all wrap inside +#pragma pack(1) just to be sure 1 byte alignment requirements are satisfied. + +---------------------------------------- \ No newline at end of file
Acked-by: Naresh Bhat naresh.bhat@linaro.org
On 19 November 2013 15:29, Tomasz Nowicki tomasz.nowicki@linaro.org wrote:
changelog.txt | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 changelog.txt
diff --git a/changelog.txt b/changelog.txt new file mode 100644 index 0000000..199d487 --- /dev/null +++ b/changelog.txt @@ -0,0 +1,9 @@ +---------------------------------------- +19 November 2013. Summary of changes:
+1) ACPI structures alignment to 1 byte
+ACPI structures are taken directly from Linux tree. They are all wrap inside +#pragma pack(1) just to be sure 1 byte alignment requirements are satisfied.
+---------------------------------------- \ No newline at end of file -- 1.7.9.5
Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi
On 11/19/2013 01:35 AM, Tomasz Nowicki wrote:
tools/common/include/acpi.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/common/include/acpi.h b/tools/common/include/acpi.h index c06bafb..ba8004b 100644 --- a/tools/common/include/acpi.h +++ b/tools/common/include/acpi.h @@ -18,6 +18,8 @@ #define ACPI_OEM_ID_SIZE 6 #define ACPI_OEM_TABLE_ID_SIZE 8
+#pragma pack(1)
/* Generic ACPI table header */
struct acpi_table_header {
@@ -295,4 +297,7 @@ struct acpi_whea_header { uint64_t mask; /* Bitmask required for this register instruction */ };
+/* Reset to default packing */ +#pragma pack()
- #endif /* ACPI_H_ */
Based on these patches, it looks like you're working on the code to remove the "ACPIxxxx" header from the blob? Did I guess right? Do I win a prize :)?
If you are, there's an LP bug (#1232143) tracking this issue.
-
Al Stone -
Naresh Bhat -
Tomasz Nowicki