From: Naresh Bhat naresh.bhat@linaro.org
CC drivers/acpi/fan.o drivers/acpi/fan.c: In function ‘fan_get_cur_state’: drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized] --- drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index f815da8..f61f7fd 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long { struct acpi_device *device = cdev->devdata; int result; - int acpi_state; + int acpi_state = 0;
if (!device) return -EINVAL;
Please send upstream, that looks like an obvious fix!
Graeme
On 27/06/13 09:35, naresh.bhat@linaro.org wrote:
From: Naresh Bhat naresh.bhat@linaro.org
CC drivers/acpi/fan.o drivers/acpi/fan.c: In function ‘fan_get_cur_state’: drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized]
drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index f815da8..f61f7fd 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long { struct acpi_device *device = cdev->devdata; int result;
- int acpi_state;
- int acpi_state = 0;
if (!device) return -EINVAL;
Thanks Graeme. I have sent out a e-mail.
-Naresh
On 27 June 2013 14:07, Graeme Gregory graeme.gregory@linaro.org wrote:
Please send upstream, that looks like an obvious fix!
Graeme
On 27/06/13 09:35, naresh.bhat@linaro.org wrote:
From: Naresh Bhat naresh.bhat@linaro.org
CC drivers/acpi/fan.o drivers/acpi/fan.c: In function ‘fan_get_cur_state’: drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized
in this function [-Wuninitialized]
drivers/acpi/fan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c index f815da8..f61f7fd 100644 --- a/drivers/acpi/fan.c +++ b/drivers/acpi/fan.c @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct
thermal_cooling_device *cdev, unsigned long
{ struct acpi_device *device = cdev->devdata; int result;
int acpi_state;
int acpi_state = 0; if (!device) return -EINVAL;
Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi
-
Graeme Gregory -
Naresh Bhat -
naresh.bhat＠linaro.org