On 12/19/2013 09:58 AM, Graeme Gregory wrote:

The addresses were not updated from the change to the FVP model. Correct the addresses.

Boot tested with patch series from Hanjun Guo

Signed-off-by: Graeme Gregory graeme.gregory@linaro.org

platforms/rtsm_ve-aemv8a.acpi/apic.asl | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/platforms/rtsm_ve-aemv8a.acpi/apic.asl b/platforms/rtsm_ve-aemv8a.acpi/apic.asl index c782e70..81351c3 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/apic.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/apic.asl @@ -44,7 +44,7 @@ [0004] Asl Compiler ID : "INTL" [0004] Asl Compiler Revision : 20110623

-[0004] Local Apic Address : 2C002000 +[0004] Local Apic Address : 2C000000 [0004] Flags (decoded below) : 00000001 PC-AT Compatibility : 0

@@ -58,7 +58,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 /* this is the foundation model's GIC address */ +[0008] Base Address : 000000002C000000 /* armv8 FVP Base GIC address */

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -70,7 +70,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -82,7 +82,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -94,7 +94,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -106,7 +106,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -118,7 +118,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -130,7 +130,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -142,12 +142,12 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000

[0001] Subtable Type : 0C [Generic Interrupt Distributor] [0001] Length : 18 [0002] Reserved : 0000 [0004] Local GIC Hardware ID : 00000000 -[0008] Base Address : 000000002C001000 /* armv8 foundation model's GIC distributor base addr */ +[0008] Base Address : 000000002F000000 /* armv8 FVP Base GIC distributor base addr */ [0004] Interrupt Base : 00000000 [0004] Reserved : 00000000

Whups. I didn't see this v2 in time; my ACK should go on this one.

Acked-by: Al Stone al.stone@linaro.org