On 2015年01月08日 17:26, Ashok Kumar wrote:
On Thu, Jan 08, 2015 at 04:00:37PM +0800, Hanjun Guo wrote:
On 2015???01???07??? 21:32, Ashok Kumar wrote:
Also provided pcibus_to_node and cpumask_of_pcibus based on x86.
Signed-off-by: Ashok Kumar ashoks@broadcom.com
Hanjun, This patch is based on your acpi numa patchset and leg-kernel. Tested it on qemu using generic pci host controller. could you add this to your set of patches if it is fine? Thanks!
sure, I will. thanks for your patch!
I already fixed the call trace of early_ioremap memory leak, will send another version.
Hanjun,
Thanks!
I just noticed the call to numa_add_memblk in acpi_numa_memory_affinity_init should use ma->length as the second param. The syntax of numa_add_memblk is numa_add_memblk(u32 nid, u64 base, u64 size).
diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c index 44de133..b5fc732 100644 --- a/arch/arm64/kernel/acpi_numa.c +++ b/arch/arm64/kernel/acpi_numa.c @@ -147,7 +147,7 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma) goto out_err_bad_srat; }
if (numa_add_memblk(node, start, end) < 0)
if (numa_add_memblk(node, start, ma->length) < 0)
Good catch! I didn't notice Ganapat updated the numa_add_memblk() API for ARM64.
goto out_err_bad_srat; node_set(node, numa_nodes_parsed);Ganapat, Is it possible to change the info prints of numa_add_memblk_to like below
diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c index 7bead6a..f293182 100644 --- a/arch/arm64/mm/numa.c +++ b/arch/arm64/mm/numa.c @@ -194,7 +194,7 @@ static int __init numa_add_memblk_to(int nid, u64 start, u64 end, }
pr_info("NUMA: Adding memblock %d [0x%llx - 0x%llx] on node %d\n",
mi->nr_blks, start, end, nid);
mi->nr_blks, start, end - 1, nid);
I think this is reasonable, 0x60000000 is belong to another block I think.
Thanks Hanjun
________________________________________ From: Hanjun Guo hanjun.guo@linaro.org Sent: Thursday, January 8, 2015 5:31 PM To: Ashok Kumar Cc: Kulkarni, Ganapatrao; tomasz.nowicki@linaro.org; jchandra@broadcom.com; linaro-acpi@lists.linaro.org Subject: Re: [PATCH] ARM64 / ACPI : Probe _PXM during pci acpi scan
On 2015年01月08日 17:26, Ashok Kumar wrote:
On Thu, Jan 08, 2015 at 04:00:37PM +0800, Hanjun Guo wrote:
On 2015???01???07??? 21:32, Ashok Kumar wrote:
Also provided pcibus_to_node and cpumask_of_pcibus based on x86.
Signed-off-by: Ashok Kumar ashoks@broadcom.com
Hanjun, This patch is based on your acpi numa patchset and leg-kernel. Tested it on qemu using generic pci host controller. could you add this to your set of patches if it is fine? Thanks!
sure, I will. thanks for your patch!
I already fixed the call trace of early_ioremap memory leak, will send another version.
Hanjun,
Thanks!
I just noticed the call to numa_add_memblk in acpi_numa_memory_affinity_init should use ma->length as the second param. The syntax of numa_add_memblk is numa_add_memblk(u32 nid, u64 base, u64 size).
diff --git a/arch/arm64/kernel/acpi_numa.c b/arch/arm64/kernel/acpi_numa.c index 44de133..b5fc732 100644 --- a/arch/arm64/kernel/acpi_numa.c +++ b/arch/arm64/kernel/acpi_numa.c @@ -147,7 +147,7 @@ acpi_numa_memory_affinity_init(struct acpi_srat_mem_affinity *ma) goto out_err_bad_srat; }
if (numa_add_memblk(node, start, end) < 0)
if (numa_add_memblk(node, start, ma->length) < 0)
Good catch! I didn't notice Ganapat updated the numa_add_memblk() API for ARM64.
goto out_err_bad_srat; node_set(node, numa_nodes_parsed);Ganapat, Is it possible to change the info prints of numa_add_memblk_to like below
sure Hanjun, will add in next patch.
diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c index 7bead6a..f293182 100644 --- a/arch/arm64/mm/numa.c +++ b/arch/arm64/mm/numa.c @@ -194,7 +194,7 @@ static int __init numa_add_memblk_to(int nid, u64 start, u64 end, }
pr_info("NUMA: Adding memblock %d [0x%llx - 0x%llx] on node %d\n",
mi->nr_blks, start, end, nid);
mi->nr_blks, start, end - 1, nid);
I think this is reasonable, 0x60000000 is belong to another block I think.
Thanks Hanjun
-
Hanjun Guo -
Kulkarni, Ganapatrao