From: Al Stone ahs3@redhat.com
There are a few places where the printk()s no longer serve a useful purpose -- those printk()s are removed by the first patch. The second and third patches remove printk() in favor of proper use of pr_err() and pr_debug(), respectively.
Al Stone (3): ARM: ACPI: remove some unneeded printk messages used for initial debugging ARM: ACPI: use pr_err() as one should and not printk() ACPI: ARM: use pr_debug() as one should and not printk()
drivers/acpi/osl.c | 31 +++++++++++++++---------------- drivers/acpi/plat/arm/boot.c | 9 --------- 2 files changed, 15 insertions(+), 25 deletions(-)
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org --- drivers/acpi/plat/arm/boot.c | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/acpi/plat/arm/boot.c b/drivers/acpi/plat/arm/boot.c index e62d167..a6645ff 100644 --- a/drivers/acpi/plat/arm/boot.c +++ b/drivers/acpi/plat/arm/boot.c @@ -566,8 +566,6 @@ void __init acpi_boot_table_init(void) if (acpi_disabled) return;
- printk(KERN_DEBUG "acpi: enter acpi_boot_table_init\n"); - /* * Fix up the addresses in the ACPI we've loaded * in. The blob has them as offsets and we need @@ -583,10 +581,7 @@ void __init acpi_boot_table_init(void) return; }
- printk(KERN_INFO "(I) acpi_table_init call completed\n"); acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf); - - printk(KERN_INFO "(I) exit acpi_boot_table_init\n"); }
int __init early_acpi_boot_init(void) @@ -597,8 +592,6 @@ int __init early_acpi_boot_init(void) if (acpi_disabled) return 1;
- printk(KERN_INFO "enter early_acpi_boot_init\n"); - /* * Process the Multiple APIC Description Table (MADT), if present */ @@ -615,8 +608,6 @@ int __init acpi_boot_init(void) if (acpi_disabled) return 1;
- printk(KERN_INFO "enter acpi_boot_init\n"); - acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
/*
On 06/26/2013 01:26 PM, al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org
drivers/acpi/plat/arm/boot.c | 9 --------- 1 file changed, 9 deletions(-)
[snip...]
Oops. Due a slip of the fingers, I did not send out the proper cover letter message:
There are a few places where the printk()s no longer serve a useful purpose -- those printk()s are removed by the first patch. The second and third patches remove printk() in favor of proper use of pr_err() and pr_debug(), respectively.
Al Stone (3): ARM: ACPI: remove some unneeded printk messages used for initial debugging ARM: ACPI: use pr_err() as one should and not printk() ACPI: ARM: use pr_debug() as one should and not printk()
drivers/acpi/osl.c | 31 +++++++++++++++---------------- drivers/acpi/plat/arm/boot.c | 9 --------- 2 files changed, 15 insertions(+), 25 deletions(-)
Series looks good to me, Ill apply it tomorrow.
Graeme
On 26/06/13 20:32, Al Stone wrote:
On 06/26/2013 01:26 PM, al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org
drivers/acpi/plat/arm/boot.c | 9 --------- 1 file changed, 9 deletions(-)
[snip...]
Oops. Due a slip of the fingers, I did not send out the proper cover letter message:
There are a few places where the printk()s no longer serve a useful purpose -- those printk()s are removed by the first patch. The second and third patches remove printk() in favor of proper use of pr_err() and pr_debug(), respectively.
Al Stone (3): ARM: ACPI: remove some unneeded printk messages used for initial debugging ARM: ACPI: use pr_err() as one should and not printk() ACPI: ARM: use pr_debug() as one should and not printk()
drivers/acpi/osl.c | 31 +++++++++++++++---------------- drivers/acpi/plat/arm/boot.c | 9 --------- 2 files changed, 15 insertions(+), 25 deletions(-)
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org --- drivers/acpi/osl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index bdabc89..b80aa07 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -266,7 +266,7 @@ void acpi_find_arm_root_pointer(acpi_physical_address *pa) struct acpi_table_rsdp *rp;
if (!acpi_arm_rsdp_info.phys_address && !acpi_arm_rsdp_info.size) { - printk(KERN_ERR "(E) ACPI: failed to find rsdp info\n"); + pr_err("failed to find rsdp info\n"); *pa = (acpi_physical_address)NULL; return; } @@ -293,7 +293,7 @@ void acpi_find_arm_root_pointer(acpi_physical_address *pa)
*pa = (acpi_physical_address)(virt_to_phys(rp)); } else { - printk(KERN_ERR "(E) ACPI missing rsdp info\n"); + pr_err("ACPI missing rsdp info\n"); *pa = (acpi_physical_address)NULL; }
@@ -1324,7 +1324,7 @@ acpi_status acpi_os_wait_semaphore(acpi_handle handle, u32 units, u16 timeout) jiffies = MAX_SCHEDULE_TIMEOUT; else jiffies = msecs_to_jiffies(timeout); - + ret = down_timeout(sem, jiffies); if (ret) status = AE_TIME;
From: Al Stone ahs3@redhat.com
Signed-off-by: Al Stone al.stone@linaro.org --- drivers/acpi/osl.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index b80aa07..f027ab0 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -276,20 +276,19 @@ void acpi_find_arm_root_pointer(acpi_physical_address *pa) *pa = (acpi_physical_address)address;
rp = (struct acpi_table_rsdp *)address; - printk(KERN_DEBUG "(I) ACPI rsdp rp: 0x%08lx\n", (long unsigned int)rp); + pr_debug("ACPI rsdp rp: 0x%08lx\n", (long unsigned int)rp); if (rp) { - printk(KERN_DEBUG "(I) ACPI rsdp content:\n"); - printk(KERN_DEBUG "(I) signature: %.8s\n", rp->signature); - printk(KERN_DEBUG "(I) checksum: 0x%02x\n", rp->checksum); - printk(KERN_DEBUG "(I) oem_id: %.6s\n", rp->oem_id); - printk(KERN_DEBUG "(I) revision: %d\n", rp->revision); - printk(KERN_DEBUG "(I) rsdt: 0x%08lX\n", - (long unsigned int)rp->rsdt_physical_address); - printk(KERN_DEBUG "(I) length: %d\n", rp->length); - printk(KERN_DEBUG "(I) xsdt: 0x%016llX\n", - (u64)rp->xsdt_physical_address); - printk(KERN_DEBUG "(I) x_checksum: 0x%02x\n", - rp->extended_checksum); + pr_debug("ACPI rsdp content:\n"); + pr_debug(" signature: %.8s\n", rp->signature); + pr_debug(" checksum: 0x%02x\n", rp->checksum); + pr_debug(" oem_id: %.6s\n", rp->oem_id); + pr_debug(" revision: %d\n", rp->revision); + pr_debug(" rsdt: 0x%08lX\n", + (long unsigned int)rp->rsdt_physical_address); + pr_debug(" length: %d\n", rp->length); + pr_debug(" xsdt: 0x%016llX\n", + (u64)rp->xsdt_physical_address); + pr_debug(" x_checksum: 0x%02x\n", rp->extended_checksum);
*pa = (acpi_physical_address)(virt_to_phys(rp)); } else {
-
Al Stone -
al.stone＠linaro.org
-
Graeme Gregory