On 05-Mar 15:53, Patrick Bellasi wrote:
On 05-Mar 20:44, Viresh Kumar wrote:
On 5 March 2018 at 18:22, Patrick Bellasi patrick.bellasi@arm.com wrote:
On 05-Mar 15:57, Viresh Kumar wrote:
[...]
Well, that's what we want to do but we will never do that. The very next statement after looking for lowest capacity is this:
if ((capacity_orig - min_capped_util) < target_idle_max_spare_cap) continue;
Hops, wait... got it... you are looking at the android-4.9-eas-dev branch!
... I was considering the "mainline" android-4.9 ACK
If we start from a big CPU, then the above expression will *always* evaluate to "true" for a little CPU and so we never go to the rest of the code for little CPUs. And that's a bug as we probably don't want that behavior.
Yes, looking at that code... it seems that we end up favouring a big CPU over a LITTLE... which is a behavior chance wrt the original code.
Let seem what we can do with the snippet above... since it's not yet merged in ACK...
Here is in attachment a patch which should fix the issue Viresh/Leo reported. Comments / Tomatoes?
Cheers Patrick
-- #include <best/regards.h>
Patrick Bellasi