Re: [Eas-dev] [PATCH 3/3] sched/tune: Avoid null pointer dereference in schedtune_add_cluster_nrg

On Thu, Jun 02, 2016 at 01:18:09PM +0100, Jon Medhurst (Tixy) wrote:

A CPU's scheduler domain doesn't always have a parent e.g. if we only have one cluster present or enabled in the system.

---

kernel/sched/tune.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/tune.c b/kernel/sched/tune.c index 6edfd44..53c6de56 100644 --- a/kernel/sched/tune.c +++ b/kernel/sched/tune.c @@ -719,7 +719,7 @@ schedtune_add_cluster_nrg( * Assume we have EM data only at the CPU and * the upper CLUSTER level */

• 	BUG_ON(!cpumask_equal(
  

• 	BUG_ON(sd2->parent && !cpumask_equal(
  	sched_group_cpus(sg),
  	sched_group_cpus(sd2->parent->groups)
  

Just curious, this issue can be fixed by creating root schedule domain before Deitmar has meantioned. right?

		));

-- 2.1.4

---

eas-dev mailing list eas-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/eas-dev