Hi,
Personally I don't have a strong opinion on how it should be fixed - this is likely to be temporary IMO as we will probably soon want to add extracting energy model data in the dtb like we do for arm64, so that we can have more similarity between the two in a post-hmp world. That will necessitate including sched_energy.h sooner or later I think, which will pull in sched.h and get the forward declaration.
Best Regards,
--Chris
________________________________________ From: Jon Medhurst (Tixy) tixy@linaro.org Sent: 03 June 2016 14:37 To: Steve Muckle Cc: Chris Redpath; eas-dev@lists.linaro.org Subject: Re: [Eas-dev] [PATCH 1/3] arm: Fix build error "conflicting types for 'scale_cpu_capacity'"
On Thu, 2016-06-02 at 10:48 -0700, Steve Muckle wrote:
I ran into this a while back and wrote the attached patch - I think it may be cleaner than defining struct sched_domain again.
Seems strange to me to include cpufreq.h to get its copy of a forward declaration of a struct defined in sched.h. And the arm64 version of this code does things differently again.
Guess it doesn't matter though as this is experimental code, backported to old Linux versions, and doesn't have a maintainer or canonical 'upstream' source code repository.
-- Tixy IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.