the cap_idx should be set to energy_env->cap_idx, it is used by group_norm_usage() later.
Signed-off-by: Mark Yang mark.yang@spreadtrum.com --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 93005c9..ced4a99 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4617,7 +4617,7 @@ static int find_new_capacity(struct energy_env *eenv,
for (idx = 0; idx < sge->nr_cap_states; idx++) { if (sge->cap_states[idx].cap >= util) - return idx; + break; }
eenv->cap_idx = idx; -- 2.5.0
Hi Mark,
On Tue, Mar 22, 2016 at 05:26:29PM +0800, Mark Yang wrote:
the cap_idx should be set to energy_env->cap_idx, it is used by group_norm_usage() later.
Signed-off-by: Mark Yang mark.yang@spreadtrum.com
kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 93005c9..ced4a99 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4617,7 +4617,7 @@ static int find_new_capacity(struct energy_env *eenv,
for (idx = 0; idx < sge->nr_cap_states; idx++) { if (sge->cap_states[idx].cap >= util)
return idx;
break;
This patch duplicates with this one :) https://lists.linaro.org/pipermail/eas-dev/2015-November/000308.html
Dietmar has confirmed it and fixed it on RFCv5.2 code base: git://www.linux-arm.org/linux-power.git, branch: energy_model_rfc_v5.2
Thanks, Leo Yan
eenv->cap_idx = idx;
2.5.0
eas-dev mailing list eas-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/eas-dev
Got it, thanks
-----邮件原件----- 发件人: Leo Yan [mailto:leo.yan@linaro.org] 发送时间: 2016年3月23日 10:31 收件人: Mark Yang (杨永辉) 抄送: eas-dev@lists.linaro.org 主题: Re: [Eas-dev] [PATCH] sched/fair: replace return with break if success to find capacity
Hi Mark,
On Tue, Mar 22, 2016 at 05:26:29PM +0800, Mark Yang wrote:
the cap_idx should be set to energy_env->cap_idx, it is used by group_norm_usage() later.
Signed-off-by: Mark Yang mark.yang@spreadtrum.com
kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 93005c9..ced4a99 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4617,7 +4617,7 @@ static int find_new_capacity(struct energy_env *eenv, for (idx = 0; idx < sge->nr_cap_states; idx++) { if (sge->cap_states[idx].cap >= util)
return idx;
break;
This patch duplicates with this one :) https://lists.linaro.org/pipermail/eas-dev/2015-November/000308.html
Dietmar has confirmed it and fixed it on RFCv5.2 code base: git://www.linux-arm.org/linux-power.git, branch: energy_model_rfc_v5.2
Thanks, Leo Yan
eenv->cap_idx = idx; -- 2.5.0
eas-dev mailing list eas-dev@lists.linaro.org https://lists.linaro.org/mailman/listinfo/eas-dev
-
Leo Yan -
Mark Yang -
Mark Yang (杨永辉)