Hi,
This is interesting answer to my question so I am shearing it with you.
Tomasz
-------- Original Message --------
Subject: Re: APEI question
Date: Thu, 24 Oct 2013 02:38:26 -0400
From: Chen, Gong <gong.chen(a)linux.intel.com>
To: Tomasz Nowicki <tn(a)semihalf.com>
On Wed, Oct 23, 2013 at 11:16:13AM +0200, Tomasz Nowicki wrote:
> Date: Wed, 23 Oct 2013 11:16:13 +0200
> From: Tomasz Nowicki <tn(a)semihalf.com>
> To: chen gong <Chen(a)gchen.bj.intel.com>
> CC: gong.chen(a)linux.intel.com
> Subject: Re: APEI question
> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101
> Thunderbird/24.0
>
> Let me put this in the different way.
>
> ghes_do_proc() process errors which are reported via APEI. It
> handles with CPER_SEC_PLATFORM_MEM and CPER_SEC_PCIE error types. I
> wander why this function is not taking care of
> CPER_SEC_PROC_GENERIC.
>
Yes, the spec has covered all kinds of situations but the reality is
cruel. Even FFM is enabled, not all errors can be covered by
firmware. Based on the fact, only memory/IO CE and IO UC errors can
be handled well by firmware by now. For processer errors, as a fact,
I never saw so-called CE errors, only UC, even fatal error. As a
result, you will get a MCE. You can consider that firmware just
*bypass* this kind of error. In some way, that's why eMCA happens
as a successor. That's all. Otherwise I will cross the red line ;-).
From: Al Stone <ahs3(a)redhat.com>
This series of patches starts with Hanjun's patch to create a kernel
config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I
then reviewed all of the code that touched any of several fields in the
FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced
mode [1]. Any time there was a use of one of the fields to be ignored,
I evaluated whether or not the code was implementing Hardware Reduced
mode correctly. Similarly, for each the flags in the FADT flags field
that are to be ignored in Hardware Reduced mode, the kernel code was again
scanned for proper usage. The remainder of the patches are to fix all of
the situations I could find where the kernel would not behave correctly
in this ACPI mode.
These are being submitted as an RFC to the linaro-acpi@ list so I can get
some other eyes looking at them before sending them to linux-acpi@ where
they really need to go. These seem to work just fine on the RTSM model
for ARMv7, both with and without ACPI enabled, and with and without
ACPI_REDUCED_HARDWARE enabled. However, there's no way I can think of
or test all possible scenarios so feedback would be greatly appreciated.
[1] Please see the ACPI Specification v5.0 for details on Hardware Reduced
mode.
[0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5…
Al Stone (12):
ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode
ACPI: bus master reload is unsupported in ACPI reduced HW mode
ACPI: clean up compiler warning about uninitialized field
ACPI: HW reduced mode does not allow use of the FADT sci_interrupt
field
ACPI: ARM: exclude calls on ARM platforms, not include them on x86
ACPI: ensure several FADT fields are only used in HW reduced mode
ACPI: do not reserve memory regions for some FADT entries in HW
reduced mode
ACPI: in HW reduced mode, getting power latencies from FADT is not
allowed
ACPI: add clarifying comment about processor throttling in HW reduced
mode
ACPI: ACPI_FADT_C2_MP_SUPPORTED must be ignored in HW reduced mode
ACPI: use of ACPI_FADT_32BIT_TIMER is not allowed in HW reduced mode
ACPI: correct #ifdefs so compiling without ACPI_REDUCED_HARDWARE works
properly
drivers/acpi/Kconfig | 8 ++++++++
drivers/acpi/acpica/utxface.c | 3 ++-
drivers/acpi/bus.c | 9 +++++----
drivers/acpi/osl.c | 28 ++++++++++++++++++++--------
drivers/acpi/pci_link.c | 14 ++++++++------
drivers/acpi/processor_idle.c | 29 ++++++++++++++++++++++++-----
drivers/acpi/processor_throttling.c | 8 ++++++++
drivers/acpi/sleep.c | 2 +-
include/acpi/acconfig.h | 2 +-
include/acpi/platform/aclinux.h | 6 ++++++
10 files changed, 83 insertions(+), 26 deletions(-)
--
1.8.3.1
From: Al Stone <ahs3(a)redhat.com>
This patch is dependent on the CONFIG_ACPI_REDUCED_HARDWARE patch
already being in place. It may even make sense to be part of that
series.
The FACS contains a global_lock that is never to be used in Hardware
Reduced mode. Instead of taking chances, this patch takes out the
macros used for the global_lock if we are in Hardware Reduced mode
so that they cannot be used.
Signed-off-by: Al Stone <al.stone(a)linaro.org>
---
arch/arm/include/asm/acpi.h | 3 ++-
arch/arm64/include/asm/acpi.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/acpi.h b/arch/arm/include/asm/acpi.h
index ca7efaa..cf67b09 100644
--- a/arch/arm/include/asm/acpi.h
+++ b/arch/arm/include/asm/acpi.h
@@ -82,6 +82,7 @@
/* Blob handling macros */
#define ACPI_BLOB_HEADER_SIZE 8
+#ifndef CONFIG_ACPI_REDUCED_HARDWARE
int __acpi_acquire_global_lock(unsigned int *lock);
int __acpi_release_global_lock(unsigned int *lock);
@@ -90,9 +91,9 @@ int __acpi_release_global_lock(unsigned int *lock);
#define ACPI_RELEASE_GLOBAL_LOCK(facs, Acq) \
((Acq) = __acpi_release_global_lock(&facs->global_lock))
+#endif
/* Basic configuration for ACPI */
-/* BOZO: hardware reduced acpi only? */
#ifdef CONFIG_ACPI
extern int acpi_disabled;
extern int acpi_noirq;
diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
index a19b73f..bb9411f 100644
--- a/arch/arm64/include/asm/acpi.h
+++ b/arch/arm64/include/asm/acpi.h
@@ -60,6 +60,7 @@
/* Blob handling macros */
#define ACPI_BLOB_HEADER_SIZE 8
+#ifndef CONFIG_ACPI_REDUCED_HARDWARE
int __acpi_acquire_global_lock(unsigned int *lock);
int __acpi_release_global_lock(unsigned int *lock);
@@ -68,9 +69,9 @@ int __acpi_release_global_lock(unsigned int *lock);
#define ACPI_RELEASE_GLOBAL_LOCK(facs, Acq) \
((Acq) = __acpi_release_global_lock(&facs->global_lock))
+#endif
/* Basic configuration for ACPI */
-/* BOZO: hardware reduced acpi only? */
#ifdef CONFIG_ACPI
extern int acpi_disabled;
extern int acpi_noirq;
--
1.8.3.1
From: Naresh Bhat <naresh.bhat(a)linaro.org>
The patches try to fix the DBG2 table compilation issue
and also tries to add a template support for DBG2 tables.
Naresh Bhat (2):
iASL: Fix Table Info handler for DBG2
iASL: Add template support for dbg2
source/common/dmtable.c | 2 +-
source/compiler/dtcompiler.h | 1 +
source/compiler/dttemplate.h | 10 ++++++++++
3 files changed, 12 insertions(+), 1 deletion(-)
--
1.7.9.5
From: Naresh Bhat <naresh.bhat(a)linaro.org>
The ASL code for SMB, FPGA, AMBA bus and the devices on the bus. The SMB and FPGA are represented as Module device. The container object that acts as a bus node in a namespace. It may contain child objects that are devices or buses. The module device is declared using the ACPI0004 hardware identifier (HID). The AMBA is represented as a separate device along with UART.
This patch is applied and tested on v8 model along with "Hanjun Guo" - Convert the fixed clock to ACPI and "Brandon Anderson" - ARM AMBA bus connector resource changes. The sample output logs on v8 model as below
root@genericarmv8:/sys# find . -name LINA*
./bus/acpi/devices/LINA0003:00
./bus/acpi/devices/LINA0005:00
./bus/acpi/devices/LINA0007:00
./bus/acpi/devices/LINA0008:00
./bus/acpi/devices/LINA0008:01
./bus/acpi/devices/LINA0008:02
./bus/acpi/devices/LINA0009:00
./bus/platform/devices/LINA0003:00
./bus/platform/devices/LINA0005:00
./bus/platform/devices/LINA0007:00
./bus/platform/devices/LINA0008:00
./bus/platform/devices/LINA0008:01
./bus/platform/devices/LINA0008:02
./bus/platform/drivers/smc91x/LINA0003:00
./bus/platform/drivers/fixed-clk/LINA0008:00
./bus/platform/drivers/fixed-clk/LINA0008:01
./bus/platform/drivers/fixed-clk/LINA0008:02
./bus/platform/drivers/arm-pmu/LINA0007:00
./bus/platform/drivers/virtio-mmio/LINA0005:00
./devices/platform/LINA0003:00
./devices/platform/LINA0005:00
./devices/platform/LINA0007:00
./devices/platform/LINA0008:00
./devices/platform/LINA0008:01
./devices/platform/LINA0008:02
./devices/LNXSYSTM:00/device:00/LINA0007:00
./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0003:00
./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0008:00
./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0008:01
./devices/LNXSYSTM:00/device:00/ACPI0004:01/LINA0008:02
./devices/LNXSYSTM:00/device:00/ACPI0004:01/ACPI0004:02/LINA0005:00
./devices/LNXSYSTM:00/device:00/ACPI0004:01/ACPI0004:02/LINA0009:00
root@genericarmv8:/sys#
root@genericarmv8:/sys# find . -name AMBA*
./bus/acpi/devices/AMBA0000:00
./bus/platform/devices/AMBA0000:00
./bus/platform/drivers/amba-acpi/AMBA0000:00
./devices/platform/AMBA0000:00
./devices/LNXSYSTM:00/device:00/AMBA0000:00
root@genericarmv8:/sys#
root@genericarmv8:/sys/bus/amba/devices# ls
device:01 device:02 device:03 device:04
root@genericarmv8:/sys/bus/amba/devices#
Naresh Bhat (1):
foundation: Add ASL for bus, devices enumeration
platforms/foundation-v8.acpi/dsdt.asl | 181 +++++++++++++++++++++++++++++++--
1 file changed, 175 insertions(+), 6 deletions(-)
--
1.7.9.5
This is the RFC version for converting the fixed clock to ACPI.
Since the ACPI namespace is ok at the very late stage of system
boot, so I did some major change in boot sequence for the enumeration
of fixed clock, amba bus and its child device. I think this part should
be review carefully.
For DT, it works well for armv8 foudation model after the change in
boot sequence, but the UART and amba bus are dependent on the fixed
clock, if I only convert the fixed clock to ACPI, UART will not
work. So this is the RFC version and the UART will be converted
together in next version.
Hanjun Guo (5):
Driver / clk: add platform driver for fixed clock
ACPI / ARM64: Whitelist the ACPI ID for fixed clock
ACPI / platform: add some comments for internel registry of _HID
names
ACPI / fixed-clock: Add ACPI driver for fixed clock
Clk / fixed clock: Delay the enumeration of fixed clock and make it
popssible for ACPI
arch/arm64/kernel/setup.c | 2 +-
drivers/acpi/acpi_platform.c | 7 ++--
drivers/clk/clk-fixed-rate.c | 78 +++++++++++++++++++++++++++++++++++++++++-
3 files changed, 82 insertions(+), 5 deletions(-)
--
1.7.9.5
linux/acpi.h already does the correct thing when CONFIG_ACPI is not set
so there is no need to wrap it in #ifdef CONFIG_ACPI and in fact this
stops ACPI_PTR() working in the non ACPI case.
Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org>
---
drivers/net/ethernet/smsc/smc91x.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
index 940097f..7aa517d 100644
--- a/drivers/net/ethernet/smsc/smc91x.c
+++ b/drivers/net/ethernet/smsc/smc91x.c
@@ -82,6 +82,7 @@ static const char version[] =
#include <linux/mii.h>
#include <linux/workqueue.h>
#include <linux/of.h>
+#include <linux/acpi.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
@@ -89,10 +90,6 @@ static const char version[] =
#include <asm/io.h>
-#ifdef CONFIG_ACPI
-#include <linux/acpi.h>
-#endif
-
#include "smc91x.h"
#ifndef SMC_NOWAIT
--
1.8.3.1
Hi,
I am proposing one cherry pick from Mark Salters tree in the same way
that we already cherry picked from Leifs for ioremap_early support.
Also changed the order of setup.c initialisation to work under ioremap_early.
I have boot tested this on the RTSM model.
Thanks
Graeme