Linaro-acpi August 2013

linaro-acpi@lists.linaro.org

15 participants
57 discussions

[PATCH] ACPICA:enable 64bit build for aarch64 architecture

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> Signed-off-by: Naresh Bhat <naresh.bhat(a)linaro.org> Enable 64 bit build for aarch64 architecture in ACPICA Linux platform specific defines. --- src/acpica/source/include/platform/aclinux.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpica/source/include/platform/aclinux.h b/src/acpica/source/include/platform/aclinux.h index e561292..6b8b1ab 100644 --- a/src/acpica/source/include/platform/aclinux.h +++ b/src/acpica/source/include/platform/aclinux.h @@ -159,7 +159,7 @@ #define ACPI_FLUSH_CPU_CACHE() #define ACPI_CAST_PTHREAD_T(pthread) ((ACPI_THREAD_ID) (pthread)) -#if defined(__ia64__) || defined(__x86_64__) +#if defined(__ia64__) || defined(__x86_64__) || (__aarch64__) #define ACPI_MACHINE_WIDTH 64 #define COMPILER_DEPENDENT_INT64 long #define COMPILER_DEPENDENT_UINT64 unsigned long -- 1.7.9.5

10 years, 8 months

[PATCH 0/3] acpi-asl.git: various mab bug repairs

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This is complete reorganization of what used to be "Various fix-ups and additions to mab" patches 3 and 4 (5 has been completely rethought as a seperate series to appear later). What this patch does is add in a change log that should have been there all along, and comment the versioning a little better. The more substantial bug fix is that code that checked whether there was enough room in the XSDT for all the tables being added would only do so when verbose mode was being used. This error check now occurs under all conditions as it should have. Al Stone (3): mab: add in a Changelog to improve documentation mab: report an XSDT error regardless of whether we're verbose or not mab: update version number (and comment it better) tools/mab/Changelog | 9 +++++++++ tools/mab/mab.c | 19 +++++++++++-------- tools/mab/mab.h | 3 ++- 3 files changed, 22 insertions(+), 9 deletions(-) create mode 100644 tools/mab/Changelog -- 1.8.3.1

10 years, 8 months

[PATCH 0/5] Various fix-ups and additions to mab

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> These are mostly minor fixups to mab: -- report usage properly -- do not segfault if missing the -p <paddr> parameter -- if the XSDT did not have enough room for tables, it would not discover that or notify anyone unless it was being verbose; now it will always report that error if found -- and just because it wasn't verbose enough, add the final relocated address of the table to the output -- update the version number Al Stone (5): mab: minor cleanup of usage output mab: if -p <paddr> is not given, we would segfault; die more gracefully now mab: update version number mab: report an XSDT error regardless of whether we're verbose or not mab: add final relocated address to verbose output tools/mab/mab.c | 52 ++++++++++++++++++++++++++++++++++++---------------- tools/mab/mab.h | 4 +++- 2 files changed, 39 insertions(+), 17 deletions(-) -- 1.8.3.1

10 years, 8 months

[PATCH] meta-linaro: acpica: fix style issues

by Graeme Gregory

Fix recipe to be OE complient with spacing SRCREV and PV. Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- meta-aarch64/conf/machine/genericarmv8.conf | 8 ++++---- meta-linaro/recipes-extra/acpica/acpica_20130626.bb | 18 +++++++++--------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/meta-aarch64/conf/machine/genericarmv8.conf b/meta-aarch64/conf/machine/genericarmv8.conf index 6d84e0d..ab8900e 100644 --- a/meta-aarch64/conf/machine/genericarmv8.conf +++ b/meta-aarch64/conf/machine/genericarmv8.conf @@ -23,15 +23,15 @@ PREFERRED_PROVIDER_virtual/kernel ?= "linux-linaro" KERNEL_IMAGETYPE = "Image" # We have to disable SERIAL_CONSOLE due to auto-serial-console -#SERIAL_CONSOLE = "115200 ttyAMA0" +SERIAL_CONSOLE = "115200 ttyAMA0" # Force auto-serial-console to be used by all image types # Ideally this would be part of core oe or as a bbclassappend, # but as we don't have an easy way to append a class, defining # it here -EXTRA_IMAGE_FEATURES += "autoserial" -PACKAGE_GROUP_autoserial = "auto-serial-console" +#EXTRA_IMAGE_FEATURES += "autoserial" +#PACKAGE_GROUP_autoserial = "auto-serial-console" # we do not want to have getty running on tty1 as we run # auto-serial-console there -USE_VT = "0" +#USE_VT = "0" diff --git a/meta-linaro/recipes-extra/acpica/acpica_20130626.bb b/meta-linaro/recipes-extra/acpica/acpica_20130626.bb index 58d7c4b..e4218fd 100644 --- a/meta-linaro/recipes-extra/acpica/acpica_20130626.bb +++ b/meta-linaro/recipes-extra/acpica/acpica_20130626.bb @@ -1,21 +1,20 @@ +SUMMARY = "ACPICA tools for the development and debug of ACPI tables" DESCRIPTION = "The ACPI Component Architecture (ACPICA) project provides an \ OS-independent reference implementation of the Advanced Configuration and \ Power Interface Specification (ACPI). ACPICA code contains those portions of \ ACPI meant to be directly integrated into the host OS as a kernel-resident \ subsystem, and a small set of tools to assist in developing and debugging \ ACPI tables." -SUMMARY = "ACPICA tools for the development and debug of ACPI tables" HOMEPAGE = "http://www.acpica.org/" SECTION = "console/tools" LICENSE = "BSD | GPLv2" LIC_FILES_CHKSUM = "file://generate/unix/readme.txt;md5=204407e197c1a01154a48f6c6280c3aa" -DEPENDS="bison \ - flex" -COMPATIBLE_HOST = "(i.86|x86_64|arm|aarch64).*-linux" - -PR="r2" +DEPENDS = "bison flex" +SRCREV = "780de9ee36e5a7b4acc29a2ccd43d6bdc5dd5219" +PV = "20130626+git${SRCPV}" +PR = "r3" -SRC_URI="git://git.linaro.org/people/ahs3/acpica-tools.git \ +SRC_URI = "git://git.linaro.org/people/ahs3/acpica-tools.git \ file://fix_ftbfs_debian-kfreebsd.patch \ file://debian-big_endian.patch \ file://debian-unaligned.patch \ @@ -27,8 +26,6 @@ SRC_URI="git://git.linaro.org/people/ahs3/acpica-tools.git \ file://no-werror.patch \ file://fix-parallel-build.patch" -SRCREV = "${AUTOREV}" - S = "${WORKDIR}/git" EXTRA_OEMAKE = "'OPT_CFLAGS=-Wall'" @@ -42,3 +39,6 @@ do_install() { install -D -p -m0755 generate/unix/bin*/acpisrc ${D}${bindir}/acpisrc install -D -p -m0755 generate/unix/bin*/acpixtract ${D}${bindir}/acpixtract } + +COMPATIBLE_HOST = "(i.86|x86_64|arm|aarch64).*-linux" + -- 1.7.10.4

10 years, 8 months

[PATCH v2] exynos5250-arndale: DSDT requires _CRS to be serialized

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This patch applies to the acpi-asl.git tree. This corrects a minor error reported by iasl when compiling the DSDT for Arndale. The error is minor enough that iasl still produces a table but it could potentially affect operation. Changes for v2: -- added some sort of explanation for the patch Signed-off-by: Al Stone <al.stone(a)linaro.org> --- platforms/exynos5250-arndale.acpi/dsdt.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platforms/exynos5250-arndale.acpi/dsdt.asl b/platforms/exynos5250-arndale.acpi/dsdt.asl index 2cca765..7f05c6b 100644 --- a/platforms/exynos5250-arndale.acpi/dsdt.asl +++ b/platforms/exynos5250-arndale.acpi/dsdt.asl @@ -23,7 +23,7 @@ DefinitionBlock ( Name (_HID, "LINA0001") Name (_UID, 0) - Method (_CRS, 0x0, NotSerialized) { + Method (_CRS, 0x0, Serialized) { Name (RBUF, ResourceTemplate () { Memory32Fixed (ReadWrite, 0x12C60000, 0x00000100) -- 1.8.3.1

10 years, 8 months

[PATCH] ARM: EXYNOS: Set 64-bit DMA mask for EXYNOS5250

by al.stone＠linaro.org

From: Al Stone <ahs3(a)redhat.com> This patch is a re-submittal of a previous patch from the Samsung LT, specifically 5bf534ab87a62e717771d5548b66296ca8e9fbe5. It has been redone to fit the acpi-ltfixes branch of acpi.git, and is needed to prevent DMA errors from occurring. This is required when LPAE is enabled. Signed-off-by: Tushar Behera <tushar.behera(a)linaro.org> Signed-off-by: Al Stone <al.stone(a)linaro.org> --- arch/arm/mach-exynos/mach-exynos5-dt.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c index f874b77..863042d 100644 --- a/arch/arm/mach-exynos/mach-exynos5-dt.c +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c @@ -14,6 +14,7 @@ #include <linux/memblock.h> #include <linux/io.h> #include <linux/clocksource.h> +#include <linux/dma-mapping.h> #include <asm/mach/arch.h> #include <mach/regs-pmu.h> @@ -23,6 +24,26 @@ #include "common.h" +static u64 dma_mask64 = DMA_BIT_MASK(64); + +static int exynos5250_platform_notifier(struct notifier_block *nb, + unsigned long event, void *__dev) +{ + struct device *dev = __dev; + + if (event != BUS_NOTIFY_ADD_DEVICE) + return NOTIFY_DONE; + + dev->dma_mask = &dma_mask64; + dev->coherent_dma_mask = DMA_BIT_MASK(64); + + return NOTIFY_OK; +} + +static struct notifier_block exynos5250_platform_nb = { + .notifier_call = exynos5250_platform_notifier, +}; + static void __init exynos5_dt_machine_init(void) { struct device_node *i2c_np; @@ -47,6 +68,9 @@ static void __init exynos5_dt_machine_init(void) } } + if (of_machine_is_compatible("samsung,exynos5250")) + bus_register_notifier(&platform_bus_type, &exynos5250_platform_nb); + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); } -- 1.8.3.1

10 years, 8 months

[PATCH 1/3] cpufreq / gx: Fix __init attribute locations

by Hanjun Guo

__init belongs after the return type on functions, not before it. Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- drivers/cpufreq/gx-suspmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/gx-suspmod.c b/drivers/cpufreq/gx-suspmod.c index 3dfc99b..e30fd16 100644 --- a/drivers/cpufreq/gx-suspmod.c +++ b/drivers/cpufreq/gx-suspmod.c @@ -183,7 +183,7 @@ static void gx_write_byte(int reg, int value) * gx_detect_chipset: * **/ -static __init struct pci_dev *gx_detect_chipset(void) +static struct pci_dev * __init gx_detect_chipset(void) { struct pci_dev *gx_pci = NULL; -- 1.7.9.5

10 years, 8 months

[PATCH 1/3] ACPI / dock: Fix __init attribute locations

by Hanjun Guo

__init belongs after the return type on functions, not before it. Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- drivers/acpi/dock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c index 8265607..c90112c 100644 --- a/drivers/acpi/dock.c +++ b/drivers/acpi/dock.c @@ -1055,7 +1055,7 @@ err_unregister: * * This is called by acpi_walk_namespace to look for dock stations and bays. */ -static __init acpi_status +static acpi_status __init find_dock_and_bay(acpi_handle handle, u32 lvl, void *context, void **rv) { if (is_dock(handle) || is_ejectable_bay(handle)) -- 1.7.9.5

10 years, 8 months

[PATCH] Fix typecast warning on aarch64

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> Signed-off-by: Naresh Bhat<naresh.bhat(a)linaro.org> This patch fix all typecast warnings being treated as errors occured while compiling on ARMv8 aarch64 architecture. --- src/acpi/method/method.c | 92 +++++++++++++++++++++++----------------------- 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index f46fdff..327a887 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -976,14 +976,14 @@ static void method_test_HID_return( tmp, sizeof(tmp))) fwts_passed(fw, "%s returned an integer " "0x%8.8" PRIx64 " (EISA ID %s).", - name, obj->Integer.Value, tmp); + name, (long unsigned int)obj->Integer.Value, tmp); else fwts_failed(fw, LOG_LEVEL_MEDIUM, "MethodHIDInvalidInteger", "%s returned a integer 0x%8.8" PRIx64 " " "(EISA ID %s) but the this is not a valid " "EISA ID encoded PNP ID.", - name, obj->Integer.Value, tmp); + name, (long unsigned int)obj->Integer.Value, tmp); break; default: fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_HIDBadReturnType", @@ -1865,7 +1865,7 @@ static void method_test_FIX_return( "%s returned an integer " "0x%8.8" PRIx64 " in package element " "%" PRIu32 " that is not a valid " - "EISA ID.", name, obj->Integer.Value, i); + "EISA ID.", name, (long unsigned int)obj->Integer.Value, i); failed = true; } } @@ -2092,7 +2092,7 @@ static void method_test_SEG_return( "%s returned value 0x%8.8" PRIx64 " and some of the " "upper 16 reserved bits are set when they " "should in fact be zero.", - name, obj->Integer.Value); + name, (long unsigned int)obj->Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); } else method_passed_sane_uint64(fw, name, obj->Integer.Value); @@ -2333,9 +2333,9 @@ static void method_test_Sx__return( } fwts_log_info(fw, "%s PM1a_CNT.SLP_TYP value: 0x%8.8" PRIx64, name, - obj->Package.Elements[0].Integer.Value); + (long unsigned int)obj->Package.Elements[0].Integer.Value); fwts_log_info(fw, "%s PM1b_CNT.SLP_TYP value: 0x%8.8" PRIx64, name, - obj->Package.Elements[1].Integer.Value); + (long unsigned int)obj->Package.Elements[1].Integer.Value); if (!failed) method_passed_sane(fw, name, "package"); @@ -2484,7 +2484,7 @@ static void method_test_CSD_return( "%s sub-package %d element 0 (NumEntries) " "was expected to have value 0x%" PRIx64 ".", name, i, - pkg->Package.Elements[0].Integer.Value); + (long unsigned int)pkg->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -2496,7 +2496,7 @@ static void method_test_CSD_return( "was expected to have value 1, instead it " "was 0x%" PRIx64 ".", name, i, - pkg->Package.Elements[1].Integer.Value); + (long unsigned int)pkg->Package.Elements[1].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -2511,7 +2511,7 @@ static void method_test_CSD_return( "0xfd (SW_ANY) or 0xfe (HW_ALL), instead it " "was 0x%" PRIx64 ".", name, i, - pkg->Package.Elements[3].Integer.Value); + (long unsigned int)pkg->Package.Elements[3].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -2581,7 +2581,7 @@ static void method_test_CST_return( "%" PRIu32 " returned C state sub-elements yet _CST " "reports it has %" PRIu64 " C states.", name, obj->Package.Count - 1, - obj->Package.Elements[0].Integer.Value); + (long unsigned int)obj->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); return; } @@ -2677,9 +2677,9 @@ static void method_test_CST_return( fwts_log_info_verbatum(fw, "%2" PRIu32 " C%" PRIu64 " %6" PRIu64 " %6" PRIu64, i, - pkg->Package.Elements[1].Integer.Value, - pkg->Package.Elements[2].Integer.Value, - pkg->Package.Elements[3].Integer.Value); + (long unsigned int)pkg->Package.Elements[1].Integer.Value, + (long unsigned int)pkg->Package.Elements[2].Integer.Value, + (long unsigned int)pkg->Package.Elements[3].Integer.Value); } else { fwts_log_info_verbatum(fw, "%2" PRIu32 " -- ----- -----", i); @@ -2850,10 +2850,10 @@ static void method_test_PSS_return( fwts_log_info_verbatum(fw, " %3d %7" PRIu64 " %8" PRIu64 " %5" PRIu64 " %5" PRIu64, i, - pstate->Package.Elements[0].Integer.Value, - pstate->Package.Elements[1].Integer.Value, - pstate->Package.Elements[2].Integer.Value, - pstate->Package.Elements[3].Integer.Value); + (long unsigned int)pstate->Package.Elements[0].Integer.Value, + (long unsigned int)pstate->Package.Elements[1].Integer.Value, + (long unsigned int)pstate->Package.Elements[2].Integer.Value, + (long unsigned int)pstate->Package.Elements[3].Integer.Value); } else { fwts_log_info_verbatum(fw, " %3d ---- ----- -- -- (invalid)", i); @@ -3004,7 +3004,7 @@ static void method_test_TSD_return( " element 0 (NumEntries) " "was expected to have value 0x%" PRIx64 ".", name, i, - pkg->Package.Elements[0].Integer.Value); + (long unsigned int)pkg->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3017,7 +3017,7 @@ static void method_test_TSD_return( "was expected to have value 1, instead it " "was 0x%" PRIx64 ".", name, i, - pkg->Package.Elements[1].Integer.Value); + (long unsigned int)pkg->Package.Elements[1].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3033,7 +3033,7 @@ static void method_test_TSD_return( "0xfd (SW_ANY) or 0xfe (HW_ALL), instead it " "was 0x%" PRIx64 ".", name, i, - pkg->Package.Elements[3].Integer.Value); + (long unsigned int)pkg->Package.Elements[3].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3140,7 +3140,7 @@ static void method_test_TSS_return( "was expected to have value 1..100, instead " "was %" PRIu64 ".", name, i, - pkg->Package.Elements[0].Integer.Value); + (long unsigned int)pkg->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3159,11 +3159,11 @@ static void method_test_TSS_return( fwts_log_info_verbatum(fw, " %3d %3" PRIu64 "%% %7" PRIu64 " %7" PRIu64 " %2.2" PRIx64 " %2.2" PRIx64, i, - pkg->Package.Elements[0].Integer.Value, - pkg->Package.Elements[1].Integer.Value, - pkg->Package.Elements[2].Integer.Value, - pkg->Package.Elements[3].Integer.Value, - pkg->Package.Elements[4].Integer.Value); + (long unsigned int)pkg->Package.Elements[0].Integer.Value, + (long unsigned int)pkg->Package.Elements[1].Integer.Value, + (long unsigned int)pkg->Package.Elements[2].Integer.Value, + (long unsigned int)pkg->Package.Elements[3].Integer.Value, + (long unsigned int)pkg->Package.Elements[4].Integer.Value); } else { fwts_log_info_verbatum(fw, " %3d ---- ----- ----- -- -- (invalid)", i); @@ -3243,7 +3243,7 @@ static void method_test_GCP_return( "%s returned %" PRId64 ", should be between 0 and 15, " "one or more of the reserved bits 4..31 seem " "to be set.", - name, obj->Integer.Value); + name, (long unsigned int)obj->Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); } else method_passed_sane_uint64(fw, name, obj->Integer.Value); @@ -3308,7 +3308,7 @@ static void method_test_GWS_return( "%s returned %" PRIu64 ", should be between 0 and 3, " "one or more of the reserved bits 2..31 seem " "to be set.", - name, obj->Integer.Value); + name, (long unsigned int)obj->Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); } else method_passed_sane_uint64(fw, name, obj->Integer.Value); @@ -3400,13 +3400,13 @@ static void method_test_SBS_return( switch (obj->Integer.Value) { case 0 ... 4: fwts_passed(fw, "%s correctly returned value %" PRIu64 " %s", - name, obj->Integer.Value, + name, (long unsigned int)obj->Integer.Value, sbs_info[obj->Integer.Value]); break; default: fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_SBSReturn", "%s returned %" PRIu64 ", should be between 0 and 4.", - name, obj->Integer.Value); + name, (long unsigned int)obj->Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); fwts_advice(fw, "Smart Battery %s is incorrectly informing " @@ -3485,7 +3485,7 @@ static void method_test_BIF_return( "Method_BIFBadUnits", "%s: Expected Power Unit (Element 0) to be " "0 (mWh) or 1 (mAh), got 0x%8.8" PRIx64 ".", - name, obj->Package.Elements[0].Integer.Value); + name, (long unsigned int)obj->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3522,7 +3522,7 @@ static void method_test_BIF_return( "%s: Expected Battery Technology Unit " "(Element 3) to be 0 (Primary) or 1 " "(Secondary), got 0x%8.8" PRIx64 ".", - name, obj->Package.Elements[3].Integer.Value); + name, (long unsigned int)obj->Package.Elements[3].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3630,7 +3630,7 @@ static void method_test_BIX_return( "%s: Expected %s (Element 1) to be " "0 (mWh) or 1 (mAh), got 0x%8.8" PRIx64 ".", name, elements[1].name, - obj->Package.Elements[1].Integer.Value); + (long unsigned int)obj->Package.Elements[1].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3670,7 +3670,7 @@ static void method_test_BIX_return( "(Element 4) to be 0 (Primary) or 1 " "(Secondary), got 0x%8.8" PRIx64 ".", name, elements[4].name, - obj->Package.Elements[4].Integer.Value); + (long unsigned int)obj->Package.Elements[4].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3786,7 +3786,7 @@ static void method_test_BST_return( "Method_BSTBadState", "%s: Expected Battery State (Element 0) to " "be 0..7, got 0x%8.8" PRIx64 ".", - name, obj->Package.Elements[0].Integer.Value); + name, (long unsigned int)obj->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3797,7 +3797,7 @@ static void method_test_BST_return( "%s: Battery State (Element 0) is " "indicating both charging and discharginng " "which is not allowed. Got value 0x%8.8" PRIx64 ".", - name, obj->Package.Elements[0].Integer.Value); + name, (long unsigned int)obj->Package.Elements[0].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -3943,7 +3943,7 @@ static void method_test_PSR_return( "Method_PSRZeroOrOne", "%s returned 0x%8.8" PRIx64 ", expected 0 " "(offline) or 1 (online)", - name, obj->Integer.Value); + name, (long unsigned int)obj->Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); } else method_passed_sane_uint64(fw, name, obj->Integer.Value); @@ -4117,7 +4117,7 @@ static void method_test_THERM_return( "%s correctly returned sane looking " "value 0x%8.8" PRIx64 " (%5.1f degrees K)", method, - obj->Integer.Value, + (long unsigned int)obj->Integer.Value, (float)((uint64_t)obj->Integer.Value) / 10.0); } else { fwts_failed(fw, LOG_LEVEL_MEDIUM, @@ -4126,7 +4126,7 @@ static void method_test_THERM_return( "0 degrees C: 0x%8.8" PRIx64 " (%5.1f " "degrees K)", method, - obj->Integer.Value, + (long unsigned int)obj->Integer.Value, (float)((uint64_t)obj->Integer.Value) / 10.0); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); fwts_advice(fw, @@ -4596,8 +4596,8 @@ static void method_test_BCL_return( " power (%" PRIu64 ") is less than " "brightness level when on " "battery power (%" PRIu64 ").", - obj->Package.Elements[0].Integer.Value, - obj->Package.Elements[1].Integer.Value); + (long unsigned int)obj->Package.Elements[0].Integer.Value, + (long unsigned int)obj->Package.Elements[1].Integer.Value); fwts_tag_failed(fw, FWTS_TAG_ACPI_METHOD_RETURN); failed = true; } @@ -4611,8 +4611,8 @@ static void method_test_BCL_return( "than brightness level %" PRIu64 " (index %d" PRIu32 "), should " "be in ascending order.", - obj->Package.Elements[i].Integer.Value, i, - obj->Package.Elements[i+1].Integer.Value, i+1); + (long unsigned int)obj->Package.Elements[i].Integer.Value, i, + (long unsigned int)obj->Package.Elements[i+1].Integer.Value, i+1); ascending_levels = true; failed = true; } @@ -4629,14 +4629,14 @@ static void method_test_BCL_return( } fwts_log_info(fw, "Brightness levels for %s:" ,name); - fwts_log_info_verbatum(fw, " Level on full power : %" PRIu64, obj->Package.Elements[0].Integer.Value); - fwts_log_info_verbatum(fw, " Level on battery power: %" PRIu64, obj->Package.Elements[1].Integer.Value); + fwts_log_info_verbatum(fw, " Level on full power : %" PRIu64, (long unsigned int)obj->Package.Elements[0].Integer.Value); + fwts_log_info_verbatum(fw, " Level on battery power: %" PRIu64, (long unsigned int)obj->Package.Elements[1].Integer.Value); for (i = 2; i < obj->Package.Count; i++) { char tmp[12]; snprintf(tmp, sizeof(tmp), "%s%" PRIu64, i == 2 ? "" : ", ", - obj->Package.Elements[i].Integer.Value); + (long unsigned int)obj->Package.Elements[i].Integer.Value); str = fwts_realloc_strcat(str, tmp); if (!str) break; -- 1.7.9.5

10 years, 8 months

[PATCHv2 0/2] make mab not cross 4k boundaries

by Graeme Gregory

This will eventually need to be fixed in kernel but for now to allow work to progress alter mab so it will not attempt to place a table across a page boundary. If people could give this patch some proper testing it would be good as there may be some corner cases I missed constructing this. I have boot tested the result on Arndale. While working on this I discovered that write_table was allocating buffers which were never used and never had free() called on them. Thanks Graeme

10 years, 9 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi August 2013