Hi Guenter , Timur
On 30 May 2015 at 06:10, Guenter Roeck linux@roeck-us.net wrote:
On 05/29/2015 08:46 AM, Timur Tabi wrote:
On 05/29/2015 09:32 AM, Fu Wei wrote:
It is a SPI, every CPU can get it, But maybe I miss something, but please let me know if other CPU can not get the interrupt.
There's only one watchdog device, so there's only one interrupt. I don't know which CPU will get the interrupt, but the watchdog is not a per-CPU device.
Plus, that one interrupt is not shared, and the driver returns IRQ_HANDLED even if the bit is not set. So _something_ is definitely wrong. Either the interrupt is shared, then it needs to be requested as shared and the handler should only return IRQ_HANDLED if it actually handles the interrupt. Or it is not shared and the handler should always handle it.
I have thought about this again, For now, I did not find any reason to keep that "if (status & SBSA_GWDT_WCS_WS0)"
So you are right, I should delete it.
and for IRQF_TIMER, I will delete it.
Thanks for your correction.
Guenter