On 2013-11-23 6:13, al.stone@linaro.org wrote:
From: Al Stone al.stone@linaro.org
Most of drivers/acpi/processor_idle.c is x86-centric. So, modify the
CONFIG_ACPI_PROCESSOR is not only for processor_idle.c, but also for processor_driver.c processor_throttling.c processor_thermal.c processor_perflib.c
here is the Makefile I copied: [...] obj-$(CONFIG_ACPI_PROCESSOR) += processor.o [...] # processor has its own "processor." module_param namespace processor-y := processor_driver.o processor_throttling.o processor-y += processor_idle.o processor_thermal.o processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
So I think it is too much extension for processor_idle.c.
kernel config so it is not included unless working on an x86 platform.
Signed-off-by: Al Stone al.stone@linaro.org
drivers/acpi/Kconfig | 3 ++- drivers/acpi/processor_idle.c | 35 ----------------------------------- 2 files changed, 2 insertions(+), 36 deletions(-)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 32ec313..a876bca 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -175,6 +175,7 @@ config ACPI_PROCESSOR select THERMAL select CPU_IDLE default y
- depends on X86 help This driver installs ACPI as the idle handler for Linux and uses ACPI C2 and C3 processor states to save power on systems that
@@ -215,7 +216,7 @@ config ACPI_PROCESSOR_AGGREGATOR config ACPI_THERMAL tristate "Thermal Zone"
- depends on ACPI_PROCESSOR
- depends on ACPI_PROCESSOR || ARM || ARM64
I think it depends on the driver of processor_thermal.c and processor_throttling.c, Thermal Zone can not run properly without such drivers.
I have an idea: we don't change the Kconfig, but change the Makefile,
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 0331f91..f91edee 100644 --- a/drivers/acpi/Makefile +++ b/drivers/acpi/Makefile @@ -75,7 +75,8 @@ obj-$(CONFIG_ACPI_BGRT) += bgrt.o
# processor has its own "processor." module_param namespace processor-y := processor_driver.o processor_throttling.o -processor-y += processor_idle.o processor_thermal.o +processor-y += processor_thermal.o +processor-$(CONFIG_X86) += processor_idle.o processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o
is this make sense to you?
Thanks Hanjun