Sorry, this is wrong. There are still generic addresses in HW_REDUCED mode, please ignore this.
Thanks -Lv
-----Original Message----- From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Zheng, Lv Sent: Friday, November 22, 2013 2:06 PM To: al.stone@linaro.org; linux-acpi@vger.kernel.org Cc: linaro-acpi@lists.linaro.org; Al Stone Subject: RE: [PATCH 06/12] ACPI: ensure several FADT fields are only used in HW reduced mode
From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of al.stone@linaro.org Sent: Sunday, November 10, 2013 9:36 AM
From: Al Stone ahs3@redhat.com
In acpi_os_terminate(), it was assumed that several FADT entries were mapped into memory. For HW reduced mode, that will not be the case.
Signed-off-by: Al Stone al.stone@linaro.org
drivers/acpi/osl.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c index 017b85c..075545e 100644 --- a/drivers/acpi/osl.c +++ b/drivers/acpi/osl.c @@ -1812,10 +1812,12 @@ acpi_status acpi_os_terminate(void) acpi_irq_handler); }
- acpi_os_unmap_generic_address(&acpi_gbl_FADT.xgpe1_block);
- acpi_os_unmap_generic_address(&acpi_gbl_FADT.xgpe0_block);
- acpi_os_unmap_generic_address(&acpi_gbl_FADT.xpm1b_event_block);
- acpi_os_unmap_generic_address(&acpi_gbl_FADT.xpm1a_event_block);
if (!acpi_gbl_reduced_hardware) {
acpi_os_unmap_generic_address(&acpi_gbl_FADT.xgpe1_block);acpi_os_unmap_generic_address(&acpi_gbl_FADT.xgpe0_block);acpi_os_unmap_generic_address(&acpi_gbl_FADT.xpm1b_event_block);acpi_os_unmap_generic_address(&acpi_gbl_FADT.xpm1a_event_block);}
destroy_workqueue(kacpid_wq); destroy_workqueue(kacpi_notify_wq);
Is that possible to make stubs for acpi_os_map_generic_address and acpi_os_unmap_generic_address when CONFIG_ACPI_REDUCED_HARDWARE is enabled? So that this patch and some logics in the PATCH 07 can be removed.
Thanks -Lv
-- 1.8.3.1
-- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
-- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html