On 2015年02月20日 19:35, Lorenzo Pieralisi wrote:
On Wed, Feb 18, 2015 at 01:53:46PM +0000, Hanjun Guo wrote:
CPU hardware ID (phys_id) is defined as u32 in structure acpi_processor, but phys_id is used as int in acpi processor driver, so it will lead to some inconsistence for the drivers.
Further more, when ARM64 was introduced into ACPI, CPU hardware ID used by ARM64 is 64 bits, u32 or int is not suitable.
"Furthermore, to cater for ACPI arch ports that implement 64 bits CPU ids a generic CPU physical id type is required"; arm64 is not introduced till later patch, so you should not mention that.
So introduce typedef u32 phys_cpuid_t for x86 and ia64, and introduce a macro CPU_PHYS_ID_INVALID as (u32)(-1), use phys_cpuid_t when phys_id defined in acpi processor driver, and replace CPU_PHYS_ID_INVALID as -1 for phys_id, this will solve the inconsistence in acpi processor driver, and will prepare for the ACPI on ARM64 too.
phys_cpuid_t was suggested by Lorenzo and Catalin, and CPU_PHYS_ID_INVALID was suggested by Rafael.
Remove the sentence above, this patch is Catalin's code (so you should keep his Signed-off-by) and add a comment to your signed-off-by tag saying what you changed, eg:
[reworked cpu physid map return codes] Signed-off-by: Hanjun Guo hanjun.guo@linaro.org
You could use Suggested-by tag too, but do not write "suggested by Lorenzo" in the commit log, that's not really useful, use tags instead.
Sure, I will. How about:
Suggested-by: Lorenzo Pieralisi lorenzo.pieralisi@arm.com Signed-off-by: Catalin Marinas catalin.marinas@arm.com [hj: reworked cpu physid map return codes] Signed-off-by: Hanjun Guo hanjun.guo@linaro.org
Thanks Hanjun