Hi Mark
On 26 October 2016 at 18:51, Mark Rutland mark.rutland@arm.com wrote:
On Wed, Oct 26, 2016 at 04:31:55PM +0800, Fu Wei wrote:
On 20 October 2016 at 22:45, Mark Rutland mark.rutland@arm.com wrote:
On Thu, Sep 29, 2016 at 02:17:09AM +0800, fu.wei@linaro.org wrote:
#include <linux/timecounter.h> #include <linux/types.h>
+#define ARCH_CP15_TIMER BIT(0) +#define ARCH_MEM_TIMER BIT(1)
If we're going to expose these in a header, it would be better to rename them to something that makes their usage/meaning clear. These should probably be ARCH_TIMER_TYPE_{CP15,MEM}.
With those changes (regardless of the ARCH_TIMER_TYPE_* bits):
Acked-by: Mark Rutland mark.rutland@arm.com
For ARCH_TIMER_TYPE_*, maybe I should add a patch at the end of this patchset to fix it, OK ?
Sure. If you could put that *earlier* in the patchset it would be preferable so as to minimize churn.
OK, NP, will do
Thanks, Mark.