Hi Lv,
Sorry for the late reply, I have some comments below.
On 2013-11-25 16:14, Zheng, Lv wrote: [...]
+#ifdef CONFIG_ACPI_REDUCED_HARDWARE +#define ACPI_REDUCED_HARDWARE TRUE +#endif
Maybe you put this here because of my previous wrong comment.
For ACPICA environments that work like Kconfigs for Linux, it is good to define them before including any ACPICA files. While putting things here cannot cover <asm/acpi.h>.
Good catch! thanks for the reminding.
Normally, I will do:
...
#ifdef __KERNEL__
/* some comment */ (one empty line as ACPICA enforces 1 empty line after 1 line comment and no empty lines after a block of comments) #ifdef CONFIG_ACPI_REDUCED_HARDWARE #define ACPI_REDUCED_HARDWARE(spaces not tabs here according to ACPICA's coding style)TRUE #endif
#include <linux/string.h>
There is a problem when I try yours suggestion, it is a compiling warning:
warning: "TRUE" is not defined
And I find that "TRUE" is defined in include/acpi/actypes.
So, is this ok to you?
... How ugly the TRUE is. OK, you can keep your original code as this is really not a real issue, just a tricky point. I'll try to offer a cleanup after another ACPICA cleanup that tries to modify all "#if" condition related TRUE into "1" in ACPICA.
I checked ACPICA code base and found there is really nothing need to be cleaned up.
Why not: +#ifdef CONFIG_ACPI_REDUCED_HARDWARE +#define ACPI_REDUCED_HARDWARE 1 +#endif
In include/acpi/acconfig.h:
#ifndef ACPI_REDUCED_HARDWARE #define ACPI_REDUCED_HARDWARE FALSE #endif
In order to make the code consistent, I used "TRUE" here.
But it is ok to me to use "1" here, will update in next version.
Thanks Hanjun