31 Mar
2014
31 Mar
'14
6:25 p.m.
Hi Ashwin,
On 31/03/14 18:25, Ashwin Chaugule wrote:
On 31 March 2014 13:09, Ashwin Chaugule ashwin.chaugule@linaro.org wrote:
Hi Sudeep,
On 31 March 2014 12:52, Sudeep Holla sudeep.holla@arm.com wrote:
if (ver == PSCI_RET_EOPNOTSUPP) {pr_info("PSCI_ID_VERSION Function not supported in firmware.\n");IMO you should stop here as the implementation conforming to the specification must return a minor version number of 2 and major version number of 0. You can't proceed, assume ids and use them.
hm, you're right, I missed that.
Something like this?
if (ver == PSCI_RET_EOPNOTSUPP) { /* PSCI v0.2+ mandates implementation of PSCI_ID_VERSION. */ pr_err("PSCI firmware does not comply with the v0.2 spec.\n"); err = -EOPNOTSUPP; goto out_put_node;
Yes that looks fine to me.
Regards, Sudeep