On Saturday, December 20, 2014 07:14:33 PM Ashwin Chaugule wrote:
Hi Rafael,
On 15 December 2014 at 10:16, Rafael J. Wysocki rjw@rjwysocki.net wrote:
On Monday, December 15, 2014 09:42:08 AM Ashwin Chaugule wrote:
On 1 December 2014 at 09:56, Dirk Brandewie dirk.brandewie@gmail.com wrote:
On 11/30/2014 10:26 PM, Viresh Kumar wrote:
On 1 December 2014 at 11:53, Ashwin Chaugule ashwin.chaugule@linaro.org wrote:
On 19 November 2014 at 15:36, Ashwin Chaugule ashwin.chaugule@linaro.org wrote: > > CPPC (Collaborative Processor Performance Control) is defined > in the ACPI 5.0+ spec. It is a method for controlling CPU > performance on a continuous scale using performance feedback > registers. In contrast to the legacy "pstate" scale which is > discretized, and tied to CPU frequency, CPPC works off of an > abstract continuous scale. This lets the platforms freely interpret > the abstract unit and optimize it for power and performance given > its knowledge of thermal budgets and other constraints. > > The PID governor operates on similar concepts and can use CPPC > semantics to acquire the information it needs. This information > may be provided by various platforms via MSRs, CP15s or memory > mapped registers. CPPC helps to wrap all these variations into a > common framework. > > This patch introduces CPPC using PID as its governor for CPU > performance management. > > Signed-off-by: Ashwin Chaugule ashwin.chaugule@linaro.org > --- > drivers/cpufreq/Kconfig | 12 + > drivers/cpufreq/Makefile | 1 + > drivers/cpufreq/acpi_pid.c | 1156 > ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1169 insertions(+) > create mode 100644 drivers/cpufreq/acpi_pid.c
Ping.
Any comments on these patches?
Redirecting the Ping to Rafael/Dirk :)
Ashwin has incorporated my feedback. I have no issues
Thanks Dirk! I'll add your Reviewed-by to the patchset.
Rafael, any comments from your side?
I have a couple of quick ones (will post them shortly), but generally I need more time to review the whole thing.
Thanks for the quick review. I've added those changes locally. Just this week we were able to run these drivers (CPPC + PCC) on an ARM64 platform with some CPPC support in the firmware. This helped in catching a couple of bugs, which didn't show up on the X86 platform which I'd been using all this while. So, I'll send V4 with the new changes for your review at the earliest.
Please don't hurry, I most likely won't be able to review it in the next few weeks anyway.