Re: [Linaro-acpi] [PATCH 10/38] ARM64 / ACPI: Introduce some PCI functions when PCI is enabled

On Wednesday 05 November 2014 20:32:29 al.stone@linaro.org wrote:

+/**

• • raw_pci_read - Platform-specific PCI config space access.
• • Default empty implementation. Replace with an architecture-specific setup
• • routine, if necessary.
• */

+int __weak raw_pci_read(unsigned int domain, unsigned int bus,

•                   unsigned int devfn, int reg, int len, u32 *val)
  

+{

•   return -EINVAL;
  

+}

+int __weak raw_pci_write(unsigned int domain, unsigned int bus,

•                   unsigned int devfn, int reg, int len, u32 val)
  

+{

•   return -EINVAL;
  

+}

+/* Root bridge scanning */ +struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) +{

•   return NULL;
  

+}

Having __weak implementations makes no sense here, there is no code that could override them. I guess these could go into drivers/pci/host/pci-host-generic.c once if you add the patch to your series that implements arm64 support for this driver.

Arnd