On 09/10/2015 06:14 AM, Graeme Gregory wrote:
On Wed, Sep 09, 2015 at 03:09:47PM -0600, Al Stone wrote:
The existing BAD_MADT_ENTRY macro only checks that the size of the data structure for an MADT subtable matches the length entry in the subtable. This is, unfortunately, not reliable. Nor, as it turns out, does it have anything to do with what the length should be in any particular table.
[snip...] if (handler(entry, table_end))
return -EINVAL;
@@ -349,7 +592,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler) return -ENODEV; } -/* +/*
- The BIOS is supposed to supply a single APIC/MADT,
- but some report two. Provide a knob to use either.
- (don't you wish instance 0 and 1 were not the same?)
Unrelated whitespace change snuck in here.
Graeme
Bah. Nice catch; not sure how that got in there, but duly noted.