On 18 November 2014 08:39, Arnd Bergmann arnd@arndb.de wrote:
On Wednesday 12 November 2014 19:59:38 Ashwin Chaugule wrote:
ACPI 5.0+ spec defines a generic mode of communication between the OS and a platform such as the BMC. This medium (PCC) is typically used by CPPC (ACPI CPU Performance management), RAS (ACPI reliability protocol) and MPST (ACPI Memory power states).
This patch adds PCC support as a Mailbox Controller. As of ACPI v5.1 there is no provision for clients to lookup mailbox controllers in a way that Linux expects. e.g. in DT the clients can list the mailboxes they can associate with in the DT binding and then provide a unique index to lookup a channel within a mailbox. Since the ACPI spec doesn't have anything similar, we introduce a mailbox controller specific API so that when the client calls it, we know to lookup in the context of a specific controller. This also helps in keeping a consistent interface across DT and ACPI for such drivers.
This patch implements basic PCC support using the ACPI v5.1 structures. IRQ mode support will be provided as follow up patches.
Reviewed-by: Mark Brown broonie@kernel.org Signed-off-by: Ashwin Chaugule ashwin.chaugule@linaro.org
Reviewed-by: Arnd Bergmann arnd@arndb.de
Very much appreciated ! Thanks for the constructive feedback Arnd, Jassi, Mark, Sudeep, Lv and Rafael! Jassi, can you please pick this patch? or if you'd prefer, I can send a git pull for it.
Thanks, Ashwin