On Friday, February 13, 2015 08:07:44 AM Ashwin Chaugule wrote:
Hello,
On 27 January 2015 at 16:03, Ashwin Chaugule ashwin.chaugule@linaro.org wrote:
Previously the PCC driver depended on the client side to map the communication space base address. This region was was then used in the PCC driver and the client side. The client side used this region to read and write its data and the PCC driver used it to only write the PCC command. Removing this split simplifies the PCC driver a lot. This patch moves all communication region read/writes to the client side. The PCC clients can now drive the PCC mailbox controller via the mbox_client_txdone() method.
Signed-off-by: Ashwin Chaugule ashwin.chaugule@linaro.org
drivers/mailbox/pcc.c | 122 +++++++++++++++----------------------------------- 1 file changed, 37 insertions(+), 85 deletions(-)
Gentle reminder for this patch specifically. It can be pulled in by itself separately from the CPPC patch[2/2], which understandably may need more time for review. Apart from the simplification done here, there is one more change based on a comment I got from Rafael to convert a pr_err() in the init function to pr_debug(). The "PCC Probe failed" message seems to be raising false positives on X86 test reports. Please let me know if there are any other suggestions, before I respin another version for this.
The patch changing the pr_err() to pr_debug() is in the Linus' tree already as far as I can say.
Besides, this should be To: the maintainer of the mailbox susbsystem (not me) or if you want me to pick it up, I need and ACK from that maintainer anyway.