Re: [Linaro-acpi] [PATCH 2/5] mab: if -p <paddr> is not given, we would segfault; die more gracefully now

Curses, sometimes I forget I'm not using a scripting language.

Acked-by: Graeme Gregory graeme.gregory@linaro.org

On 13/08/13 00:10, al.stone@linaro.org wrote:

From: Al Stone ahs3@redhat.com

Signed-off-by: Al Stone al.stone@linaro.org

tools/mab/mab.c | 5 +++++ 1 file changed, 5 insertions(+)

diff --git a/tools/mab/mab.c b/tools/mab/mab.c index 6c5857b..f906efb 100644 --- a/tools/mab/mab.c +++ b/tools/mab/mab.c @@ -468,6 +468,7 @@ int main(int argc, char *argv[]) homedir = NULL; acpi_blob_name = NULL; iasl_cmd = NULL;

• paddr_cmd = NULL; quiet = 0;

while ((opt = getopt(argc, argv, "d:o:i:c:p:q")) != EOF) { @@ -517,6 +518,10 @@ int main(int argc, char *argv[]) printf("relocating blob to 0x%llx\n", paddr); } paddr += BLOB_HEADER_SIZE;

• } else {

• printf("? missing required physical address parameter\n");
  

• usage();
  

• return 1;
  

  }

/* what tables do we need to do something about? */