Hi,
I have recently started following Linaro ACPI work and this pinctrl patches look interesting. The ASL representation of pinctrl looks complete enough. I have some minor review comments but I guess this patch series is not complete so the comments may be trivial at this stage.
Regards, Amit D
On Fri, Aug 30, 2013 at 4:16 AM, al.stone@linaro.org wrote:
From: Al Stone ahs3@redhat.com
I should have sent these out for comment much sooner. Once these are in good shape, the next steps are to send patches for verifying that the pinconf code is working properly, connecting up the GPIO interrupts using ACPI, and then conversion of all of the pin controllers for Arndale (this patch converts one of four).
This patch puts most of the infrastructure in place so that in the 3.11 kernel the Arndale pin controllers can be converted from FDT to ACPI. The changes in ASL are included in a separate patch. What this allows is for the pin controllers to be described in either FDT or ACPI for Arndale and -- in conjunction with the ASL changes -- shows how to describe a Samsung controller in ACPI.
Changes for v2: -- Add patch 6 which allows compilation regardless of whether CONFIG_ACPI is used or not
Al Stone (6): ACPI: ARM: arndale: remove GPZ GPIO definition from DT so it can be in ACPI ACPI: ARM: arndale: whitelist the samsung-pinctrl driver for ACPI ACPI: make an error message a little clearer ACPI: improve acpi_extract_package() utility ACPI: ARM: arndale: enable ACPI in the Samsung pinctrl driver ACPI: ARM: arndale: add CONFIG_ACPI ifdef's to pinctrl driver
arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 2 + arch/arm/boot/dts/exynos5250.dtsi | 6 +- drivers/acpi/acpi_platform.c | 3 + drivers/acpi/osl.c | 2 +- drivers/acpi/utils.c | 17 +- drivers/pinctrl/pinctrl-samsung.c | 517 +++++++++++++++++++++++++++++- drivers/pinctrl/pinctrl-samsung.h | 3 + 7 files changed, 536 insertions(+), 14 deletions(-)
-- 1.8.3.1
Linaro-acpi mailing list Linaro-acpi@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-acpi