On 05/28/2013 09:21 AM, Graeme Gregory wrote:
On Tue, May 28, 2013 at 05:07:55PM +0200, Andrea Gallo wrote:
On 27 May 2013 17:40, Graeme Gregory graeme.gregory@linaro.org wrote:
From: Graeme Gregory graeme.gregory@linaro.org
For prototype add information for s3c24xx-i2c probing from DSDT
Signed-off-by: Graeme Gregory graeme.gregory@linaro.org
arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl | 46 ++++++++++++++------ 1 file changed, 33 insertions(+), 13 deletions(-)
diff --git a/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl b/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl index ed99d6e..165f283 100644 --- a/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl +++ b/arch/arm/boot/asl/exynos5250-arndale.acpi/dsdt.asl @@ -1,23 +1,43 @@ /*
- Copyright (c) 2013, Al Stone ahs3@redhat.com
- [DSDT] Description of the Arndale board (exynos5250)
- This source is released under the terms of the GPLv2.
*/
DefinitionBlock (
"dsdt.aml", // output filename
"DSDT", // table signature
1, // DSDT compliance revision
"REDHAT", // OEM ID
"ARNDALE ", // table ID
0x00000002) // OEM revision
"dsdt.aml", // output filename
"DSDT", // table signature
1, // DSDT compliance revision
"REDHAT", // OEM ID
"ARNDALE ", // table ID
0x00000002) // OEM revision
[AG] why REDHAT as OEM ID? is this referring to the board manufacturer or the author of the table?
According to the spec, the OEM ID is whatever the table writer wishes. As a practical matter, it appears it is usually the board manufacturer who also is typically the table writer.
If the former, then OEM should be Samsung. If the latter, I guess it should be then LINARO instead of REDHAT, if this refers to the work done by Al under his Linaro assignment.
Hope Masters-Jon-Masters does not get mad at me :-)
Sweet little old Jon? How could he ever get mad :)?
These were set by Al, they should not actually have been in my patch but I think my editor settings have changed the whitespacing to be kernel compliant and I did not notice when I commited.
Graeme
Hrm. I didn't even think about these much when I made the initial tables, just sort of filled them in while on autopilot; the templates say "INTEL " and that was _definitely_ not going to work :).
I should probably put together a patch to clean these up with an OEM ID of "SAMSNG" (6 chars only)....or, as people make changes, toss that one in, too...