Linaro-acpi December 2013

linaro-acpi@lists.linaro.org

19 participants
38 discussions

[PATCH] rtsm_ve-aemv8a: correct GIC addresses in APIC table

by Graeme Gregory

The addresses were not updated from the change to the FVP model. Correct the addresses. Boot tested with patch series from Hanjun Guo Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- platforms/rtsm_ve-aemv8a.acpi/apic.asl | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/platforms/rtsm_ve-aemv8a.acpi/apic.asl b/platforms/rtsm_ve-aemv8a.acpi/apic.asl index c782e70..b000068 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/apic.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/apic.asl @@ -44,7 +44,7 @@ [0004] Asl Compiler ID : "INTL" [0004] Asl Compiler Revision : 20110623 -[0004] Local Apic Address : 2C002000 +[0004] Local Apic Address : 2C000000 [0004] Flags (decoded below) : 00000001 PC-AT Compatibility : 0 @@ -58,7 +58,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 /* this is the foundation model's GIC address */ +[0008] Base Address : 000000002C000000 /* this is the foundation model's GIC address */ [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -70,7 +70,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -82,7 +82,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -94,7 +94,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -106,7 +106,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -118,7 +118,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -130,7 +130,7 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0B [Generic Interrupt Controller] [0001] Length : 28 @@ -142,12 +142,12 @@ [0004] Parking Protocol Version : 00000000 [0004] Performance Interrupt : 00000000 [0008] Parked Address : 0000000000000000 -[0008] Base Address : 000000002C002000 +[0008] Base Address : 000000002C000000 [0001] Subtable Type : 0C [Generic Interrupt Distributor] [0001] Length : 18 [0002] Reserved : 0000 [0004] Local GIC Hardware ID : 00000000 -[0008] Base Address : 000000002C001000 /* armv8 foundation model's GIC distributor base addr */ +[0008] Base Address : 000000002F000000 /* armv8 foundation model's GIC distributor base addr */ [0004] Interrupt Base : 00000000 [0004] Reserved : 00000000 -- 1.8.4.2

10 years, 4 months

[PATCH] rtsm_ve-aemv8a: Add ASL for vexpress sysreg

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> Add ASL to support vexpress sysreg rtsm_ve-aemv8a platform. Signed-off-by: Naresh Bhat <naresh.bhat(a)linaro.org> --- platforms/rtsm_ve-aemv8a.acpi/dsdt.asl | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl index 8cea035..bd15413 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl @@ -389,6 +389,18 @@ DefinitionBlock ( ,, , AddressRangeMemory, TypeStatic) }) + Device (SREG) { + Name (_HID, "LNRO0009") + Name (_UID, 0) + + Method (_CRS, 0x0, Serialized) { + Name (RBUF, ResourceTemplate() { + Memory32Fixed (ReadWrite, 0x1c010000, 0x1000) + }) + Return (RBUF) + } + } + Device (VIRT) { Name (_HID, "LNRO0005") Name (_UID, 0) -- 1.7.9.5

10 years, 4 months

[PATCH] ACPI: explicitly initialize a value to silence compiler warning

by al.stone＠linaro.org

From: Al Stone <al.stone(a)linaro.org> In acpi_processor_resume(), the variable resumed_bm_rld is being used without being initialized, so initialize it. Signed-off-by: Al Stone <al.stone(a)linaro.org> --- drivers/acpi/processor_idle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 597cdab..86d11a6 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -213,7 +213,7 @@ static int acpi_processor_suspend(void) static void acpi_processor_resume(void) { - u32 resumed_bm_rld; + u32 resumed_bm_rld = 0; acpi_read_bit_register(ACPI_BITREG_BUS_MASTER_RLD, &resumed_bm_rld); if (resumed_bm_rld == saved_bm_rld) -- 1.8.3.1

10 years, 4 months

[PATCH 1/2] irq, irqdomain: Refactor irq_create_of_mapping function.

by Tomasz Nowicki

Move OF specific logic to OF irq.c file and make it more generic so acpi can use it too. Signed-off-by: Tomasz Nowicki <tomasz.nowicki(a)linaro.org> --- drivers/of/irq.c | 42 ++++++++++++++++++++++++++++++++++++++++++ include/linux/irqdomain.h | 3 +++ kernel/irq/irqdomain.c | 31 ++++++++++--------------------- 3 files changed, 55 insertions(+), 21 deletions(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 786b0b4..2bac976 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -26,6 +26,48 @@ #include <linux/string.h> #include <linux/slab.h> + +/** + * irq_create_of_mapping - Look up for domain and map an interrupt given irq + * @irq_data: pointer to arguments structure + * + * This function looks for associated domain, optionally translates, and maps + * int linux virq space + */ +unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) +{ + struct irq_domain *domain; + irq_hw_number_t hwirq; + unsigned int type = IRQ_TYPE_NONE; + + if (!irq_data->np) { + /* + * Nothing wrong with that, try default domain. + */ + domain = NULL; + } else { + domain = irq_find_host(irq_data->np); + if (!domain) { + pr_warn("no irq domain found for %s !\n", + of_node_full_name(irq_data->np)); + return 0; + } + } + + /* If domain has no translation, then we assume interrupt line */ + if (domain->ops->xlate == NULL) + hwirq = irq_data->args[0]; + else { + if (domain->ops->xlate(domain, irq_data->np, irq_data->args, + irq_data->args_count, &hwirq, &type)) + return 0; + } + + /* Create mapping */ + return irq_create_mapping_type(domain, hwirq, type); +} +EXPORT_SYMBOL_GPL(irq_create_of_mapping); + /** * irq_of_parse_and_map - Parse and map an interrupt into linux virq space * @dev: Device node of the device whose interrupt is to be mapped diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index c983ed1..c14f59b 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -175,6 +175,9 @@ extern void irq_domain_associate_many(struct irq_domain *domain, extern unsigned int irq_create_mapping(struct irq_domain *host, irq_hw_number_t hwirq); +extern unsigned int irq_create_mapping_type(struct irq_domain *domain, + irq_hw_number_t hwirq, + unsigned int type); extern void irq_dispose_mapping(unsigned int virq); /** diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index c661552..bf74a0b 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -465,29 +465,18 @@ int irq_create_strict_mappings(struct irq_domain *domain, unsigned int irq_base, } EXPORT_SYMBOL_GPL(irq_create_strict_mappings); -unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) +/** + * irq_create_mapping_type() - Create mapping and set given irq type + * @domain: domain owning this hardware interrupt + * @hwirq: hardware interrupt + * @type: interrupt type + */ +unsigned int irq_create_mapping_type(struct irq_domain *domain, + irq_hw_number_t hwirq, + unsigned int type) { - struct irq_domain *domain; - irq_hw_number_t hwirq; - unsigned int type = IRQ_TYPE_NONE; unsigned int virq; - domain = irq_data->np ? irq_find_host(irq_data->np) : irq_default_domain; - if (!domain) { - pr_warn("no irq domain found for %s !\n", - of_node_full_name(irq_data->np)); - return 0; - } - - /* If domain has no translation, then we assume interrupt line */ - if (domain->ops->xlate == NULL) - hwirq = irq_data->args[0]; - else { - if (domain->ops->xlate(domain, irq_data->np, irq_data->args, - irq_data->args_count, &hwirq, &type)) - return 0; - } - /* Create mapping */ virq = irq_create_mapping(domain, hwirq); if (!virq) @@ -499,7 +488,7 @@ unsigned int irq_create_of_mapping(struct of_phandle_args *irq_data) irq_set_irq_type(virq, type); return virq; } -EXPORT_SYMBOL_GPL(irq_create_of_mapping); +EXPORT_SYMBOL_GPL(irq_create_mapping_type); #ifdef CONFIG_ACPI unsigned int irq_create_acpi_mapping(irq_hw_number_t hwirq, -- 1.7.9.5

10 years, 4 months

[PATCH v3 0/5] Hardware Reduced Mode Cleanup for ACPI

by al.stone＠linaro.org

From: Al Stone <al.stone(a)linaro.org> This series of patches starts with Hanjun's patch to create a kernel config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I then reviewed all of the code that touched any of several fields in the FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced mode [1]. Any time there was a use of one of the fields to be ignored, I evaluated whether or not the code was implementing Hardware Reduced mode correctly. Similarly, for each the flags in the FADT flags field that are to be ignored in Hardware Reduced mode, the kernel code was again scanned for proper usage. The remainder of the patches are to fix all of the situations I could find where the kernel would not behave correctly in this ACPI mode. These seem to work just fine on the RTSM model for ARMv7, both with and without ACPI enabled, and with and without ACPI_REDUCED_HARDWARE enabled; similarly for the FVP model for ARMv8. The patches for ACPI on ARM hardware have been submitted elsewhere but they presume that reduced HW mode is functioning correctly. In the meantime, there's no way I can think of to test all possible scenarios so feedback would be greatly appreciated. [0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5… [1] Please see the ACPI Specification v5.0 for details on Hardware Reduced mode (sections 3.11.1, 4.1, 5.2.9, at a minimum). Changes for v3: -- Modified enabling ACPI_REDUCED_HARDWARE in ACPICA when using kernel config item CONFIG_ACPI_REDUCED_HARDWARE; now consistent with ACPICA code base where needed -- Enable X86 for CONFIG_ACPI_REDUCED_HARDWARE -- Minimize bus master reload patching -- Remove unneeded patch for dmi_check_system() (was 4/6) -- Correct the patch for removing unneeded map/unmap of FADT fields Changes for v2: -- Remove patch that was outside of reduced HW mode changes -- Simplify CONFIG_ACPI_REDUCED_HARDWARE in Kconfig -- Simplify use of CONFIG_ACPI_REDUCED_HARDWARE in #ifdefs -- Ensure changelogs are present -- Combine and simplify previous patches 8 & 10 Al Stone (5): ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode ACPI: bus master reload not supported in reduced HW mode ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field ACPI: in HW reduced mode, using FADT PM information is not allowed. ACPI: do not map/unmap memory regions for FADT entries in reduced HW mode drivers/acpi/Kconfig | 8 ++++++++ drivers/acpi/bus.c | 3 ++- drivers/acpi/osl.c | 36 +++++++++++++++++------------------- drivers/acpi/pci_link.c | 2 ++ drivers/acpi/processor_idle.c | 15 +++++++++++++-- include/acpi/platform/aclinux.h | 6 ++++++ 6 files changed, 48 insertions(+), 22 deletions(-) -- 1.8.3.1

10 years, 4 months

[PATCH] rtsm_ve-aemv8a: add ASL for fixed regulator

by Graeme Gregory

Signed-off-by: Graeme Gregory <graeme.gregory(a)linaro.org> --- platforms/rtsm_ve-aemv8a.acpi/dsdt.asl | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl index 8cea035..a230d07 100644 --- a/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl +++ b/platforms/rtsm_ve-aemv8a.acpi/dsdt.asl @@ -436,6 +436,25 @@ DefinitionBlock ( Return (0x00) } + Device (REG0) { + Name (_HID, "LNRO0019") + Name (_UID, 0) + + Method(_DSM, 4, NotSerialized) { + Store (Package (8) + { + "regulator-name", "3V3", + "regulator-min-microvolt", "3300000", + "regulator-max-microvolt", "3300000", + "regulator-always-on", "1", + }, Local0) + + DTGP (Arg0, Arg1, Arg2, Arg3, RefOf (Local0)) + + Return (Local0) + } + } + Device (AMBA) { Name (_HID, "AMBA0000") Name (_UID, 0) -- 1.8.4.2

10 years, 4 months

[linaro-acpi 0/4] acpi-asl: DBG2 table support

by naresh.bhat＠linaro.org

From: Naresh Bhat <naresh.bhat(a)linaro.org> The DBG2 table support in iASL compiler is completed which will be available in next release of acpica https://github.com/acpica/acpica/commit/278cbb119f090d3aad0480381126c1ae8e5… the following set of patches support the DBG2 table in acpi-asl tool. Naresh Bhat (4): ACPI / ASL: Add DBG2 table across platforms DBG2: Update platforms manifest DBG2: Update xsdt entries across platforms DBG2: Support DBG2 table compilation platforms/exynos5250-arndale.acpi/dbg2.asl | 106 ++++++++++++++++++++ .../exynos5250-arndale.manifest | 1 + platforms/exynos5250-arndale.acpi/xsdt.asl | 1 + platforms/foundation-v8.acpi/dbg2.asl | 106 ++++++++++++++++++++ .../foundation-v8.acpi/foundation-v8.manifest | 1 + platforms/foundation-v8.acpi/xsdt.asl | 1 + platforms/rtsm_ve-aemv8a.acpi/dbg2.asl | 106 ++++++++++++++++++++ .../rtsm_ve-aemv8a.acpi/rtsm_ve-aemv8a.manifest | 1 + platforms/rtsm_ve-aemv8a.acpi/xsdt.asl | 1 + tools/common/build_aml.c | 1 + tools/common/check_aml.c | 1 + tools/common/include/check_aml.h | 1 + 12 files changed, 327 insertions(+) create mode 100644 platforms/exynos5250-arndale.acpi/dbg2.asl create mode 100644 platforms/foundation-v8.acpi/dbg2.asl create mode 100644 platforms/rtsm_ve-aemv8a.acpi/dbg2.asl -- 1.7.9.5

10 years, 4 months

[PATCH] acpi, mtd: Add support for flash device in physical memory map based on ACPI description

by Tomasz Nowicki

This provides a 'mapping' driver which allows the NOR Flash and ROM driver code to communicate with chips which are mapped physically into the CPU's memory. The mapping description here is taken from DSDT ACPI table. This code was "inspired" by physmap_of.c Signed-off-by: Tomasz Nowicki <tomasz.nowicki(a)linaro.org> --- drivers/acpi/acpi_platform.c | 4 + drivers/mtd/maps/Kconfig | 9 + drivers/mtd/maps/Makefile | 1 + drivers/mtd/maps/physmap_acpi.c | 437 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 451 insertions(+) create mode 100644 drivers/mtd/maps/physmap_acpi.c diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index 1359eda..4afc430 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c @@ -36,6 +36,10 @@ static const struct acpi_device_id acpi_platform_device_ids[] = { { "LNRO0007" }, /* armv8 pmu */ { "LNRO0009" }, /* vexpress-sysreg */ { "LNRO000A" }, /* uart-pl011 */ + { "LNRO000B" }, /* flash cfi_probe */ + { "LNRO000C" }, /* flash jedec_probe */ + { "LNRO000D" }, /* flash map_ram */ + { "LNRO000E" }, /* flash direct-mapped */ { } }; diff --git a/drivers/mtd/maps/Kconfig b/drivers/mtd/maps/Kconfig index 310dc7c..07d26e0 100644 --- a/drivers/mtd/maps/Kconfig +++ b/drivers/mtd/maps/Kconfig @@ -74,6 +74,15 @@ config MTD_PHYSMAP_OF physically into the CPU's memory. The mapping description here is taken from OF device tree. +config MTD_PHYSMAP_ACPI + tristate "Flash device in physical memory map based on ACPI description" + depends on ACPI && (MTD_CFI || MTD_JEDECPROBE || MTD_ROM) + help + This provides a 'mapping' driver which allows the NOR Flash and + ROM driver code to communicate with chips which are mapped + physically into the CPU's memory. The mapping description here is + taken from DSDT ACPI table. + config MTD_PMC_MSP_EVM tristate "CFI Flash device mapped on PMC-Sierra MSP" depends on PMC_MSP && MTD_CFI diff --git a/drivers/mtd/maps/Makefile b/drivers/mtd/maps/Makefile index 141c91a..379cfff 100644 --- a/drivers/mtd/maps/Makefile +++ b/drivers/mtd/maps/Makefile @@ -18,6 +18,7 @@ obj-$(CONFIG_MTD_TSUNAMI) += tsunami_flash.o obj-$(CONFIG_MTD_PXA2XX) += pxa2xx-flash.o obj-$(CONFIG_MTD_PHYSMAP) += physmap.o obj-$(CONFIG_MTD_PHYSMAP_OF) += physmap_of.o +obj-$(CONFIG_MTD_PHYSMAP_ACPI) += physmap_acpi.o obj-$(CONFIG_MTD_PISMO) += pismo.o obj-$(CONFIG_MTD_PMC_MSP_EVM) += pmcmsp-flash.o obj-$(CONFIG_MTD_PCMCIA) += pcmciamtd.o diff --git a/drivers/mtd/maps/physmap_acpi.c b/drivers/mtd/maps/physmap_acpi.c new file mode 100644 index 0000000..0973e00 --- /dev/null +++ b/drivers/mtd/maps/physmap_acpi.c @@ -0,0 +1,437 @@ +/* + * Flash mappings described by the ACPI + * + * Copyright (C) 2006 MontaVista Software Inc. + * Author: Vitaly Wool <vwool(a)ru.mvista.com> + * Copyright (C) 2007 David Gibson, IBM Corporation. + * + * Revised to handle ACPI style flash binding by: + * Copyright (C) 2013 Tomasz Nowicki <tomasz.nowicki(a)linaro.org> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ + +#include <linux/module.h> +#include <linux/types.h> +#include <linux/init.h> +#include <linux/device.h> +#include <linux/mtd/mtd.h> +#include <linux/mtd/map.h> +#include <linux/mtd/partitions.h> +#include <linux/mtd/concat.h> +#include <linux/acpi.h> +#include <linux/slab.h> +#include <linux/platform_device.h> + +struct acpi_flash_list { + struct mtd_info *mtd; + struct map_info map; + struct resource *res; +}; + +struct acpi_flash { + struct mtd_info *cmtd; + int list_size; /* number of elements in acpi_flash_list */ + struct acpi_flash_list list[0]; +}; + +/* UUID: ce511ba0-52bf-11e3-8f96-0800200c9a66 (randomly generated) */ +static const char device_label_dsm_uuid[] = { + 0xA0, 0x1B, 0x51, 0xCE, + 0xBF, 0x52, + 0xE3, 0x11, + 0x8F, 0x96, + 0x08, 0x00, 0x20, 0xC, 0x9A, 0x66 +}; + +static inline void acpi_flash_assign_params(union acpi_object params[4]) +{ + params[0].type = ACPI_TYPE_BUFFER; /* UUID */ + params[0].buffer.length = sizeof(device_label_dsm_uuid); + params[0].buffer.pointer = (char *)device_label_dsm_uuid; + params[1].type = ACPI_TYPE_INTEGER; /* Revision */ + params[1].integer.value = 1; + params[2].type = ACPI_TYPE_INTEGER; /* Function # */ + params[2].integer.value = 1; + params[3].type = ACPI_TYPE_PACKAGE; /* Arguments */ + params[3].package.count = 0; + params[3].package.elements = NULL; +} + +static int acpi_flash_call_dsm(acpi_handle handler, const char *key, + const void *value, + acpi_object_type return_type) +{ + union acpi_object *obj, *element; + struct acpi_object_list input; + union acpi_object params[4]; + acpi_status status; + char **char_ptr; + char *string; + u64 *int_ptr; + int len, i; + struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; + + input.count = 4; + acpi_flash_assign_params(params); + input.pointer = params; + status = acpi_evaluate_object_typed(handler, "_DSM", &input, &output, + ACPI_TYPE_PACKAGE); + if (ACPI_FAILURE(status)) { + pr_err("Failed to get _DSM package for this device\n"); + return -ENXIO; + } + + obj = (union acpi_object *)output.pointer; + + /* Parse 2 objects per entry */ + for (i = 0; i < obj->package.count; i += 2) { + element = &obj->package.elements[i]; + + /* Key must be a string */ + len = element->string.length; + if ((element->type != ACPI_TYPE_STRING) || + (element->string.length <= 0)) + continue; + + /* Check to see if this is requested key */ + if (strncmp(key, element->string.pointer, + len) != 0) + continue; + + /* If value type is correct, this is the one */ + element++; + if (element->type != return_type) + continue; + + switch (return_type) { + case (ACPI_TYPE_INTEGER): + int_ptr = (u64 *)value; + *int_ptr = element->integer.value; + goto found; + case (ACPI_TYPE_STRING): + len = element->string.length; + if (len <= 0) + continue; + + string = kmalloc(len + 1, GFP_KERNEL); + strncpy(string, element->string.pointer, len); + string[len] = '\0'; + + char_ptr = (char **)value; + *char_ptr = string; + goto found; + } + } + status = -ENXIO; + +found: + kfree(output.pointer); + return status; +} + +static const char * const rom_probe_types[] = { + "cfi_probe", "jedec_probe", "map_rom" }; + +/* Helper function to handle probing of the obsolete "direct-mapped" + * compatible binding, which has an extra "probe-type" property + * describing the type of flash probe necessary. */ +static struct mtd_info *obsolete_probe(struct platform_device *dev, + struct map_info *map) +{ + acpi_handle handler; + const char *acpi_probe; + struct mtd_info *mtd; + int i, err; + + handler = ACPI_HANDLE(&dev->dev); + dev_warn(&dev->dev, "ACPI uses obsolete \"direct-mapped\" flash " + "binding\n"); + + err = acpi_flash_call_dsm(handler, "probe-type", &acpi_probe, + ACPI_TYPE_STRING); + if (err || acpi_probe == NULL) { + for (i = 0; i < ARRAY_SIZE(rom_probe_types); i++) { + mtd = do_map_probe(rom_probe_types[i], map); + if (mtd) + return mtd; + } + return NULL; + } else if (strcmp(acpi_probe, "CFI") == 0) { + return do_map_probe("cfi_probe", map); + } else if (strcmp(acpi_probe, "JEDEC") == 0) { + return do_map_probe("jedec_probe", map); + } else { + if (strcmp(acpi_probe, "ROM") != 0) + dev_warn(&dev->dev, "obsolete_probe: don't know probe " + "type '%s', mapping as rom\n", acpi_probe); + return do_map_probe("mtd_rom", map); + } +} + +/* When partitions are set we look for a linux,part-probe property which + specifies the list of partition probers to use. If none is given then the + default is use. These take precedence over other device tree + information. */ +static const char * const part_probe_types_def[] = { + "cmdlinepart", "RedBoot", NULL }; + +static const char * const *acpi_get_part_probes(acpi_handle handler) +{ + char *cp = NULL; + unsigned int count = 0, i; + const char **res; + int cplen, err; + + /* Get space separated strings */ + err = acpi_flash_call_dsm(handler, "linux,part-probe", &cp, + ACPI_TYPE_STRING); + if (err || cp == NULL) + return part_probe_types_def; + + cplen = strlen(cp); + for (i = 0; i != cplen; i++) + if (cp[i] == ' ') + count++; + + /* Create the table with references to strings */ + res = kzalloc((count + 1) * sizeof(char *), GFP_KERNEL); + for (i = 0; i < count + 1; i++) { + res[i] = cp; + cp = strnchr(cp, cplen, ' '); + if (cp == NULL) + break; + + *cp++ = '\0'; + cplen = strlen(cp); + } + return res; +} + +static void acpi_free_probes(const char * const *probes) +{ + if (probes != part_probe_types_def) + kfree(probes); +} + +static const struct acpi_device_id acpi_flash_match[]; +static int acpi_flash_remove(struct platform_device *dev); + +static int acpi_flash_probe(struct platform_device *dev) +{ + const char * const *part_probe_types; + const struct acpi_device_id *id; + resource_size_t res_size; + struct acpi_flash *info; + const char *probe_type; + struct resource *res; + acpi_handle handler; + int err, i; + const u64 bank_width = 0, map_indirect = 0; + struct mtd_info **mtd_list = NULL; + const char *mtd_name = NULL; + int count = 0; + + handler = ACPI_HANDLE(&dev->dev); + + id = acpi_match_device(acpi_flash_match, &dev->dev); + if (!id) + return -ENODEV; + + probe_type = (const char *)id->driver_data; + + acpi_flash_call_dsm(handler, "linux,mtd-name", &mtd_name, + ACPI_TYPE_STRING); + acpi_flash_call_dsm(handler, "no-unaligned-direct-access", + &map_indirect, ACPI_TYPE_INTEGER); + + while (platform_get_resource(dev, IORESOURCE_MEM, count)) + count++; + + if (!count) { + dev_err(&dev->dev, "No resources found for %s device\n", + dev_name(&dev->dev)); + err = -ENXIO; + goto err_flash_remove; + } + + info = devm_kzalloc(&dev->dev, + sizeof(struct acpi_flash) + + sizeof(struct acpi_flash_list) * count, GFP_KERNEL); + if (!info) { + err = -ENOMEM; + goto err_flash_remove; + } + + dev_set_drvdata(&dev->dev, info); + + mtd_list = kzalloc(sizeof(*mtd_list) * count, GFP_KERNEL); + if (!mtd_list) + goto err_flash_remove; + + for (i = 0; i < count; i++) { + res = platform_get_resource(dev, IORESOURCE_MEM, i); + dev_dbg(&dev->dev, "resource[%d]: address 0x%lx size 0x%lx\n", + i, (long)res->start, (long)resource_size(res)); + + res_size = resource_size(res); + info->list[i].res = request_mem_region(res->start, res_size, + dev_name(&dev->dev)); + if (!info->list[i].res) { + err = -EBUSY; + goto err_out; + } + + /* Mandatory property */ + err = acpi_flash_call_dsm(handler, "bank-width", &bank_width, + ACPI_TYPE_INTEGER); + if (err || !bank_width) { + dev_err(&dev->dev, "Can't get bank width from DSDT\n"); + goto err_out; + } + + info->list[i].map.name = mtd_name ?: dev_name(&dev->dev); + info->list[i].map.phys = res->start; + info->list[i].map.size = res_size; + info->list[i].map.bankwidth = bank_width; + info->list[i].map.virt = ioremap(info->list[i].map.phys, + info->list[i].map.size); + if (!info->list[i].map.virt) { + dev_err(&dev->dev, "Failed to ioremap() flash region\n"); + err = -ENOMEM; + goto err_out; + } + + simple_map_init(&info->list[i].map); + + /* + * On some platforms (e.g. MPC5200) a direct 1:1 mapping + * may cause problems with JFFS2 usage, as the local bus (LPB) + * doesn't support unaligned accesses as implemented in the + * JFFS2 code via memcpy(). By setting NO_XIP, the + * flash will not be exposed directly to the MTD users + * (e.g. JFFS2) any more. + */ + if (map_indirect) + info->list[i].map.phys = NO_XIP; + + if (probe_type) { + info->list[i].mtd = do_map_probe(probe_type, + &info->list[i].map); + } else { + info->list[i].mtd = obsolete_probe(dev, + &info->list[i].map); + } + + if (!info->list[i].mtd) { + dev_err(&dev->dev, "do_map_probe() failed\n"); + err = -ENXIO; + goto err_out; + } else + info->list_size++; + + info->list[i].mtd->owner = THIS_MODULE; + info->list[i].mtd->dev.parent = &dev->dev; + mtd_list[i] = info->list[i].mtd; + } + + info->cmtd = NULL; + if (info->list_size == 1) { + info->cmtd = info->list[0].mtd; + } else if (info->list_size > 1) { + /* + * We detected multiple devices. Concatenate them together. + */ + info->cmtd = mtd_concat_create(mtd_list, info->list_size, + dev_name(&dev->dev)); + } + if (info->cmtd == NULL) { + err = -ENXIO; + goto err_out; + } + + part_probe_types = acpi_get_part_probes(handler); + mtd_device_parse_register(info->cmtd, part_probe_types, NULL, + NULL, 0); + acpi_free_probes(part_probe_types); + + kfree(mtd_list); + + return 0; + +err_out: + kfree(mtd_list); +err_flash_remove: + acpi_flash_remove(dev); + + return err; +} + +static int acpi_flash_remove(struct platform_device *dev) +{ + struct acpi_flash *info; + int i; + + info = dev_get_drvdata(&dev->dev); + if (!info) + return 0; + dev_set_drvdata(&dev->dev, NULL); + + if (info->cmtd != info->list[0].mtd) { + mtd_device_unregister(info->cmtd); + mtd_concat_destroy(info->cmtd); + } + + if (info->cmtd) + mtd_device_unregister(info->cmtd); + + for (i = 0; i < info->list_size; i++) { + if (info->list[i].mtd) + map_destroy(info->list[i].mtd); + + if (info->list[i].map.virt) + iounmap(info->list[i].map.virt); + + if (info->list[i].res) { + release_resource(info->list[i].res); + kfree(info->list[i].res); + } + } + + return 0; +} + +static const struct acpi_device_id acpi_flash_match[] = { + { "LNRO000B", (unsigned long)"cfi_probe"}, + { "LNRO000C", (unsigned long)"jedec_probe"}, + { "LNRO000D", (unsigned long)"map_ram"}, + { "LNRO000E", (unsigned long)"direct-mapped"}, + {}, +}; +MODULE_DEVICE_TABLE(acpi, acpi_flash_match); + +static struct platform_driver acpi_flash_driver = { + .driver = { + .name = "acpi-flash", + .owner = THIS_MODULE, + .acpi_match_table = ACPI_PTR(acpi_flash_match), + }, + .probe = acpi_flash_probe, + .remove = acpi_flash_remove, +}; + +module_platform_driver(acpi_flash_driver); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Tomasz Nowicki <tomasz.nowicki(a)linaro.org>"); +MODULE_DESCRIPTION("ACPI based MTD map driver"); -- 1.7.9.5

10 years, 4 months

[PATCH v2 0/6] Hardware Reduced Mode cleanup for ACPI

by al.stone＠linaro.org

From: Al Stone <al.stone(a)linaro.org> This series of patches starts with Hanjun's patch to create a kernel config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I then reviewed all of the code that touched any of several fields in the FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced mode [1]. Any time there was a use of one of the fields to be ignored, I evaluated whether or not the code was implementing Hardware Reduced mode correctly. Similarly, for each the flags in the FADT flags field that are to be ignored in Hardware Reduced mode, the kernel code was again scanned for proper usage. The remainder of the patches are to fix all of the situations I could find where the kernel would not behave correctly in this ACPI mode. These seem to work just fine on the RTSM model for ARMv7, both with and without ACPI enabled, and with and without ACPI_REDUCED_HARDWARE enabled; similarly for the FVP model for ARMv8. The patches for ACPI on ARM hardware will be coming later but they presume that reduced HW mode is functioning correctly. In the meantime, there's no way I can think of to test all possible scenarios so feedback would be greatly appreciated. [0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5… [1] Please see the ACPI Specification v5.0 for details on Hardware Reduced mode. Changes for v2: -- Remove patch that was outside of reduced HW mode changes -- Simplify CONFIG_ACPI_REDUCED_HARDWARE in Kconfig -- Simplify use of CONFIG_ACPI_REDUCED_HARDWARE in #ifdefs -- Ensure changelogs are present -- Combine and simplify previous patches 8 & 10 Al Stone (6): ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode ACPI: bus master reload not supported in reduced HW mode ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field ACPI: ARM: exclude DMI calls ACPI: do not reserve memory regions for some FADT entries in HW reduced mode ACPI: in HW reduced mode, using FADT PM information is not allowed. drivers/acpi/Kconfig | 8 ++++++++ drivers/acpi/bus.c | 3 ++- drivers/acpi/osl.c | 24 ++++++++++++------------ drivers/acpi/pci_link.c | 2 ++ drivers/acpi/processor_idle.c | 16 ++++++++++++++-- include/acpi/platform/aclinux.h | 4 ++++ include/linux/dmi.h | 2 +- 7 files changed, 43 insertions(+), 16 deletions(-) -- 1.8.3.1

10 years, 4 months

[RFC part2 PATCH 0/9] Using ACPI MADT table to initialise SMP and GIC

by Hanjun Guo

This patch set is based on part1 "Make ACPI core running on ARM64" patch set. After we can get the ACPI tables from UEFI, we can use these tables to initialise the system now. GIC (means GIC cpu interface) structure and GIC distributor structure in MADT table contains the information of GIC cpu interface base address and GIC distributor base address, which can be used to initialise GIC. Further more, parked address in GIC structure can be used as cpu release address for spin table SMP initialisation. This patch set use these information to init SMP and GIC. Please refer to chapter 5.2.12.14/15 of ACPI 5.0 spec for GIC and GIC distributor structure information. Amit Daniel Kachhap (1): irqdomain: Add a new API irq_create_acpi_mapping() Hanjun Guo (8): ARM64 / ACPI: Implement core functions for parsing MADT table ARM64 / ACPI: Prefill cpu possible/present maps and map logical cpu id to APIC id ARM64 / ACPI: Introduce map_gic_id() to get apic id from MADT or _MAT method ARM64 / ACPI: Use Parked Address in GIC structure for spin table SMP initialisation ACPI: Define ACPI_IRQ_MODEL_GIC needed for arm Irqchip / gic: Set as default domain so we can access from ACPI ACPI / ARM64: Update acpi_register_gsi to register with the core IRQ subsystem ACPI / GIC: Initialize GIC using the information in MADT arch/arm64/include/asm/acpi.h | 16 +- arch/arm64/kernel/irq.c | 5 + arch/arm64/kernel/setup.c | 2 + arch/arm64/kernel/smp.c | 2 + arch/arm64/kernel/smp_spin_table.c | 16 +- drivers/acpi/bus.c | 3 + drivers/acpi/plat/arm-core.c | 397 +++++++++++++++++++++++++++++++++++- drivers/acpi/processor_core.c | 26 +++ drivers/acpi/tables.c | 21 ++ drivers/irqchip/irq-gic.c | 7 + include/linux/acpi.h | 9 + kernel/irq/irqdomain.c | 27 +++ 12 files changed, 521 insertions(+), 10 deletions(-) -- 1.7.9.5

10 years, 4 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi December 2013