linaro-kernel October 2013

linaro-kernel@lists.linaro.org

87 participants
222 discussions

arm-soc boot: 32 pass, 1 fail (v3.12-rc4-563-g55b5fc1)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: arm-soc Git describe: v3.12-rc4-563-g55b5fc1 Failed boot tests (console logs at the end) =========================================== am335x-boneblack: FAIL: multi_v7_defconfig Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 28.0 sec omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.7 sec omap3-tobi,3530overo PASS: 0 min 21.5 sec omap4-panda PASS: 1 min 12.5 sec omap4-panda-es PASS: 1 min 28.9 sec omap3-tobi,3730storm PASS: 0 min 23.2 sec omap3-beagle PASS: 0 min 51.3 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 22.7 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.0 sec imx6q-wandboard PASS: 0 min 14.7 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.8 sec armada-370-mirabox PASS: 0 min 20.0 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.8 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.1 sec tegra30-beaver PASS: 0 min 17.1 sec am335x-boneblack FAIL: 0 min 41.2 sec omap3-beagle-xm PASS: 0 min 50.4 sec armada-370-mirabox PASS: 0 min 20.5 sec omap4-panda PASS: 1 min 4.3 sec omap4-panda-es PASS: 1 min 4.5 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.6 sec sun4i-a10-cubieboard PASS: 0 min 13.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.4 sec omap3-tobi,3530overo PASS: 0 min 19.8 sec am335x-bone PASS: 0 min 33.6 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 22.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.6 sec omap3-beagle PASS: 0 min 55.3 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 28.3 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec Console logs for failures ========================= multi_v7_defconfig ------------------ am335x-boneblack: FAIL: last 24 lines of boot log: -------------------------------------------------- U-Boot# dhcp dhcp link up on port 0, speed 1000, full duplex BOOTP broadcast 1 BOOTP broadcast 2 BOOTP broadcast 3 BOOTP broadcast 4 BOOTP broadcast 5 BOOTP broadcast 6 BOOTP broadcast 7 BOOTP broadcast 8 BOOTP broadcast 9 BOOTP broadcast 10 dhcp Retry count exceeded; starting again using musb-hdrc, OUT ep1out IN ep1in STATUS ep2in MAC c8:a0:30:b4:18:a4 HOST MAC de:ad:be:af:00:00 RNDIS ready ~$off # PYBOOT: Exception: u-boot: ERROR: DHCP retry count exceeded. # PYBOOT: Time: 41.22 seconds. # PYBOOT: Result: FAIL

11 years, 4 months

[PATCH 1/2] ASoC: dai: Provide interface for setting DMA data at probe time

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> Allow DMA data to be set at probe time for devices that can do that, avoiding the need to do it every time we start a stream and supporting non-DT dmaengine users using the helpers. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- include/sound/soc-dai.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/sound/soc-dai.h b/include/sound/soc-dai.h index 1ce3685..800c101 100644 --- a/include/sound/soc-dai.h +++ b/include/sound/soc-dai.h @@ -286,6 +286,13 @@ static inline void snd_soc_dai_set_dma_data(struct snd_soc_dai *dai, dai->capture_dma_data = data; } +static inline void snd_soc_dai_init_dma_data(struct snd_soc_dai *dai, + void *playback, void *capture) +{ + dai->playback_dma_data = playback; + dai->capture_dma_data = capture; +} + static inline void snd_soc_dai_set_drvdata(struct snd_soc_dai *dai, void *data) { -- 1.8.4.rc3

11 years, 4 months

mainline boot: 33 pass, 0 fail (v3.12-rc5-117-g83f11a9)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.12-rc5-117-g83f11a9 Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 30.1 sec omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.1 sec omap3-tobi,3530overo PASS: 0 min 21.1 sec omap4-panda PASS: 1 min 6.5 sec omap4-panda-es PASS: 1 min 4.7 sec omap3-tobi,3730storm PASS: 0 min 20.3 sec omap3-beagle PASS: 0 min 51.8 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 22.8 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.2 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.0 sec imx6q-wandboard PASS: 0 min 14.7 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 20.0 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.8 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.3 sec tegra30-beaver PASS: 0 min 17.4 sec am335x-boneblack PASS: 0 min 34.4 sec omap3-beagle-xm PASS: 0 min 50.2 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 12.0 sec omap4-panda-es PASS: 1 min 3.9 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.7 sec sun4i-a10-cubieboard PASS: 0 min 13.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.3 sec omap3-tobi,3530overo PASS: 0 min 19.8 sec am335x-bone PASS: 0 min 33.3 sec imx6q-wandboard PASS: 0 min 15.8 sec omap3-tobi,3730storm PASS: 0 min 22.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.6 sec omap3-beagle PASS: 0 min 50.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 36.8 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.4 sec

11 years, 4 months

mainline boot: 33 pass, 0 fail (v3.12-rc5-85-g630db0e)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.12-rc5-85-g630db0e Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 29.8 sec omap3-beagle-xm PASS: 0 min 51.8 sec am335x-bone PASS: 0 min 26.1 sec omap3-tobi,3530overo PASS: 0 min 24.2 sec omap4-panda PASS: 1 min 4.5 sec omap4-panda-es PASS: 1 min 5.7 sec omap3-tobi,3730storm PASS: 0 min 23.2 sec omap3-beagle PASS: 0 min 51.4 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 16.9 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.0 sec imx6q-wandboard PASS: 0 min 14.7 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.0 sec armada-370-mirabox PASS: 0 min 19.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.8 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 28.8 sec tegra30-beaver PASS: 0 min 17.1 sec am335x-boneblack PASS: 0 min 34.4 sec omap3-beagle-xm PASS: 0 min 51.7 sec armada-370-mirabox PASS: 0 min 20.5 sec omap4-panda PASS: 1 min 1.6 sec omap4-panda-es PASS: 1 min 2.4 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.9 sec sun4i-a10-cubieboard PASS: 0 min 13.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.3 sec omap3-tobi,3530overo PASS: 0 min 19.9 sec am335x-bone PASS: 0 min 33.2 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 22.4 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.8 sec omap3-beagle PASS: 0 min 49.6 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 34.0 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec

11 years, 4 months

[PATCH] ASoC: wm8962: Move register initialisation to I2C probe()

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> This is more idiomatic and is required for robust operation since we must ensure that the clocking configuration is valid as rapidly as possible. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/codecs/wm8962.c | 150 +++++++++++++++++++++++----------------------- 1 file changed, 75 insertions(+), 75 deletions(-) diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 54379ee..2bf9ee7 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -3242,7 +3242,7 @@ static void wm8962_free_beep(struct snd_soc_codec *codec) } #endif -static void wm8962_set_gpio_mode(struct snd_soc_codec *codec, int gpio) +static void wm8962_set_gpio_mode(struct wm8962_priv *wm8962, int gpio) { int mask = 0; int val = 0; @@ -3263,8 +3263,8 @@ static void wm8962_set_gpio_mode(struct snd_soc_codec *codec, int gpio) } if (mask) - snd_soc_update_bits(codec, WM8962_ANALOGUE_CLOCKING1, - mask, val); + regmap_update_bits(wm8962->regmap, WM8962_ANALOGUE_CLOCKING1, + mask, val); } #ifdef CONFIG_GPIOLIB @@ -3276,7 +3276,6 @@ static inline struct wm8962_priv *gpio_to_wm8962(struct gpio_chip *chip) static int wm8962_gpio_request(struct gpio_chip *chip, unsigned offset) { struct wm8962_priv *wm8962 = gpio_to_wm8962(chip); - struct snd_soc_codec *codec = wm8962->codec; /* The WM8962 GPIOs aren't linearly numbered. For simplicity * we export linear numbers and error out if the unsupported @@ -3292,7 +3291,7 @@ static int wm8962_gpio_request(struct gpio_chip *chip, unsigned offset) return -EINVAL; } - wm8962_set_gpio_mode(codec, offset + 1); + wm8962_set_gpio_mode(wm8962, offset + 1); return 0; } @@ -3376,7 +3375,6 @@ static int wm8962_probe(struct snd_soc_codec *codec) { int ret; struct wm8962_priv *wm8962 = snd_soc_codec_get_drvdata(codec); - struct wm8962_pdata *pdata = &wm8962->pdata; int i; bool dmicclk, dmicdat; @@ -3409,75 +3407,6 @@ static int wm8962_probe(struct snd_soc_codec *codec) } } - /* SYSCLK defaults to on; make sure it is off so we can safely - * write to registers if the device is declocked. - */ - snd_soc_update_bits(codec, WM8962_CLOCKING2, WM8962_SYSCLK_ENA, 0); - - /* Ensure we have soft control over all registers */ - snd_soc_update_bits(codec, WM8962_CLOCKING2, - WM8962_CLKREG_OVD, WM8962_CLKREG_OVD); - - /* Ensure that the oscillator and PLLs are disabled */ - snd_soc_update_bits(codec, WM8962_PLL2, - WM8962_OSC_ENA | WM8962_PLL2_ENA | WM8962_PLL3_ENA, - 0); - - /* Apply static configuration for GPIOs */ - for (i = 0; i < ARRAY_SIZE(pdata->gpio_init); i++) - if (pdata->gpio_init[i]) { - wm8962_set_gpio_mode(codec, i + 1); - snd_soc_write(codec, 0x200 + i, - pdata->gpio_init[i] & 0xffff); - } - - - /* Put the speakers into mono mode? */ - if (pdata->spk_mono) - snd_soc_update_bits(codec, WM8962_CLASS_D_CONTROL_2, - WM8962_SPK_MONO_MASK, WM8962_SPK_MONO); - - /* Micbias setup, detection enable and detection - * threasholds. */ - if (pdata->mic_cfg) - snd_soc_update_bits(codec, WM8962_ADDITIONAL_CONTROL_4, - WM8962_MICDET_ENA | - WM8962_MICDET_THR_MASK | - WM8962_MICSHORT_THR_MASK | - WM8962_MICBIAS_LVL, - pdata->mic_cfg); - - /* Latch volume update bits */ - snd_soc_update_bits(codec, WM8962_LEFT_INPUT_VOLUME, - WM8962_IN_VU, WM8962_IN_VU); - snd_soc_update_bits(codec, WM8962_RIGHT_INPUT_VOLUME, - WM8962_IN_VU, WM8962_IN_VU); - snd_soc_update_bits(codec, WM8962_LEFT_ADC_VOLUME, - WM8962_ADC_VU, WM8962_ADC_VU); - snd_soc_update_bits(codec, WM8962_RIGHT_ADC_VOLUME, - WM8962_ADC_VU, WM8962_ADC_VU); - snd_soc_update_bits(codec, WM8962_LEFT_DAC_VOLUME, - WM8962_DAC_VU, WM8962_DAC_VU); - snd_soc_update_bits(codec, WM8962_RIGHT_DAC_VOLUME, - WM8962_DAC_VU, WM8962_DAC_VU); - snd_soc_update_bits(codec, WM8962_SPKOUTL_VOLUME, - WM8962_SPKOUT_VU, WM8962_SPKOUT_VU); - snd_soc_update_bits(codec, WM8962_SPKOUTR_VOLUME, - WM8962_SPKOUT_VU, WM8962_SPKOUT_VU); - snd_soc_update_bits(codec, WM8962_HPOUTL_VOLUME, - WM8962_HPOUT_VU, WM8962_HPOUT_VU); - snd_soc_update_bits(codec, WM8962_HPOUTR_VOLUME, - WM8962_HPOUT_VU, WM8962_HPOUT_VU); - - /* Stereo control for EQ */ - snd_soc_update_bits(codec, WM8962_EQ1, WM8962_EQ_SHARED_COEFF, 0); - - /* Don't debouce interrupts so we don't need SYSCLK */ - snd_soc_update_bits(codec, WM8962_IRQ_DEBOUNCE, - WM8962_FLL_LOCK_DB | WM8962_PLL3_LOCK_DB | - WM8962_PLL2_LOCK_DB | WM8962_TEMP_SHUT_DB, - 0); - wm8962_add_widgets(codec); /* Save boards having to disable DMIC when not in use */ @@ -3671,6 +3600,77 @@ static int wm8962_i2c_probe(struct i2c_client *i2c, goto err_enable; } + /* SYSCLK defaults to on; make sure it is off so we can safely + * write to registers if the device is declocked. + */ + regmap_update_bits(wm8962->regmap, WM8962_CLOCKING2, + WM8962_SYSCLK_ENA, 0); + + /* Ensure we have soft control over all registers */ + regmap_update_bits(wm8962->regmap, WM8962_CLOCKING2, + WM8962_CLKREG_OVD, WM8962_CLKREG_OVD); + + /* Ensure that the oscillator and PLLs are disabled */ + regmap_update_bits(wm8962->regmap, WM8962_PLL2, + WM8962_OSC_ENA | WM8962_PLL2_ENA | WM8962_PLL3_ENA, + 0); + + /* Apply static configuration for GPIOs */ + for (i = 0; i < ARRAY_SIZE(pdata->gpio_init); i++) + if (pdata->gpio_init[i]) { + wm8962_set_gpio_mode(wm8962, i + 1); + regmap_write(wm8962->regmap, 0x200 + i, + pdata->gpio_init[i] & 0xffff); + } + + + /* Put the speakers into mono mode? */ + if (pdata->spk_mono) + regmap_update_bits(wm8962->regmap, WM8962_CLASS_D_CONTROL_2, + WM8962_SPK_MONO_MASK, WM8962_SPK_MONO); + + /* Micbias setup, detection enable and detection + * threasholds. */ + if (pdata->mic_cfg) + regmap_update_bits(wm8962->regmap, WM8962_ADDITIONAL_CONTROL_4, + WM8962_MICDET_ENA | + WM8962_MICDET_THR_MASK | + WM8962_MICSHORT_THR_MASK | + WM8962_MICBIAS_LVL, + pdata->mic_cfg); + + /* Latch volume update bits */ + regmap_update_bits(wm8962->regmap, WM8962_LEFT_INPUT_VOLUME, + WM8962_IN_VU, WM8962_IN_VU); + regmap_update_bits(wm8962->regmap, WM8962_RIGHT_INPUT_VOLUME, + WM8962_IN_VU, WM8962_IN_VU); + regmap_update_bits(wm8962->regmap, WM8962_LEFT_ADC_VOLUME, + WM8962_ADC_VU, WM8962_ADC_VU); + regmap_update_bits(wm8962->regmap, WM8962_RIGHT_ADC_VOLUME, + WM8962_ADC_VU, WM8962_ADC_VU); + regmap_update_bits(wm8962->regmap, WM8962_LEFT_DAC_VOLUME, + WM8962_DAC_VU, WM8962_DAC_VU); + regmap_update_bits(wm8962->regmap, WM8962_RIGHT_DAC_VOLUME, + WM8962_DAC_VU, WM8962_DAC_VU); + regmap_update_bits(wm8962->regmap, WM8962_SPKOUTL_VOLUME, + WM8962_SPKOUT_VU, WM8962_SPKOUT_VU); + regmap_update_bits(wm8962->regmap, WM8962_SPKOUTR_VOLUME, + WM8962_SPKOUT_VU, WM8962_SPKOUT_VU); + regmap_update_bits(wm8962->regmap, WM8962_HPOUTL_VOLUME, + WM8962_HPOUT_VU, WM8962_HPOUT_VU); + regmap_update_bits(wm8962->regmap, WM8962_HPOUTR_VOLUME, + WM8962_HPOUT_VU, WM8962_HPOUT_VU); + + /* Stereo control for EQ */ + regmap_update_bits(wm8962->regmap, WM8962_EQ1, + WM8962_EQ_SHARED_COEFF, 0); + + /* Don't debouce interrupts so we don't need SYSCLK */ + regmap_update_bits(wm8962->regmap, WM8962_IRQ_DEBOUNCE, + WM8962_FLL_LOCK_DB | WM8962_PLL3_LOCK_DB | + WM8962_PLL2_LOCK_DB | WM8962_TEMP_SHUT_DB, + 0); + if (wm8962->pdata.in4_dc_measure) { ret = regmap_register_patch(wm8962->regmap, wm8962_dc_measure, -- 1.8.4.rc3

11 years, 4 months

[PATCH] ASoC: wm8962: Move interrupt initalisation to probe()

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> This is more idiomatic and fixes bugs in the error handling paths. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/codecs/wm8962.c | 68 +++++++++++++++++++++++------------------------ 1 file changed, 33 insertions(+), 35 deletions(-) diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 11d80f3..54379ee 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c @@ -3377,7 +3377,7 @@ static int wm8962_probe(struct snd_soc_codec *codec) int ret; struct wm8962_priv *wm8962 = snd_soc_codec_get_drvdata(codec); struct wm8962_pdata *pdata = &wm8962->pdata; - int i, trigger, irq_pol; + int i; bool dmicclk, dmicdat; wm8962->codec = codec; @@ -3506,36 +3506,6 @@ static int wm8962_probe(struct snd_soc_codec *codec) wm8962_init_beep(codec); wm8962_init_gpio(codec); - if (wm8962->irq) { - if (pdata->irq_active_low) { - trigger = IRQF_TRIGGER_LOW; - irq_pol = WM8962_IRQ_POL; - } else { - trigger = IRQF_TRIGGER_HIGH; - irq_pol = 0; - } - - snd_soc_update_bits(codec, WM8962_INTERRUPT_CONTROL, - WM8962_IRQ_POL, irq_pol); - - ret = request_threaded_irq(wm8962->irq, NULL, wm8962_irq, - trigger | IRQF_ONESHOT, - "wm8962", codec->dev); - if (ret != 0) { - dev_err(codec->dev, "Failed to request IRQ %d: %d\n", - wm8962->irq, ret); - wm8962->irq = 0; - /* Non-fatal */ - } else { - /* Enable some IRQs by default */ - snd_soc_update_bits(codec, - WM8962_INTERRUPT_STATUS_2_MASK, - WM8962_FLL_LOCK_EINT | - WM8962_TEMP_SHUT_EINT | - WM8962_FIFOS_ERR_EINT, 0); - } - } - return 0; } @@ -3544,9 +3514,6 @@ static int wm8962_remove(struct snd_soc_codec *codec) struct wm8962_priv *wm8962 = snd_soc_codec_get_drvdata(codec); int i; - if (wm8962->irq) - free_irq(wm8962->irq, codec); - cancel_delayed_work_sync(&wm8962->mic_work); wm8962_free_gpio(codec); @@ -3619,7 +3586,7 @@ static int wm8962_i2c_probe(struct i2c_client *i2c, struct wm8962_pdata *pdata = dev_get_platdata(&i2c->dev); struct wm8962_priv *wm8962; unsigned int reg; - int ret, i; + int ret, i, irq_pol, trigger; wm8962 = devm_kzalloc(&i2c->dev, sizeof(struct wm8962_priv), GFP_KERNEL); @@ -3714,6 +3681,37 @@ static int wm8962_i2c_probe(struct i2c_client *i2c, ret); } + if (wm8962->irq) { + if (pdata->irq_active_low) { + trigger = IRQF_TRIGGER_LOW; + irq_pol = WM8962_IRQ_POL; + } else { + trigger = IRQF_TRIGGER_HIGH; + irq_pol = 0; + } + + regmap_update_bits(wm8962->regmap, WM8962_INTERRUPT_CONTROL, + WM8962_IRQ_POL, irq_pol); + + ret = devm_request_threaded_irq(&i2c->dev, wm8962->irq, NULL, + wm8962_irq, + trigger | IRQF_ONESHOT, + "wm8962", &i2c->dev); + if (ret != 0) { + dev_err(&i2c->dev, "Failed to request IRQ %d: %d\n", + wm8962->irq, ret); + wm8962->irq = 0; + /* Non-fatal */ + } else { + /* Enable some IRQs by default */ + regmap_update_bits(wm8962->regmap, + WM8962_INTERRUPT_STATUS_2_MASK, + WM8962_FLL_LOCK_EINT | + WM8962_TEMP_SHUT_EINT | + WM8962_FIFOS_ERR_EINT, 0); + } + } + pm_runtime_enable(&i2c->dev); pm_request_idle(&i2c->dev); -- 1.8.4.rc3

11 years, 4 months

Re: .align may cause data to be interpreted as instructions

by Dave Martin

On Wed, Oct 16, 2013 at 10:17:14PM +0100, Måns Rullgård wrote: > Taras Kondratiuk <taras.kondratiuk(a)linaro.org> writes: > > > On 10/16/2013 10:25 PM, Dave Martin wrote: > >> Unfortunately, objdump can and does get confused about data/instruction > >> boundaries, so the output you see above may be misleading. > >> > >> Displaying the symbol table with --special-syms will list the magic > >> symbols that mark the instruction and data boundaries, to help debug > >> this kind of situation. > >> > >> > >> However, in this case, I think you've found a bug in the assembler, > >> as shown below. > >> > >> Before linking, the final $a symbol (indicating the start of ARM > >> instructions) is at address 8, so in this case objdump is correct > >> to show 0x12345678 as an instruction. > >> > >> After linking, the mapping symbols ($[atd]) remain as before, and > >> the linker has byteswapped this "instruction" (as it should). > >> > >> This is likely related to the magic for inserting the extensible > >> NOP-padding fragment which implements the .align in code sections. > >> That is code, and requires a $a mapping symbol, but that somehow > >> goes AWOL or gets displaced after the alignment padding ... > >> > >> I can't quite get my head around what is going on in > >> binutils/gas/config/tc-arm.c. We would need to understand that > >> before we can identify a reliable workaround. > > > > Thanks for confirming the issue. > > Does it makes sense to file a GCC bug? > > It seems like a binutils (gas) bug to me. It is indeed a gas bug (actually a few interrelated bugs). I've raised this with my local friendly binutils hackers, but I'll propagate it to the upstream bugzilla if it's slow to turn around a fix. In any case, we can't rely on this working for Linux for some time to come, because the fix would still need to make it into a binutils release, and then everyone would need to upgrade to that release. If we can work around it, we should just do that instead. Cheers ---Dave

11 years, 4 months

Re: [PATCH v2] ARM: cci driver need big endian fixes in asm code

by Dave Martin

On Tue, Oct 15, 2013 at 09:50:34PM -0700, Victor Kamensky wrote: > cci_enable_port_for_self written in asm and it works with h/w > registers that are in little endian format. When run in big > endian mode it needs byteswaped constants before/after it > writes/reads to/from such registers > > Signed-off-by: Victor Kamensky <victor.kamensky(a)linaro.org> > Signed-off-by: Ben Dooks <ben.dooks(a)codethink.co.uk> Acked-by: Dave Martin <Dave.Martin(a)arm.com> (With due thanks to linux/swab.h's compile-time constant swabbing skills, without which this wouldn't be possible...) > --- > drivers/bus/arm-cci.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c > index 57b0bc6..4328c25 100644 > --- a/drivers/bus/arm-cci.c > +++ b/drivers/bus/arm-cci.c > @@ -872,7 +872,7 @@ asmlinkage void __naked cci_enable_port_for_self(void) > > /* Enable the CCI port */ > " ldr r0, [r0, %[offsetof_port_phys]] \n" > -" mov r3, #"__stringify(CCI_ENABLE_REQ)" \n" > +" mov r3, %[cci_enable_req]\n" > " str r3, [r0, #"__stringify(CCI_PORT_CTRL)"] \n" > > /* poll the status reg for completion */ > @@ -880,7 +880,7 @@ asmlinkage void __naked cci_enable_port_for_self(void) > " ldr r0, [r1] \n" > " ldr r0, [r0, r1] @ cci_ctrl_base \n" > "4: ldr r1, [r0, #"__stringify(CCI_CTRL_STATUS)"] \n" > -" tst r1, #1 \n" > +" tst r1, %[cci_control_status_bits] \n" > " bne 4b \n" > > " mov r0, #0 \n" > @@ -893,6 +893,8 @@ asmlinkage void __naked cci_enable_port_for_self(void) > "7: .word cci_ctrl_phys - . \n" > : : > [sizeof_cpu_port] "i" (sizeof(cpu_port)), > + [cci_enable_req] "i" cpu_to_le32(CCI_ENABLE_REQ), > + [cci_control_status_bits] "i" cpu_to_le32(1), > #ifndef __ARMEB__ > [offsetof_cpu_port_mpidr_lsb] "i" (offsetof(struct cpu_port, mpidr)), > #else > -- > 1.8.1.4 > > > _______________________________________________ > linaro-kernel mailing list > linaro-kernel(a)lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-kernel

11 years, 4 months

mainline boot: 33 pass, 0 fail (v3.12-rc5-78-g056cdce)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.12-rc5-78-g056cdce Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 30.3 sec omap3-beagle-xm PASS: 0 min 52.4 sec am335x-bone PASS: 0 min 26.1 sec omap3-tobi,3530overo PASS: 0 min 21.1 sec omap4-panda PASS: 1 min 4.4 sec omap4-panda-es PASS: 1 min 5.9 sec omap3-tobi,3730storm PASS: 0 min 25.1 sec omap3-beagle PASS: 0 min 56.4 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 18.5 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.2 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.1 sec imx6q-wandboard PASS: 0 min 14.8 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.8 sec armada-370-mirabox PASS: 0 min 19.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.9 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.4 sec tegra30-beaver PASS: 0 min 14.1 sec am335x-boneblack PASS: 0 min 34.4 sec omap3-beagle-xm PASS: 0 min 50.6 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 1.4 sec omap4-panda-es PASS: 1 min 2.0 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.6 sec sun4i-a10-cubieboard PASS: 0 min 13.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.3 sec omap3-tobi,3530overo PASS: 0 min 19.5 sec am335x-bone PASS: 0 min 33.2 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 19.3 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.5 sec omap3-beagle PASS: 0 min 51.0 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 36.8 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec

11 years, 4 months

queue boot: 26 pass, 1 fail (v3.11.5-50-g1a2120b)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: queue Git describe: v3.11.5-50-g1a2120b Failed boot tests (console logs at the end) =========================================== omap3-beagle: FAIL: omap2plus_defconfig Full Report =========== omap2plus_defconfig ------------------- omap3-beagle-xm PASS: 0 min 49.3 sec am335x-bone PASS: 0 min 26.5 sec omap3-tobi,3530overo PASS: 0 min 21.7 sec omap4-panda PASS: 1 min 16.6 sec omap4-panda-es PASS: 1 min 3.9 sec omap3-tobi,3730storm PASS: 0 min 23.6 sec omap3-beagle FAIL: 1 min 46.5 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 18.6 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 15.9 sec imx6dl-wandboard,wand-solo PASS: 0 min 15.6 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.8 sec armada-370-mirabox PASS: 0 min 19.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.8 sec multi_v7_defconfig ------------------ tegra30-beaver PASS: 0 min 21.2 sec omap3-beagle-xm PASS: 0 min 49.3 sec armada-370-mirabox PASS: 0 min 20.5 sec omap4-panda PASS: 1 min 2.9 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.8 sec sun4i-a10-cubieboard PASS: 0 min 13.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.2 sec omap3-tobi,3530overo PASS: 0 min 19.9 sec am335x-bone PASS: 0 min 33.6 sec omap4-panda-es PASS: 1 min 2.3 sec omap3-tobi,3730storm PASS: 0 min 20.0 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.4 sec omap3-beagle PASS: 1 min 6.0 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec Console logs for failures ========================= omap2plus_defconfig ------------------- omap3-beagle: FAIL: last 24 lines of boot log: ---------------------------------------------- TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'tmp/3530beagle-8H_ZHt/zImage'. Load address: 0x80200000 Loading: *T ################################################################# ################################################################# ##############################T T T T Abort OMAP3 beagleboard.org # tftp 0x80200000 tmp/3530beagle-8H_ZHt/zImage tftp 0x80200000 tmp/3530beagle-8H_ZHt/zImage EHCI timed out on TD - token=0x80008c80 EHCI timed out on TD - token=0x80008d80 ERROR: Need valid 'usbnet_devaddr' to be set at ether.c:2369/usb_eth_init() OMAP3 beagleboard.org # tftp 0x80200000 tmp/3530beagle-8H_ZHt/zImage <INTERRUPT> OMAP3 beagleboard.org # tftp 0x80200000 tmp/3530beagle-8H_ZHt/zImage EHCI timed out on TD - token=0x80008c80 EHCI timed out on TD - token=0x80008d80 ERROR: Need valid 'usbnet_devaddr' to be set at ether.c:2369/usb_eth_init() OMAP3 beagleboard.org # ~$off # PYBOOT: Exception: ERROR: Timeout loading tmp/3530beagle-8H_ZHt/zImage. Giving up. # PYBOOT: Time: 106.54 seconds. # PYBOOT: Result: FAIL

11 years, 4 months

← Newer
1
...
7
8
9
10
11
12
13
...
23
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel October 2013