linaro-kernel June 2017

linaro-kernel@lists.linaro.org

34 participants
109 discussions

[PATCH V3 00/16] PM / OPP: Introduce APIs to transition OPPs

by Viresh Kumar

Hi Guys, This patchset add APIs in OPP layer to allow OPPs transitioning from within OPP layer. Currently all OPP users need to replicate the same code to switch between OPPs. While the same can be handled easily by OPP-core. The first 7 patches update the OPP core to introduce the new APIs and the next Nine patches update cpufreq-dt for the same. 11 out of 17 are already Reviewed by Stephen, only few are left :) I hope this is the last version of the series :) Testing: - Tested on exynos 5250-arndale (dual-cortex-A15) - Tested for both Old-V1 bindings and New V2 bindings - Tested with regulator names as: 'cpu-supply' and 'cpu0-supply' - Tested with Unsupported supply ranges as well, to check the opp-disable logic V2->V3: - Very minor updates. - find_supply_name() doesn't return an error value now, and so its callers don't check for it. - And so we don't need to initialize name to NULL Viresh Kumar (16): PM / OPP: get/put regulators from OPP core PM / OPP: Disable OPPs that aren't supported by the regulator PM / OPP: Introduce dev_pm_opp_get_max_volt_latency() PM / OPP: Introduce dev_pm_opp_get_max_transition_latency() PM / OPP: Parse clock-latency and voltage-tolerance for v1 bindings PM / OPP: Manage device clk PM / OPP: Add dev_pm_opp_set_rate() cpufreq: dt: Convert few pr_debug/err() calls to dev_dbg/err() cpufreq: dt: Rename 'need_update' to 'opp_v1' cpufreq: dt: OPP layers handles clock-latency for V1 bindings as well cpufreq: dt: Pass regulator name to the OPP core cpufreq: dt: Unsupported OPPs are already disabled cpufreq: dt: Reuse dev_pm_opp_get_max_transition_latency() cpufreq: dt: Use dev_pm_opp_set_rate() to switch frequency cpufreq: dt: No need to fetch voltage-tolerance cpufreq: dt: No need to allocate resources anymore drivers/base/power/opp/core.c | 420 ++++++++++++++++++++++++++++++++++++++++++ drivers/base/power/opp/opp.h | 13 ++ drivers/cpufreq/cpufreq-dt.c | 300 +++++++++++------------------- include/linux/pm_opp.h | 27 +++ 4 files changed, 565 insertions(+), 195 deletions(-) -- 2.7.1.370.gb2aa7f8

5 years, 9 months

[PATCH 00/34] CPUFreq: Move freq change notifications out of drivers

by Viresh Kumar

Another 452 lines gone :) Total stats upto now for all the 5 patchsets: Viresh Kumar (186): ... 69 files changed, 700 insertions(+), 2451 deletions(-) Net: 1751 lines gone.. -----x-------------x---------------- Most of the drivers do following in their ->target_index() routines: struct cpufreq_freqs freqs; freqs.old = old freq... freqs.new = new freq... cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE); /* Change rate here */ cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE); This is replicated over all cpufreq drivers today and there doesn't exists a good enough reason why this shouldn't be moved to cpufreq core instead. There are few special cases though, like exynos5440, which doesn't do everything on the call to ->target_index() routine and call some kind of bottom halves for doing this work, work/tasklet/etc.. They may continue doing notification from their own code and so this patch introduces another flag: CPUFREQ_NO_NOTIFICATION, which will be set by such drivers. This is Fifth part of my cleanup work for CPUFreq, first three are (And obviously its rebased over them): 1: cpufreq: Introduce cpufreq_table_validate_and_show() https://lkml.org/lkml/2013/8/8/263 2: cpufreq: define generic routines for cpufreq drivers https://lkml.org/lkml/2013/8/10/48 3. CPUFreq: Implement light weight ->target(): for 3.13 https://lkml.org/lkml/2013/8/13/349 4. CPUFreq: set policy->cur in cpufreq core instead of drivers https://lkml.org/lkml/2013/8/14/288 All these are pushed here: https://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/… -- viresh Cc: Andrew Lunn <andrew(a)lunn.ch> Cc: David S. Miller <davem(a)davemloft.net> Cc: Dmitry Eremin-Solenikov <dbaryshkov(a)gmail.com> Cc: Eric Miao <eric.y.miao(a)gmail.com> Cc: Hans-Christian Egtvedt <egtvedt(a)samfundet.no> Cc: Jesper Nilsson <jesper.nilsson(a)axis.com> Cc: John Crispin <blogic(a)openwrt.org> Cc: Kukjin Kim <kgene.kim(a)samsung.com> Cc: Linus Walleij <linus.walleij(a)linaro.org> Cc: linux-cris-kernel(a)axis.com Cc: Mikael Starvik <starvik(a)axis.com> Cc: Russell King <linux(a)arm.linux.org.uk> Cc: Santosh Shilimkar <santosh.shilimkar(a)ti.com> Cc: Sekhar Nori <nsekhar(a)ti.com> Cc: Shawn Guo <shawn.guo(a)linaro.org> Cc: sparclinux(a)vger.kernel.org Cc: spear-devel(a)list.st.com Cc: Stephen Warren <swarren(a)nvidia.com> Cc: Steven Miao <realmz6(a)gmail.com> Cc: Tony Luck <tony.luck(a)intel.com> Viresh Kumar (34): cpufreq: move freq change notifications to cpufreq core cpufreq: acpi: remove calls to cpufreq_notify_transition() cpufreq: arm_big_little: remove calls to cpufreq_notify_transition() cpufreq: at32ap: remove calls to cpufreq_notify_transition() cpufreq: blackfin: remove calls to cpufreq_notify_transition() cpufreq: cpu0: remove calls to cpufreq_notify_transition() cpufreq: cris: remove calls to cpufreq_notify_transition() cpufreq: davinci: remove calls to cpufreq_notify_transition() cpufreq: dbx500: remove calls to cpufreq_notify_transition() cpufreq: e_powersaver: remove calls to cpufreq_notify_transition() cpufreq: elanfreq: remove calls to cpufreq_notify_transition() cpufreq: exynos: remove calls to cpufreq_notify_transition() cpufreq: exynos5440: set CPUFREQ_NO_NOTIFICATION flag cpufreq: ia64-acpi: remove calls to cpufreq_notify_transition() cpufreq: imx6q: remove calls to cpufreq_notify_transition() cpufreq: kirkwood: remove calls to cpufreq_notify_transition() cpufreq: longhaul: set CPUFREQ_NO_NOTIFICATION flag cpufreq: loongson2: remove calls to cpufreq_notify_transition() cpufreq: maple: remove calls to cpufreq_notify_transition() cpufreq: omap: remove calls to cpufreq_notify_transition() cpufreq: p4-clockmod: remove calls to cpufreq_notify_transition() cpufreq: pasemi: remove calls to cpufreq_notify_transition() cpufreq: pmac: remove calls to cpufreq_notify_transition() cpufreq: powernow: remove calls to cpufreq_notify_transition() cpufreq: ppc: remove calls to cpufreq_notify_transition() cpufreq: pxa: remove calls to cpufreq_notify_transition() cpufreq: s3c: remove calls to cpufreq_notify_transition() cpufreq: s5pv210: remove calls to cpufreq_notify_transition() cpufreq: sa11x0: remove calls to cpufreq_notify_transition() cpufreq: sc520: remove calls to cpufreq_notify_transition() cpufreq: sparc: remove calls to cpufreq_notify_transition() cpufreq: SPEAr: remove calls to cpufreq_notify_transition() cpufreq: speedstep: remove calls to cpufreq_notify_transition() cpufreq: tegra: remove calls to cpufreq_notify_transition() drivers/cpufreq/acpi-cpufreq.c | 14 ++------- drivers/cpufreq/arm_big_little.c | 25 ++-------------- drivers/cpufreq/at32ap-cpufreq.c | 22 ++++++-------- drivers/cpufreq/blackfin-cpufreq.c | 22 +++++--------- drivers/cpufreq/cpufreq-cpu0.c | 33 ++++++++------------- drivers/cpufreq/cpufreq.c | 34 +++++++++++++++++++++ drivers/cpufreq/cris-artpec3-cpufreq.c | 8 ----- drivers/cpufreq/cris-etraxfs-cpufreq.c | 8 ----- drivers/cpufreq/davinci-cpufreq.c | 30 +++++++------------ drivers/cpufreq/dbx500-cpufreq.c | 22 +------------- drivers/cpufreq/e_powersaver.c | 23 ++------------- drivers/cpufreq/elanfreq.c | 13 -------- drivers/cpufreq/exynos-cpufreq.c | 28 +++++------------- drivers/cpufreq/exynos5440-cpufreq.c | 2 +- drivers/cpufreq/ia64-acpi-cpufreq.c | 19 ------------ drivers/cpufreq/imx6q-cpufreq.c | 39 ++++++++++-------------- drivers/cpufreq/kirkwood-cpufreq.c | 54 +++++++++++++--------------------- drivers/cpufreq/longhaul.c | 1 + drivers/cpufreq/loongson2_cpufreq.c | 16 ---------- drivers/cpufreq/maple-cpufreq.c | 18 +----------- drivers/cpufreq/omap-cpufreq.c | 39 +++++++++--------------- drivers/cpufreq/p4-clockmod.c | 10 ------- drivers/cpufreq/pasemi-cpufreq.c | 14 +-------- drivers/cpufreq/pmac32-cpufreq.c | 20 +++---------- drivers/cpufreq/pmac64-cpufreq.c | 18 +----------- drivers/cpufreq/powernow-k6.c | 8 ----- drivers/cpufreq/powernow-k7.c | 11 +------ drivers/cpufreq/powernow-k8.c | 15 +--------- drivers/cpufreq/ppc-corenet-cpufreq.c | 19 +----------- drivers/cpufreq/ppc_cbe_cpufreq.c | 19 +----------- drivers/cpufreq/pxa2xx-cpufreq.c | 27 ++++------------- drivers/cpufreq/pxa3xx-cpufreq.c | 12 -------- drivers/cpufreq/s3c2416-cpufreq.c | 21 +++---------- drivers/cpufreq/s3c64xx-cpufreq.c | 48 ++++++++++-------------------- drivers/cpufreq/s5pv210-cpufreq.c | 16 ++++------ drivers/cpufreq/sa1100-cpufreq.c | 17 ++++------- drivers/cpufreq/sa1110-cpufreq.c | 12 ++------ drivers/cpufreq/sc520_freq.c | 11 ------- drivers/cpufreq/sparc-us2e-cpufreq.c | 7 ----- drivers/cpufreq/sparc-us3-cpufreq.c | 7 ----- drivers/cpufreq/spear-cpufreq.c | 13 +------- drivers/cpufreq/speedstep-centrino.c | 20 +------------ drivers/cpufreq/speedstep-ich.c | 9 ------ drivers/cpufreq/speedstep-smi.c | 7 ----- drivers/cpufreq/tegra-cpufreq.c | 25 ++++------------ include/linux/cpufreq.h | 6 ++++ 46 files changed, 205 insertions(+), 657 deletions(-) -- 1.7.12.rc2.18.g61b472e

6 years, 6 months

[PATCH v2 0/3] rtc: make st-lpc robust against y2038/2106 bug

by Benjamin Gaignard

On 32bits platforms "struct timeval" or "time_t" are using u32 to code the date, this cause tools like "date" or "hwclock" failed even before setting the RTC device if the date is superior to year 2038 (or 2106). To avoid this problem I add one RTC test file which directly use RTC ioctl to set and read RTC time and alarm values. rtctest_setdate allow to set any date/time given in the command line. On this version 2 I add check of problematics years in rtctest like suggest by Alexandre. Finally that had allowed me to test and fix rtc-st-lpc driver. Benjamin Gaignard (3): tools: timer: add rtctest_setdate tool: timer: rtctest add check for problematic dates rtc: st-lpc: make it robust against y2038/2106 bug drivers/rtc/rtc-st-lpc.c | 19 ++-- tools/testing/selftests/timers/Makefile | 2 +- tools/testing/selftests/timers/rtctest.c | 121 ++++++++++++++++++++++- tools/testing/selftests/timers/rtctest_setdate.c | 86 ++++++++++++++++ 4 files changed, 212 insertions(+), 16 deletions(-) create mode 100644 tools/testing/selftests/timers/rtctest_setdate.c -- 1.9.1

6 years, 9 months

[PATCH 00/51] rtc: stop using rtc deprecated functions

by Benjamin Gaignard

rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. The goal of this series of patches is ti stop using those two functions and use instead to safer 64bits ones. It also remove change .set_mmss to set_mmss64 callback for the same reasons. Those 51 patches almost clean all the drivers except the few that I haven't been able to compile because of cross-toolchains issues (au1xxx, mpc5121, ps3, puv3, sun4v, tx4939, starfire, ls1x ...) Obviously I don't have all those hardwares in my hands so I have only check that the patches compile without warnings but it up to each maintainer to valid them on real hardware. Benjamin Gaignard (51): x86: rtc: stop using rtc deprecated functions x86: intel-mid: vrtc: stop using rtc deprecated functions net: broadcom: stop using rtc deprecated functions rtc: 88pm80x: stop using rtc deprecated functions rtc: 88pm860x: stop using rtc deprecated functions rtc: ab-b5ze-s3: stop using rtc deprecated functions rtc: ab8500: stop using rtc deprecated functions rtc: armada38x: stop using rtc deprecated functions rtc: at32ap700x: stop using rtc deprecated functions rtc: at91sam9: stop using rtc deprecated functions rtc: bfin: stop using rtc deprecated functions rtc: coh901331: stop using rtc deprecated functions rtc: cpcap: stop using rtc deprecated functions rtc: da9063: stop using rtc deprecated functions rtc: da9063: stop using rtc deprecated functions rtc: davinci: stop using rtc deprecated functions rtc: digicolor: stop using rtc deprecated functions rtc: dm355evm: stop using rtc deprecated functions rtc: ds1305: stop using rtc deprecated functions rtc: ds1374: stop using rtc deprecated functions rtc: ds1511: stop using rtc deprecated functions rtc: ds1553: stop using rtc deprecated functions rtc: ds1672: stop using rtc deprecated functions rtc: ds2404: stop using rtc deprecated functions rtc: ep93xx: stop using rtc deprecated functions rtc: gemini: stop using rtc deprecated functions rtc: imxdi: stop using rtc deprecated functions rtc: jz4740: stop using rtc deprecated functions rtc: lpc32xx: stop using rtc deprecated functions rtc: mv: stop using rtc deprecated functions rtc: omap: stop using rtc deprecated functions rtc: pcap: stop using rtc deprecated functions rtc: pl030: stop using rtc deprecated functions rtc: pl031: stop using rtc deprecated functions rtc: pm8xxx: stop using rtc deprecated functions rtc: rs5c348: stop using rtc deprecated functions rtc: sa1100: stop using rtc deprecated functions rtc: sh: stop using rtc deprecated functions rtc: sirfsoc: stop using rtc deprecated functions rtc: snvs: stop using rtc deprecated functions rtc: stk17ta8: stop using rtc deprecated functions rtc: stmp3xxx: stop using rtc deprecated functions rtc: sun6i: stop using rtc deprecated functions rtc: sysfs: stop using rtc deprecated functions rtc: tegra stop using rtc deprecated functions rtc: test: stop using rtc deprecated functions rtc: tps6586: stop using rtc deprecated functions rtc: vr41xx: stop using rtc deprecated functions rtc: wm831x: stop using rtc deprecated functions rtc: xgene stop using rtc deprecated functions power: suspend test: stop using rtc deprecated functions arch/x86/kernel/rtc.c | 6 ++-- arch/x86/platform/intel-mid/intel_mid_vrtc.c | 2 +- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- drivers/rtc/rtc-88pm80x.c | 44 +++++++++++++-------------- drivers/rtc/rtc-88pm860x.c | 40 ++++++++++++------------- drivers/rtc/rtc-ab-b5ze-s3.c | 45 ++++++++-------------------- drivers/rtc/rtc-ab8500.c | 26 ++++++++-------- drivers/rtc/rtc-armada38x.c | 34 +++++++++------------ drivers/rtc/rtc-at32ap700x.c | 29 ++++++++---------- drivers/rtc/rtc-at91sam9.c | 18 ++++------- drivers/rtc/rtc-bfin.c | 24 +++++++-------- drivers/rtc/rtc-coh901331.c | 14 +++++---- drivers/rtc/rtc-cpcap.c | 8 ++--- drivers/rtc/rtc-da9052.c | 8 ++--- drivers/rtc/rtc-da9063.c | 8 ++--- drivers/rtc/rtc-davinci.c | 8 ++--- drivers/rtc/rtc-digicolor.c | 4 +-- drivers/rtc/rtc-dm355evm.c | 6 ++-- drivers/rtc/rtc-ds1305.c | 11 +++---- drivers/rtc/rtc-ds1374.c | 6 ++-- drivers/rtc/rtc-ds1511.c | 2 +- drivers/rtc/rtc-ds1553.c | 2 +- drivers/rtc/rtc-ds1672.c | 8 ++--- drivers/rtc/rtc-ds2404.c | 8 ++--- drivers/rtc/rtc-ep93xx.c | 10 +++---- drivers/rtc/rtc-gemini.c | 8 ++--- drivers/rtc/rtc-imxdi.c | 16 +++++----- drivers/rtc/rtc-jz4740.c | 12 ++++---- drivers/rtc/rtc-lpc32xx.c | 19 +++++------- drivers/rtc/rtc-mv.c | 2 +- drivers/rtc/rtc-omap.c | 6 ++-- drivers/rtc/rtc-pcap.c | 16 +++++----- drivers/rtc/rtc-pl030.c | 24 +++++++-------- drivers/rtc/rtc-pl031.c | 31 ++++++++----------- drivers/rtc/rtc-pm8xxx.c | 22 +++++++------- drivers/rtc/rtc-rs5c348.c | 4 +-- drivers/rtc/rtc-sa1100.c | 25 +++++++--------- drivers/rtc/rtc-sh.c | 2 +- drivers/rtc/rtc-sirfsoc.c | 18 +++++------ drivers/rtc/rtc-snvs.c | 14 ++++----- drivers/rtc/rtc-stk17ta8.c | 2 +- drivers/rtc/rtc-stmp3xxx.c | 12 ++++---- drivers/rtc/rtc-sun6i.c | 14 ++++----- drivers/rtc/rtc-sysfs.c | 25 ++++++++-------- drivers/rtc/rtc-tegra.c | 22 +++++++------- drivers/rtc/rtc-test.c | 17 +---------- drivers/rtc/rtc-tps6586x.c | 26 ++++++++-------- drivers/rtc/rtc-vr41xx.c | 6 ++-- drivers/rtc/rtc-wm831x.c | 28 +++++++---------- drivers/rtc/rtc-xgene.c | 12 ++++---- kernel/power/suspend_test.c | 6 ++-- 51 files changed, 342 insertions(+), 420 deletions(-) -- CC: adi-buildroot-devel(a)lists.sourceforge.net CC: Alessandro Zummo <a.zummo(a)towertech.it> CC: Alexandre Belloni <alexandre.belloni(a)free-electrons.com> CC: Gregory Clement <gregory.clement(a)free-electrons.com> CC: Ingo Molnar <mingo(a)redhat.com> CC: Jason Cooper <jason(a)lakedaemon.net> CC: John Stultz <john.stultz(a)linaro.org> CC: linux-arm-kernel(a)lists.infradead.org CC: linux-kernel(a)vger.kernel.org CC: Linus Walleij <linus.walleij(a)linaro.org> CC: Michael Chan <michael.chan(a)broadcom.com> CC: netdev(a)vger.kernel.org CC: rtc-linux(a)googlegroups.com CC: Sebastian Hesselbarth <sebastian.hesselbarth(a)gmail.com> CC: Support Opensource <support.opensource(a)diasemi.com> CC: Thomas Gleixner <tglx(a)linutronix.de> CC: x86(a)kernel.org CC: Baruch Siach <baruch(a)tkos.co.il> CC: Hans Ulli Kroll <ulli.kroll(a)googlemail.com> CC: Vladimir Zapolskiy <vz(a)mleia.com> CC: Sylvain Lemieux <slemieux.tyco(a)gmail.com> CC: Barry Song <baohua(a)kernel.org> CC: Maxime Ripard <maxime.ripard(a)free-electrons.com> CC: Chen-Yu Tsai <wens(a)csie.org> CC: Thierry Reding <thierry.reding(a)gmail.com> CC: Jonathan Hunter <jonathanh(a)nvidia.com> CC: linux-tegra(a)vger.kernel.org CC: patches(a)opensource.wolfsonmicro.com CC: "Rafael J. Wysocki" <rjw(a)rjwysocki.net> CC: Pavel Machek <pavel(a)ucw.cz> CC: Len Brown <len.brown(a)intel.com> CC: linux-pm(a)vger.kernel.org 1.9.1

6 years, 9 months

master build: 0 failures 0 warnings (v4.12-rc7-89-gb4df2e3537be)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.12-rc7-89-gb4df2e3537be Commit: b4df2e3537 Merge tag 'powerpc-4.12-8' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux Build Time: 0 min 11 sec Passed: 7 / 7 (100.00 %) Failed: 0 / 7 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

6 years, 9 months

next-20170630 build: 1 failures 7 warnings (next-20170630)

by Build bot for Mark Brown

Tree/Branch: next-20170630 Git describe: next-20170630 Commit: a70e9c77d0 Add linux-next specific files for 20170630 Build Time: 0 min 11 sec Passed: 6 / 7 ( 85.71 %) Failed: 1 / 7 ( 14.29 %) Errors: 1 Warnings: 7 Section Mismatches: 0 Failed defconfigs: arm-allmodconfig Errors: arm-allmodconfig ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 2 warnings 0 mismatches : arm-multi_v5_defconfig 1 warnings 0 mismatches : arm-multi_v7_defconfig 4 warnings 0 mismatches : arm-allmodconfig 2 warnings 0 mismatches : arm-allnoconfig 1 warnings 0 mismatches : x86_64-allnoconfig 2 warnings 0 mismatches : arm-multi_v4t_defconfig ------------------------------------------------------------------------------- Errors summary: 1 1 ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! Warnings Summary: 7 3 ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want 3 ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list 2 ../drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable] 1 ../kernel/sched/fair.c:2655:44: warning: 'struct sched_domain' declared inside parameter list will not be visible outside of this definition or declaration 1 ../include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] 1 ../drivers/staging/media/imx/imx-media-of.c:216:4: warning: 'remote_np' may be used uninitialized in this function [-Wmaybe-uninitialized] 1 ../drivers/pinctrl/pinctrl-rza1.c:1260:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm-multi_v5_defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want ------------------------------------------------------------------------------- arm-multi_v7_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable] ------------------------------------------------------------------------------- arm-allmodconfig : FAIL, 1 errors, 4 warnings, 0 section mismatches Errors: ERROR: "__aeabi_uldivmod" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! Warnings: ../drivers/pinctrl/pinctrl-rza1.c:1260:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] ../drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable] ../include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] ../drivers/staging/media/imx/imx-media-of.c:216:4: warning: 'remote_np' may be used uninitialized in this function [-Wmaybe-uninitialized] ------------------------------------------------------------------------------- arm-allnoconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want ------------------------------------------------------------------------------- x86_64-allnoconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2655:44: warning: 'struct sched_domain' declared inside parameter list will not be visible outside of this definition or declaration ------------------------------------------------------------------------------- arm-multi_v4t_defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: x86_64-defconfig

6 years, 9 months

[PATCH] cpufreq: Find transition latency dynamically

by Viresh Kumar

The transition_latency_ns represents the maximum time it can take for the hardware to switch from/to any frequency for a CPU. The transition_latency_ns is used currently for two purposes: o To check if the hardware latency is over the maximum allowed for a governor (only for ondemand and conservative (why not schedutil?)) and to decide if the governor can be used or not. o To calculate the sampling_rate or rate_limit for the governors by multiplying transition_latency_ns with a constant. The platform drivers can also set this value to CPUFREQ_ETERNAL if they don't know this number and in that case we disallow use of ondemand and conservative governors as the latency would be higher than the maximum allowed for the governors. In many cases this number is forged by the driver authors to get the default sampling rate to a desired value. Anyway, the actual latency values can differ from what is received from the hardware designers. Over that, what is provided by the drivers is most likely the time it takes to change frequency of the hardware, which doesn't account the software overhead involved. In order to have guarantees about this number, this patch tries to calculate the latency dynamically at cpufreq driver registration time by first switching to min frequency, then to the max and finally back to the initial frequency. And the maximum of all three is used as the target_latency. Specifically the time it takes to go from min to max frequency (when the software runs the slowest) should be good enough, and even if there is a delta involved then it shouldn't be a lot. For now this patch limits this feature only for platforms which have set the transition latency to CPUFREQ_ETERNAL. Maybe we can convert everyone to use it in future, but lets see. This is tested over ARM64 Hikey platform which currently sets "clock-latency" as 500 us from DT, while with this patch the actualy value increased to 800 us. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/cpufreq.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 0e3f6496524d..478a18364b1f 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -25,6 +25,7 @@ #include <linux/kernel_stat.h> #include <linux/module.h> #include <linux/mutex.h> +#include <linux/sched/clock.h> #include <linux/slab.h> #include <linux/suspend.h> #include <linux/syscore_ops.h> @@ -977,6 +978,66 @@ __weak struct cpufreq_governor *cpufreq_default_governor(void) return NULL; } +static int find_dvfs_latency(struct cpufreq_policy *policy, unsigned long freq, + unsigned int *latency_ns) +{ + u64 time; + int ret; + + time = local_clock(); + ret = __cpufreq_driver_target(policy, freq, CPUFREQ_RELATION_L); + *latency_ns = local_clock() - time; + + return ret; +} + +/* + * Find the transition latency dynamically by: + * - Switching to min freq first. + * - Then switching to max freq. + * - And finally switching back to the initial freq. + * + * The maximum duration of the above three freq changes should be good enough to + * find the maximum transition latency for a platform. + */ +static void cpufreq_find_target_latency(struct cpufreq_policy *policy) +{ + unsigned long initial_freq = policy->cur; + unsigned int latency_ns, latency_max_ns; + int ret; + + if (!has_target()) + return; + + /* Limit to drivers with latency set to CPUFREQ_ETERNAL for now */ + if (policy->cpuinfo.transition_latency != CPUFREQ_ETERNAL) + return; + + /* Go to min frequency first */ + ret = find_dvfs_latency(policy, policy->cpuinfo.min_freq, &latency_ns); + if (ret) + return; + + latency_max_ns = latency_ns; + + /* Go to max frequency then.. */ + ret = find_dvfs_latency(policy, policy->cpuinfo.max_freq, &latency_ns); + if (ret) + return; + + latency_max_ns = max(latency_max_ns, latency_ns); + + /* And finally switch back to where we started from */ + ret = find_dvfs_latency(policy, initial_freq, &latency_ns); + if (ret) + return; + + policy->cpuinfo.transition_latency = max(latency_max_ns, latency_ns); + + pr_info("%s: Setting transition latency to %u ns for policy of CPU%d\n", + __func__, policy->cpuinfo.transition_latency, policy->cpu); +} + static int cpufreq_init_policy(struct cpufreq_policy *policy) { struct cpufreq_governor *gov = NULL; @@ -1246,6 +1307,8 @@ static int cpufreq_online(unsigned int cpu) } if (new_policy) { + cpufreq_find_target_latency(policy); + ret = cpufreq_add_dev_interface(policy); if (ret) goto out_exit_policy; -- 2.13.0.70.g6367777092d9

6 years, 9 months

master build: 0 failures 0 warnings (v4.12-rc7-77-g4d8a991d460d)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.12-rc7-77-g4d8a991d460d Commit: 4d8a991d46 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net Build Time: 0 min 14 sec Passed: 7 / 7 (100.00 %) Failed: 0 / 7 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

6 years, 9 months

next-20170629 build: 0 failures 6 warnings (next-20170629)

by Build bot for Mark Brown

Tree/Branch: next-20170629 Git describe: next-20170629 Commit: 3fb8ba638d Add linux-next specific files for 20170629 Build Time: 0 min 10 sec Passed: 7 / 7 (100.00 %) Failed: 0 / 7 ( 0.00 %) Errors: 0 Warnings: 6 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 2 warnings 0 mismatches : arm-multi_v5_defconfig 1 warnings 0 mismatches : arm-multi_v7_defconfig 3 warnings 0 mismatches : arm-allmodconfig 2 warnings 0 mismatches : arm-allnoconfig 1 warnings 0 mismatches : x86_64-allnoconfig 2 warnings 0 mismatches : arm-multi_v4t_defconfig ------------------------------------------------------------------------------- Warnings Summary: 6 3 ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want 3 ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list 2 ../drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable] 1 ../kernel/sched/fair.c:2655:44: warning: 'struct sched_domain' declared inside parameter list will not be visible outside of this definition or declaration 1 ../include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] 1 ../drivers/staging/media/imx/imx-media-of.c:216:4: warning: 'remote_np' may be used uninitialized in this function [-Wmaybe-uninitialized] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm-multi_v5_defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want ------------------------------------------------------------------------------- arm-multi_v7_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable] ------------------------------------------------------------------------------- arm-allmodconfig : PASS, 0 errors, 3 warnings, 0 section mismatches Warnings: ../drivers/rtc/rtc-brcmstb-waketimer.c:142:6: warning: unused variable 'ret' [-Wunused-variable] ../drivers/staging/media/imx/imx-media-of.c:216:4: warning: 'remote_np' may be used uninitialized in this function [-Wmaybe-uninitialized] ../include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] ------------------------------------------------------------------------------- arm-allnoconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want ------------------------------------------------------------------------------- x86_64-allnoconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2655:44: warning: 'struct sched_domain' declared inside parameter list will not be visible outside of this definition or declaration ------------------------------------------------------------------------------- arm-multi_v4t_defconfig : PASS, 0 errors, 2 warnings, 0 section mismatches Warnings: ../kernel/sched/fair.c:2657:9: warning: 'struct sched_domain' declared inside parameter list ../kernel/sched/fair.c:2657:9: warning: its scope is only this definition or declaration, which is probably not what you want ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: x86_64-defconfig

6 years, 10 months

master build: 0 failures 0 warnings (v4.12-rc7-25-g6474924e2b5d)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.12-rc7-25-g6474924e2b5d Commit: 6474924e2b arch: remove unused macro/function thread_saved_pc() Build Time: 0 min 11 sec Passed: 7 / 7 (100.00 %) Failed: 0 / 7 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

6 years, 10 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel June 2017