linaro-kernel December 2013

linaro-kernel@lists.linaro.org

83 participants
265 discussions

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> Another spin of the arm64 topology work - this should incorporate most of the feedback from Lorenzo, there's a few things that were still under discussion the main ones being: - Should we have a smp_store_cpu_info(); like I say I like the errors it generates for omitted cores and the reuse of the SMP enumeration code (and cross-check with that I guess - make sure we don't get confused about which CPUs are getting enabled). - Should we update the binding to allow cores in the root cpu_map node (since it's less effort in code and not a meaningful difference semantically), warn if we find cores in the cpu_map node or actively reject such DTs? In both cases I don't much mind but I think what's there is reasonable so I've left the code as-is pending further feedback. I also didn't update the code to get more reuse of the iteration code, like I said I did look at that when writing the code but couldn't find anything that actually made things more pleasant but if someone has some ideas... Everything else raised should be addressed I think. Mark Brown (4): arm64: topology: Implement basic CPU topology support arm64: topology: Add support for topology DT bindings arm64: topology: Tell the scheduler about the relative power of cores arm64: topology: Provide relative power numbers for cores arch/arm64/Kconfig | 24 +++ arch/arm64/include/asm/topology.h | 39 ++++ arch/arm64/kernel/Makefile | 1 + arch/arm64/kernel/smp.c | 12 ++ arch/arm64/kernel/topology.c | 384 ++++++++++++++++++++++++++++++++++++++ 5 files changed, 460 insertions(+) create mode 100644 arch/arm64/include/asm/topology.h create mode 100644 arch/arm64/kernel/topology.c -- 1.8.5.2

10 years, 11 months

[Query]: trace-cmd crashing with '-e syscalls' on 3.13-rc1

by Viresh Kumar

Hi Steven, I am trying to trace some stuff on Samsung's Arndale Board (ARM) with 3.13-rc1 and seeing these crashes/segmentation faults whenever I try to trace syscalls. Is this a know issue? Or something new? trace-cmd version 2.2.0 [ 299.998874] Unable to handle kernel NULL pointer dereference at virtual address 0000001b [ 300.005554] pgd = ed9fc000 [ 300.008201] [0000001b] *pgd=6eb1e831, *pte=00000000, *ppte=00000000 [ 300.014428] Internal error: Oops: 17 [#1] PREEMPT SMP ARM [ 300.019812] Modules linked in: [ 300.022847] CPU: 0 PID: 2172 Comm: is-cpu-isolated Not tainted 3.13.0-rc1-00090-gd6eaf98-dirty #141 [ 300.031880] task: ee9a9680 ti: eddfc000 task.ti: eddfc000 [ 300.037263] PC is at ftrace_syscall_enter+0x44/0x17c [ 300.042208] LR is at syscall_trace_enter+0xf8/0x138 [ 300.047066] pc : [<c00ad654>] lr : [<c0010eb0>] psr: a0000013 [ 300.047066] sp : eddfdf40 ip : eddfdf80 fp : eddfdf7c [ 300.058529] r10: 00001400 r9 : eddfc000 r8 : c000eea4 [ 300.063731] r7 : eddfdfb0 r6 : eddfc000 r5 : ffffffff r4 : 000f0005 [ 300.070242] r3 : eddfc000 r2 : 000f001d r1 : eddfdfb0 r0 : c06cb2f8 [ 300.076754] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 300.083872] Control: 10c5387d Table: 6d9fc06a DAC: 00000015 [ 300.089599] Process is-cpu-isolated (pid: 2172, stack limit = 0xeddfc240) [ 300.096370] Stack: (0xeddfdf40 to 0xeddfe000) [ 300.100711] df40: ef1c5910 00000000 eddfdf8c 00000022 00000003 ede2c490 000f0005 eddfc000 [ 300.108872] df60: eddfdfb0 c000eea4 eddfc000 00001400 eddfdfa4 eddfdf80 c0010eb0 c00ad61c [ 300.117034] df80: b6f824c0 b6f83c90 00000001 00000000 000f0005 c000eea4 00000000 eddfdfa8 [ 300.125194] dfa0: c000ee4c c0010dc4 b6f83c90 00000001 b6f824c0 b6f88050 b6f82b98 b6f824c0 [ 300.133352] dfc0: b6f83c90 00000001 00000000 000f0005 00000001 00000000 0009688c b6f88958 [ 300.141511] dfe0: 000f0005 bef66460 b6f698fb b6f79966 80000030 b6f824c0 00000000 00000000 [ 300.149678] [<c00ad654>] (ftrace_syscall_enter+0x44/0x17c) from [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) [ 300.159573] [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) from [<c000ee4c>] (__sys_trace+0xc/0x38) [ 300.168510] Code: e2842018 e7905102 e3550000 0a000038 (e595201c) [ 300.174595] ---[ end trace f8b3633d964e9e60 ]--- [ 300.179189] note: is-cpu-isolated[2172] exited with preempt_count 1 Segmentation fault [ 300.956933] Unable to handle kernel NULL pointer dereference at virtual address 0000001b [ 300.963587] pgd = ed9fc000 [ 300.966234] [0000001b] *pgd=6ebd3831, *pte=00000000, *ppte=00000000 [ 300.972483] Internal error: Oops: 17 [#2] PREEMPT SMP ARM [ 300.977867] Modules linked in: [ 300.980903] CPU: 0 PID: 2173 Comm: trace-cmd Tainted: G D 3.13.0-rc1-00090-gd6eaf98-dirty #141 [ 300.990372] task: ee9aa1c0 ti: eddfe000 task.ti: eddfe000 [ 300.995752] PC is at ftrace_syscall_enter+0x44/0x17c [ 301.000700] LR is at syscall_trace_enter+0xf8/0x138 [ 301.005557] pc : [<c00ad654>] lr : [<c0010eb0>] psr: a0000013 [ 301.005557] sp : eddfff40 ip : eddfff80 fp : eddfff7c [ 301.017022] r10: 00001400 r9 : eddfe000 r8 : c000eea4 [ 301.022222] r7 : eddfffb0 r6 : eddfe000 r5 : ffffffff r4 : 000f0005 [ 301.028733] r3 : eddfe000 r2 : 000f001d r1 : eddfffb0 r0 : c06cb2f8 [ 301.035244] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 301.042362] Control: 10c5387d Table: 6d9fc06a DAC: 00000015 [ 301.048089] Process trace-cmd (pid: 2173, stack limit = 0xeddfe240) [ 301.054340] Stack: (0xeddfff40 to 0xede00000) [ 301.058679] ff40: eddfffb0 ef09a280 eddfff8c eddfff58 c00ad2d0 ede2c490 000f0005 eddfe000 [ 301.066843] ff60: eddfffb0 c000eea4 eddfe000 00001400 eddfffa4 eddfff80 c0010eb0 c00ad61c [ 301.075002] ff80: 000bc320 000bc318 00000008 00000010 000f0005 c000eea4 00000000 eddfffa8 [ 301.083162] ffa0: c000ee4c c0010dc4 000bc318 00000008 000be4c0 000b2018 00000000 000bc320 [ 301.091321] ffc0: 000bc318 00000008 00000010 000f0005 00000038 000be4c0 00000004 00000001 [ 301.099480] ffe0: 000f0005 be9cc6d8 0002ed43 0002ef66 40000030 000be4c0 6f7fd821 6f7fdc21 [ 301.107645] [<c00ad654>] (ftrace_syscall_enter+0x44/0x17c) from [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) [ 301.117540] [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) from [<c000ee4c>] (__sys_trace+0xc/0x38) [ 301.126477] Code: e2842018 e7905102 e3550000 0a000038 (e595201c) [ 301.132565] ---[ end trace f8b3633d964e9e61 ]--- [ 301.137158] note: trace-cmd[2173] exited with preempt_count 1 Segmentation fault [ 301.922253] Unable to handle kernel NULL pointer dereference at virtual address 0000001b [ 301.928899] pgd = eda00000 [ 301.931556] [0000001b] *pgd=6d9f2831, *pte=00000000, *ppte=00000000 [ 301.937803] Internal error: Oops: 17 [#3] PREEMPT SMP ARM [ 301.943187] Modules linked in: [ 301.946223] CPU: 0 PID: 2174 Comm: cat Tainted: G D 3.13.0-rc1-00090-gd6eaf98-dirty #141 [ 301.955172] task: ee9aa580 ti: ed9f8000 task.ti: ed9f8000 [ 301.960552] PC is at ftrace_syscall_enter+0x44/0x17c [ 301.965500] LR is at syscall_trace_enter+0xf8/0x138 [ 301.970356] pc : [<c00ad654>] lr : [<c0010eb0>] psr: a0000013 [ 301.970356] sp : ed9f9f40 ip : ed9f9f80 fp : ed9f9f7c [ 301.981820] r10: 00001400 r9 : ed9f8000 r8 : c000eea4 [ 301.987021] r7 : ed9f9fb0 r6 : ed9f8000 r5 : ffffffff r4 : 000f0005 [ 301.993532] r3 : ed9f8000 r2 : 000f001d r1 : ed9f9fb0 r0 : c06cb2f8 [ 302.000044] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 302.007161] Control: 10c5387d Table: 6da0006a DAC: 00000015 [ 302.012888] Process cat (pid: 2174, stack limit = 0xed9f8240) [ 302.018617] Stack: (0xed9f9f40 to 0xed9fa000) [ 302.022958] 9f40: ed9f9fb0 00000000 ed9f9f8c 00000022 00000003 ede2c490 000f0005 ed9f8000 [ 302.031122] 9f60: ed9f9fb0 c000eea4 ed9f8000 00001400 ed9f9fa4 ed9f9f80 c0010eb0 c00ad61c [ 302.039281] 9f80: b6f6d840 b6f6d178 00000001 00000000 000f0005 c000eea4 00000000 ed9f9fa8 [ 302.047440] 9fa0: c000ee4c c0010dc4 b6f6d178 00000001 b6f6d840 b6f72050 b6f6df18 b6f6d840 [ 302.055599] 9fc0: b6f6d178 00000001 00000000 000f0005 00000001 00000000 0000e67c b6f72958 [ 302.063758] 9fe0: 000f0005 beaf6480 b6f538fb b6f63966 80000030 b6f6d840 00000000 00000000 [ 302.071922] [<c00ad654>] (ftrace_syscall_enter+0x44/0x17c) from [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) [ 302.081819] [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) from [<c000ee4c>] (__sys_trace+0xc/0x38) [ 302.090756] Code: e2842018 e7905102 e3550000 0a000038 (e595201c) [ 302.096845] ---[ end trace f8b3633d964e9e62 ]--- [ 302.101436] note: cat[2174] exited with preempt_count 1 Segmentation fault [ 302.881881] Unable to handle kernel NULL pointer dereference at virtual address 0000001b [ 302.888532] pgd = ed9fc000 [ 302.891180] [0000001b] *pgd=6eb1e831, *pte=00000000, *ppte=00000000 [ 302.897429] Internal error: Oops: 17 [#4] PREEMPT SMP ARM [ 302.902813] Modules linked in: [ 302.905849] CPU: 0 PID: 2175 Comm: trace-cmd Tainted: G D 3.13.0-rc1-00090-gd6eaf98-dirty #141 [ 302.915319] task: ee9aa1c0 ti: ee492000 task.ti: ee492000 [ 302.920698] PC is at ftrace_syscall_enter+0x44/0x17c [ 302.925645] LR is at syscall_trace_enter+0xf8/0x138 [ 302.930503] pc : [<c00ad654>] lr : [<c0010eb0>] psr: a0000013 [ 302.930503] sp : ee493f40 ip : ee493f80 fp : ee493f7c [ 302.941967] r10: 00001400 r9 : ee492000 r8 : c000eea4 [ 302.947169] r7 : ee493fb0 r6 : ee492000 r5 : ffffffff r4 : 000f0005 [ 302.953679] r3 : ee492000 r2 : 000f001d r1 : ee493fb0 r0 : c06cb2f8 [ 302.960190] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 302.967307] Control: 10c5387d Table: 6d9fc06a DAC: 00000015 [ 302.973035] Process trace-cmd (pid: 2175, stack limit = 0xee492240) [ 302.979286] Stack: (0xee493f40 to 0xee494000) [ 302.983625] 3f40: ee493fb0 ef09a280 ee493f8c ee493f58 c00ad2d0 ede2c490 000f0005 ee492000 [ 302.991789] 3f60: ee493fb0 c000eea4 ee492000 00001400 ee493fa4 ee493f80 c0010eb0 c00ad61c [ 302.999948] 3f80: 000bc320 000bc318 00000008 00000010 000f0005 c000eea4 00000000 ee493fa8 [ 303.008108] 3fa0: c000ee4c c0010dc4 000bc318 00000008 000be4c0 000b2018 00000000 000bc320 [ 303.016267] 3fc0: 000bc318 00000008 00000010 000f0005 00000038 000be4c0 00000004 00000001 [ 303.024426] 3fe0: 000f0005 be8c76c8 0002ed43 0002ef66 40000030 000be4c0 00000000 00000000 [ 303.032591] [<c00ad654>] (ftrace_syscall_enter+0x44/0x17c) from [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) [ 303.042487] [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) from [<c000ee4c>] (__sys_trace+0xc/0x38) [ 303.051423] Code: e2842018 e7905102 e3550000 0a000038 (e595201c) [ 303.057512] ---[ end trace f8b3633d964e9e63 ]--- [ 303.062103] note: trace-cmd[2175] exited with preempt_count 1 Segmentation fault [ 303.842447] Unable to handle kernel NULL pointer dereference at virtual address 0000001b [ 303.849096] pgd = eddfc000 [ 303.851752] [0000001b] *pgd=6d9f1831, *pte=00000000, *ppte=00000000 [ 303.858002] Internal error: Oops: 17 [#5] PREEMPT SMP ARM [ 303.863386] Modules linked in: [ 303.866422] CPU: 0 PID: 2176 Comm: is-cpu-isolated Tainted: G D 3.13.0-rc1-00090-gd6eaf98-dirty #141 [ 303.876412] task: ee9a9680 ti: ed9fa000 task.ti: ed9fa000 [ 303.881791] PC is at ftrace_syscall_enter+0x44/0x17c [ 303.886738] LR is at syscall_trace_enter+0xf8/0x138 [ 303.891596] pc : [<c00ad654>] lr : [<c0010eb0>] psr: a0000013 [ 303.891596] sp : ed9fbf40 ip : ed9fbf80 fp : ed9fbf7c [ 303.903059] r10: 00001400 r9 : ed9fa000 r8 : c000eea4 [ 303.908261] r7 : ed9fbfb0 r6 : ed9fa000 r5 : ffffffff r4 : 000f0005 [ 303.914772] r3 : ed9fa000 r2 : 000f001d r1 : ed9fbfb0 r0 : c06cb2f8 [ 303.921283] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 303.928400] Control: 10c5387d Table: 6ddfc06a DAC: 00000015 [ 303.934128] Process is-cpu-isolated (pid: 2176, stack limit = 0xed9fa240) [ 303.940900] Stack: (0xed9fbf40 to 0xed9fc000) [ 303.945239] bf40: ed9fbfb0 00000000 ed9fbf8c 00000022 00000003 ede2c490 000f0005 ed9fa000 [ 303.953403] bf60: ed9fbfb0 c000eea4 ed9fa000 00001400 ed9fbfa4 ed9fbf80 c0010eb0 c00ad61c [ 303.961562] bf80: b6f174c0 b6f18c90 00000001 00000000 000f0005 c000eea4 00000000 ed9fbfa8 [ 303.969721] bfa0: c000ee4c c0010dc4 b6f18c90 00000001 b6f174c0 b6f1d050 b6f17b98 b6f174c0 [ 303.977880] bfc0: b6f18c90 00000001 00000000 000f0005 00000001 00000000 0009688c b6f1d958 [ 303.986039] bfe0: 000f0005 be90c460 b6efe8fb b6f0e966 80000030 b6f174c0 6f7fd821 6f7fdc21 [ 303.994204] [<c00ad654>] (ftrace_syscall_enter+0x44/0x17c) from [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) [ 304.004101] [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) from [<c000ee4c>] (__sys_trace+0xc/0x38) [ 304.013037] Code: e2842018 e7905102 e3550000 0a000038 (e595201c) [ 304.019125] ---[ end trace f8b3633d964e9e64 ]--- [ 304.023717] note: is-cpu-isolated[2176] exited with preempt_count 1 Segmentation fault Saved trace in: dft [ 304.807095] Unable to handle kernel NULL pointer dereference at virtual address 0000001b [ 304.813737] pgd = ed9fc000 [ 304.816395] [0000001b] *pgd=6eb1e831, *pte=00000000, *ppte=00000000 [ 304.822644] Internal error: Oops: 17 [#6] PREEMPT SMP ARM [ 304.828029] Modules linked in: [ 304.831065] CPU: 0 PID: 2177 Comm: sync Tainted: G D 3.13.0-rc1-00090-gd6eaf98-dirty #141 [ 304.840100] task: ee9aa1c0 ti: ee492000 task.ti: ee492000 [ 304.845479] PC is at ftrace_syscall_enter+0x44/0x17c [ 304.850426] LR is at syscall_trace_enter+0xf8/0x138 [ 304.855284] pc : [<c00ad654>] lr : [<c0010eb0>] psr: a0000013 [ 304.855284] sp : ee493f40 ip : ee493f80 fp : ee493f7c [ 304.866749] r10: 00001400 r9 : ee492000 r8 : c000eea4 [ 304.871950] r7 : ee493fb0 r6 : ee492000 r5 : ffffffff r4 : 000f0005 [ 304.878461] r3 : ee492000 r2 : 000f001d r1 : ee493fb0 r0 : c06cb2f8 [ 304.884972] Flags: NzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 304.892089] Control: 10c5387d Table: 6d9fc06a DAC: 00000015 [ 304.897816] Process sync (pid: 2177, stack limit = 0xee492240) [ 304.903632] Stack: (0xee493f40 to 0xee494000) [ 304.907973] 3f40: ee493fb0 00000000 ee493f8c 00000022 00000003 ede2c490 000f0005 ee492000 [ 304.916137] 3f60: ee493fb0 c000eea4 ee492000 00001400 ee493fa4 ee493f80 c0010eb0 c00ad61c [ 304.924296] 3f80: b6fa8840 b6fa8178 00000001 00000000 000f0005 c000eea4 00000000 ee493fa8 [ 304.932455] 3fa0: c000ee4c c0010dc4 b6fa8178 00000001 b6fa8840 b6fad050 b6fa8f18 b6fa8840 [ 304.940615] 3fc0: b6fa8178 00000001 00000000 000f0005 00000001 00000000 0000b0d8 b6fad958 [ 304.948773] 3fe0: 000f0005 bebbb4a0 b6f8e8fb b6f9e966 80000030 b6fa8840 00000000 00000000 [ 304.956937] [<c00ad654>] (ftrace_syscall_enter+0x44/0x17c) from [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) [ 304.966834] [<c0010eb0>] (syscall_trace_enter+0xf8/0x138) from [<c000ee4c>] (__sys_trace+0xc/0x38) [ 304.975771] Code: e2842018 e7905102 e3550000 0a000038 (e595201c) [ 304.981859] ---[ end trace f8b3633d964e9e65 ]--- [ 304.986451] note: sync[2177] exited with preempt_count 1 Segmentation fault -- viresh

10 years, 11 months

Possible arm64 patches for stable

by Mark Brown

Hi, While reading the kernel logs for arm64 (as one does) I noticed a few patches that seemed like candidates for either LTS or LTSI. I've also had a couple of others mentioned via other routes. What do you think of these? 4ecf7ccb1973 arm64: spinlock: retry trylock operation if strex fails on free lock This seems like a correctness fix for spinlocks, though since the callers should cope with failure it's arguably just an optimisation. 53ae3acd4390 arm64: Only enable local interrupts after the CPU is marked online 82b2f495fba3 arm64: virt: ensure visibility of __boot_cpu_mode 845ad05ec31e arm64: Change kernel stack size to 16K 6db83cea1c97 arm64: fix possible invalid FPSIMD initialization state 7b22c03536a5 arm64: check for number of arguments in syscall_get/set_arguments() df503ba7f653 arm64: dts: Reserve the memory used for secondary CPU release address These all look like correctness fixes of one kind or another; the change to 16K stacks is poorly explained but it looks like it's fixing failures of some kind. f0dd718090ae arm64: Remove unused cpu_name ascii in arch/arm64/mm/proc.S A user was reporting that this caused build failures due to alignment issues with some of the debug options turned on. I've not fully investigated yet, this might be a toolchain issue though given how simple the change is. 0d651e4e65e9 clocksource: arch_timer: use virtual counters This is as mentioned in the changelog a correctness fix for avoiding clocks going backwards and has also been found to be required to avoid boot hangs with CONFIG_PROVE_RCU_DELAY enabled. There were also a few others that aren't entirely -stable material but might be a fit for LTSI (and the above might be if not -stable in themselves): b5b6c9e9149d arm64: Avoid cache flushing in flush_dcache_page() 7249b79f6b4c arm64: Do not flush the D-cache for anonymous pages 4f00130b70e5 arm64: Use Normal NonCacheable memory for writecombine These look like simple, localised optimisations. Thanks, Mark

10 years, 11 months

[PATCH 0/5] armv7 BE kvm support

by Victor Kamensky

Hi Guys, Here is series that enables KVM support for V7 big endian kernels. Mostly it deals with BE KVM host support. Marc Zyngier showed before with his patches how BE guest could run on top LE host. With these patches BE guest runs on top of BE host. If Marc's kvmtool is used with few additional changes I tested that BE host could run LE guest. Also I verified that there were no regressions in BE guest on top of LE host case. Note that posted series covers only kernel side changes. The changes were tested inside of bigger setup with additional changes in qemu and kvmtool. I will post those changes separately in proper aliases but for completeness sake Appendix A gives pointers to git repositories and branches with all needed changes. Please note first patch is not related to BE KVM per se. I've run into an issue of conflicting 'push' identifier use while trying to include assembler.h into KVM .S files. Details of an issue I observed covered in Appendix B. The first patch is my take on solving it. Victor Kamensky (5): ARM: kvm: replace push and pop with stdmb and ldmia instrs to enable assembler.h inclusion ARM: fix KVM assembler files to work in BE case ARM: kvm one_reg coproc set and get BE fixes ARM: kvm vgic mmio should return data in BE format in BE case ARM: kvm MMIO support BE host running LE code arch/arm/include/asm/assembler.h | 7 +++ arch/arm/include/asm/kvm_asm.h | 4 +- arch/arm/include/asm/kvm_emulate.h | 22 +++++++-- arch/arm/kvm/coproc.c | 94 ++++++++++++++++++++++++++++---------- arch/arm/kvm/init.S | 7 ++- arch/arm/kvm/interrupts.S | 50 +++++++++++--------- arch/arm/kvm/interrupts_head.S | 61 +++++++++++++++---------- virt/kvm/arm/vgic.c | 4 +- 8 files changed, 168 insertions(+), 81 deletions(-) -- 1.8.1.4 Thanks, Victor Appendix A: Testing and Full Setup Description ---------------------------------------------- I) No mixed mode setup - i.e BE guest on BE host; and LE guest on LE host tested to make sure no regressions. KVM host and guest kernels: TC2 on top of Linus 3.13-rc4 (this patch series): git: git://git.linaro.org/people/victor.kamensky/linux-linaro-tracking-be.git branch: armv7be-kvm-3.13-rc4 TC2 and Arndale on top of Linaro BE tree: git: git://git.linaro.org/people/victor.kamensky/linux-linaro-tracking-be.git branch: llct-be-20131216-kvm - TC1 kernels used as guests qemu: git: git://git.linaro.org/people/victor.kamensky/qemu-be.git branch: armv7be-v1 description: changes to run qemu on armeb target; and other changes to work with be image on top of be host kvmtool: git: git://git.linaro.org/people/victor.kamensky/linux-linaro-tracking-be.git branch: kvmtool-armv7be-v1 desciption: minimal changes to build kvmtool for armeb target; and tiny change with virtio magic II) Mixed mode setup all possible combinations within V7 (LE guest on BE host; BE guest on LE host as Marc's setup tested to make sure no regressions) only with kvmtool. This work is based on Marc Zyngier's work that made BE guest to run on top of LE host. For this setup special version of kvmtool should be used and in addition I had to apply patch to guest kernel that would switch reading virtio configs reads to be LE only, that is made on top of previous Rusty Russell's changes. Effectively I just had to do very minor addition to make LE guest to work on BE host, most of heavy lifting was done before by Marc. KVM host kernels: as in previous setup Guest TC1 kernels with LE virtio config patch: git: git://git.linaro.org/people/victor.kamensky/linux-linaro-tracking-be.git branch: virtio-leconfig-3.13-rc4 kvmtool: git: git://git.linaro.org/people/victor.kamensky/linux-linaro-tracking-be.git branch: kvmtool-mixed-v1 description: based on git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git branch kvm-arm64/kvmtool-be-on-le; adds missing include fix; above armeb target build patches; and one fix related to BE mode qemu: git: git://git.linaro.org/people/victor.kamensky/qemu-be.git branch: armv7be-leconfig-v1 description: change virtio-blk that so qemu could work with guest image where virtio leconfig is made; note it does not work in mixed mode; to do so qemu would need bunch of similar changes that Marc did in kvmtool Appendix B: kvm asm file and asm/assembler.h file issue ------------------------------------------------------- diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S index ddc1553..5d3b511 100644 --- a/arch/arm/kvm/interrupts.S +++ b/arch/arm/kvm/interrupts.S @@ -25,6 +25,7 @@ #include <asm/kvm_asm.h> #include <asm/kvm_arm.h> #include <asm/vfpmacros.h> +#include <asm/assembler.h> #include "interrupts_head.S" .text produce the following compilation errors: /run/media/kamensky/wd/linaro/linux-linaro-core-tracking/092913/linux-linaro-tracking-be/arch/arm/kvm/interrupts.S: Assembler messages: /run/media/kamensky/wd/linaro/linux-linaro-core-tracking/092913/linux-linaro-tracking-be/arch/arm/kvm/interrupts.S:51: Error: ARM register expected -- `lsr {r2,r3}' /run/media/kamensky/wd/linaro/linux-linaro-core-tracking/092913/linux-linaro-tracking-be/arch/arm/kvm/interrupts.S:100: Error: ARM register expected -- `lsr {r2}' /run/media/kamensky/wd/linaro/linux-linaro-core-tracking/092913/linux-linaro-tracking-be/arch/arm/kvm/interrupts.S:100: Error: ARM register expected -- `lsr {r4-r12}'

10 years, 11 months

[Query] Ticks happen in pair for NO_HZ_FULL cores ?

by Viresh Kumar

Hi Frederic/Kevin, I was doing some work where I was required to use NO_HZ_FULL on core 1 on a dual core ARM machine. I observed that I was able to isolate the second core using cpusets but whenever the tick occurs, it occurs twice. i.e. Timer count gets updated by two every time my core is disturbed. I tried to trace it (output attached) and found this sequence (Talking only about core 1 here): - Single task was running on Core 1 (using cpusets) - got an arch_timer interrupt - started servicing vmstat stuff - so came out of NO_HZ_FULL domain as there is more than one task on Core - queued work again and went to the existing single task (stress) - again got arch_timer interrupt after 5 ms (HZ=200) - got "tick_stop" event and went into NO_HZ_FULL domain again.. - Got isolated again for long duration.. So the query is: why don't we check that at the end of servicing vmstat stuff and migrating back to "stress" ?? Thanks. -- viresh

10 years, 11 months

[PATCH v4 0/5] Hardware Reduced Mode Cleanup for ACPI

by al.stone＠linaro.org

From: Al Stone <al.stone(a)linaro.org> This series of patches starts with Hanjun's patch to create a kernel config item for CONFIG_ACPI_REDUCED_HARDWARE [0]. Building on that, I then reviewed all of the code that touched any of several fields in the FADT that the OSPM is supposed to ignore when ACPI is in Hardware Reduced mode [1]. Any time there was a use of one of the fields to be ignored, I evaluated whether or not the code was implementing Hardware Reduced mode correctly. Similarly, for each the flags in the FADT flags field that are to be ignored in Hardware Reduced mode, the kernel code was again scanned for proper usage. The remainder of the patches are to fix all of the situations I could find where the kernel would not behave correctly in this ACPI mode. These seem to work just fine on the RTSM model for ARMv7, both with and without ACPI enabled, and with and without ACPI_REDUCED_HARDWARE enabled; similarly for the FVP model for ARMv8. The patches for ACPI on ARM hardware have been submitted elsewhere but they presume that reduced HW mode is functioning correctly. In the meantime, there's no way I can think of to test all possible scenarios so feedback would be greatly appreciated. [0] List at https://wiki.linaro.org/LEG/Engineering/Kernel/ACPI/AcpiReducedHw#Section_5… [1] Please see the ACPI Specification v5.0 for details on Hardware Reduced mode (sections 3.11.1, 4.1, 5.2.9, at a minimum). Changes for v4: -- Given the current state of ACPICA, disable CONFIG_ACPI_REDUCED_HARDWARE for use on anything other than ARM. -- Replaced #ifdefs with run-time checking for hardware reduced mode, whenever possible Changes for v3: -- Modified enabling ACPI_REDUCED_HARDWARE in ACPICA when using kernel config item CONFIG_ACPI_REDUCED_HARDWARE; now consistent with ACPICA code base where needed -- Enable X86 for CONFIG_ACPI_REDUCED_HARDWARE -- Minimize bus master reload patching -- Remove unneeded patch for dmi_check_system() (was 4/6) -- Correct the patch for removing unneeded map/unmap of FADT fields Changes for v2: -- Remove patch that was outside of reduced HW mode changes -- Simplify CONFIG_ACPI_REDUCED_HARDWARE in Kconfig -- Simplify use of CONFIG_ACPI_REDUCED_HARDWARE in #ifdefs -- Ensure changelogs are present -- Combine and simplify previous patches 8 & 10 Al Stone (5): ACPI: introduce CONFIG_ACPI_REDUCED_HARDWARE to enable this ACPI mode ACPI: bus master reload not supported in reduced HW mode ACPI: HW reduced mode does not allow use of the FADT sci_interrupt field ACPI: in HW reduced mode, using FADT PM information is not allowed. ACPI: do not map/unmap memory regions for FADT entries in reduced HW mode drivers/acpi/Kconfig | 8 ++++++++ drivers/acpi/bus.c | 30 ++++++++++++++++-------------- drivers/acpi/osl.c | 38 +++++++++++++++++++------------------- drivers/acpi/pci_link.c | 2 ++ drivers/acpi/processor_idle.c | 14 ++++++++++++-- include/acpi/platform/aclinux.h | 6 ++++++ 6 files changed, 63 insertions(+), 35 deletions(-) -- 1.8.3.1

10 years, 11 months

[PATCH 0/4] CPUFreq stats: Bug fixes

by Viresh Kumar

Hi Rafael, I know you asked me not to send any more patches before the earlier ones get into kernel. I got to this as Nicolas Pitre required to send few CPUFreq patches for ARM's big LITTLE In-Kernel-Switcher. And within linaro we have hacked these bugs in a bad way.. Because of his dependency I am forced to send these.. These aren't introduced recently and so they can be included in 3.13. There are several problems/bugs in cpufreq-stats specially with cpufreq drivers as modules and suspend/resume path. These are mentioned well in changelogs. These are tested over my thinkpad (acpi-cpufreq) in following way: [1] offline+online all CPUs except boot cpu in a while loop [2] then do suspend resume [3] repeat [1] and [2] several times. No issues found.. Also tested on my exynos board: - Added cpufreq_unregister/register while loop in exynos-cpufreq.c so that we continuously register/unregister driver... Stats were working fine now.. - Compile cpufreq-stats as module and insert/remove it several times after removing above hack (as that doesn't let linux boot :) ).. @Srivatsa: You also have fairly good idea of cpufreq now, so please give some time to review this :) @Nico: Can you remove the hacky code from IKS tree and test these instead to see if we still have any issues? -- viresh Viresh Kumar (4): cpufreq: stats: handle cpufreq_unregister_driver() and suspend/resume properly cpufreq: stats: remove hotplug notifiers cpufreq: stats: free table and remove sysfs entry in a single routine cpufreq: stats: create sysfs entries when cpufreq_stats is a module drivers/cpufreq/cpufreq.c | 5 ++ drivers/cpufreq/cpufreq_stats.c | 109 ++++++++++++++++++---------------------- include/linux/cpufreq.h | 2 + 3 files changed, 55 insertions(+), 61 deletions(-) -- 1.7.12.rc2.18.g61b472e

10 years, 11 months

[PATCH 0/7] sched: cleanup trigger_load_balance

by Daniel Lezcano

This patchset does a cleanup on the parameters passed from the function 'trigger_load_balance' to the underneath functions. The cpu is passed as parameter to the different functions as well as the struct rq but this one contains already the cpu information. Moreover, in the call stack for these functions, we have the struct rq retrieved from the cpu, and then the cpu retrieve from the struct rq, etc ... The patchset unifies all these functions to have a struct rq parameter and removes the pointless parameters. -static inline int find_new_ilb(int call_cpu) +static inline int find_new_ilb(void) -static void nohz_balancer_kick(int cpu) +static void nohz_balancer_kick(void) -static void rebalance_domains(int cpu, enum cpu_idle_type idle) +static void rebalance_domains(struct rq *rq, enum cpu_idle_type idle) -static void nohz_idle_balance(int this_cpu, enum cpu_idle_type idle) +static void nohz_idle_balance(struct rq *this_rq, enum cpu_idle_type idle) -static inline int nohz_kick_needed(struct rq *rq, int cpu) +static inline int nohz_kick_needed(struct rq *rq) -static inline int on_null_domain(int cpu) +static inline int on_null_domain(struct rq *rq) Daniel Lezcano (7): sched: reduce nohz_kick_needed parameters sched: pass struct rq to on_null_domain function sched: remove unused parameter for find_new_ilb sched: remove unused parameter in nohz_balancer_kick function sched: pass struct rq to rebalance_domains function sched: pass struct rq to nohz_idle_balance function sched: factor out on_null_domain check in trigger_load_balance function kernel/sched/fair.c | 45 ++++++++++++++++++++++----------------------- 1 file changed, 22 insertions(+), 23 deletions(-) -- 1.7.9.5

10 years, 11 months

[RESEND PATCH v2] mfd: twl6030: Fix endianness problem in IRQ handler

by Taras Kondratiuk

From: Danke Xie <d.xie(a)sta.samsung.com> The current TWL 6030 IRQ handler assumes little endianness. This change makes it endian-neutral. Signed-off-by: Danke Xie <d.xie(a)sta.samsung.com> Signed-off-by: Taras Kondratiuk <taras.kondratiuk(a)linaro.org> --- v2: fixed sparse warning v1: https://patchwork.kernel.org/patch/2974331/ drivers/mfd/twl6030-irq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c index 517eda8..18a607e 100644 --- a/drivers/mfd/twl6030-irq.c +++ b/drivers/mfd/twl6030-irq.c @@ -176,8 +176,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data) int i, ret; union { u8 bytes[4]; - u32 int_sts; + __le32 int_sts; } sts; + u32 int_sts; /* sts.int_sts converted to CPU endianness */ struct twl6030_irq *pdata = data; /* read INT_STS_A, B and C in one shot using a burst read */ @@ -196,8 +197,9 @@ static irqreturn_t twl6030_irq_thread(int irq, void *data) if (sts.bytes[2] & 0x10) sts.bytes[2] |= 0x08; - for (i = 0; sts.int_sts; sts.int_sts >>= 1, i++) - if (sts.int_sts & 0x1) { + int_sts = le32_to_cpu(sts.int_sts); + for (i = 0; int_sts; int_sts >>= 1, i++) + if (int_sts & 0x1) { int module_irq = irq_find_mapping(pdata->irq_domain, pdata->irq_mapping_tbl[i]); -- 1.7.9.5

10 years, 11 months

[PATCH V2 1/5] cpufreq: Introduce cpufreq_notify_post_transition()

by Viresh Kumar

This introduces another routine cpufreq_notify_post_transition() which can be used to send POSTCHANGE notification for new freq with or without both {PRE|POST}CHANGE notifications for last freq. This is useful at multiple places, specially for sending transition failure notifications. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- V1->V2: - Not required to push it for 3.13 anymore and can go in 3.14. - Rebased over following patchset as there were conflicts in unicore2 driver if following patchset is applied first (which should be the case): https://lkml.org/lkml/2013/10/30/553 (create cpufreq_generic_get() routine) drivers/cpufreq/cpufreq.c | 14 ++++++++++++++ include/linux/cpufreq.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 5e27def..3b877d4 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -338,6 +338,20 @@ void cpufreq_notify_transition(struct cpufreq_policy *policy, } EXPORT_SYMBOL_GPL(cpufreq_notify_transition); +/* Do post notifications when there are chances that transition has failed */ +void cpufreq_notify_post_transition(struct cpufreq_policy *policy, + struct cpufreq_freqs *freqs, int transition_failed) +{ + cpufreq_notify_transition(policy, freqs, CPUFREQ_POSTCHANGE); + if (!transition_failed) + return; + + swap(freqs->old, freqs->new); + cpufreq_notify_transition(policy, freqs, CPUFREQ_PRECHANGE); + cpufreq_notify_transition(policy, freqs, CPUFREQ_POSTCHANGE); +} +EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition); + /********************************************************************* * SYSFS INTERFACE * diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 276e646..b26bfab 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -316,6 +316,8 @@ int cpufreq_unregister_notifier(struct notifier_block *nb, unsigned int list); void cpufreq_notify_transition(struct cpufreq_policy *policy, struct cpufreq_freqs *freqs, unsigned int state); +void cpufreq_notify_post_transition(struct cpufreq_policy *policy, + struct cpufreq_freqs *freqs, int transition_failed); #else /* CONFIG_CPU_FREQ */ static inline int cpufreq_register_notifier(struct notifier_block *nb, -- 1.7.12.rc2.18.g61b472e

10 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel December 2013