linaro-kernel February 2016

linaro-kernel@lists.linaro.org

64 participants
155 discussions

[LSK-v4.1 PATCH] ARM: 8464/1: Update all mm structures with section adjustments

by David Brown

From: Laura Abbott <labbott(a)redhat.com> commit 08925c2f124f1bac6152a8b234268f9874fc70a5 upstream. Currently, when updating section permissions to mark areas RO or NX, the only mm updated is current->mm. This is working off the assumption that there are no additional mm structures at the time. This may not always hold true. (Example: calling modprobe early will trigger a fork/exec). Ensure all mm structres get updated with the new section information. Reviewed-by: Kees Cook <keescook(a)chromium.org> Signed-off-by: Laura Abbott <labbott(a)fedoraproject.org> Signed-off-by: Russell King <rmk+kernel(a)arm.linux.org.uk> Signed-off-by: David Brown <david.brown(a)linaro.org> --- (resending with proper branch in subject) Bringing in this fix allows CONFIG_DEBUG_RODATA to work on ARM. With this patch, and this config enabled: echo WRITE_RO > /sys/kernel/debug/provoke-crash/DIRECT will provoke and exception. arch/arm/mm/init.c | 92 ++++++++++++++++++++++++++++++++++++------------------ 1 file changed, 62 insertions(+), 30 deletions(-) diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c index be92fa0..8d32f7e 100644 --- a/arch/arm/mm/init.c +++ b/arch/arm/mm/init.c @@ -22,6 +22,7 @@ #include <linux/memblock.h> #include <linux/dma-contiguous.h> #include <linux/sizes.h> +#include <linux/stop_machine.h> #include <asm/cp15.h> #include <asm/mach-types.h> @@ -626,12 +627,10 @@ static struct section_perm ro_perms[] = { * safe to be called with preemption disabled, as under stop_machine(). */ static inline void section_update(unsigned long addr, pmdval_t mask, - pmdval_t prot) + pmdval_t prot, struct mm_struct *mm) { - struct mm_struct *mm; pmd_t *pmd; - mm = current->active_mm; pmd = pmd_offset(pud_offset(pgd_offset(mm, addr), addr), addr); #ifdef CONFIG_ARM_LPAE @@ -655,49 +654,82 @@ static inline bool arch_has_strict_perms(void) return !!(get_cr() & CR_XP); } -#define set_section_perms(perms, field) { \ - size_t i; \ - unsigned long addr; \ - \ - if (!arch_has_strict_perms()) \ - return; \ - \ - for (i = 0; i < ARRAY_SIZE(perms); i++) { \ - if (!IS_ALIGNED(perms[i].start, SECTION_SIZE) || \ - !IS_ALIGNED(perms[i].end, SECTION_SIZE)) { \ - pr_err("BUG: section %lx-%lx not aligned to %lx\n", \ - perms[i].start, perms[i].end, \ - SECTION_SIZE); \ - continue; \ - } \ - \ - for (addr = perms[i].start; \ - addr < perms[i].end; \ - addr += SECTION_SIZE) \ - section_update(addr, perms[i].mask, \ - perms[i].field); \ - } \ +void set_section_perms(struct section_perm *perms, int n, bool set, + struct mm_struct *mm) +{ + size_t i; + unsigned long addr; + + if (!arch_has_strict_perms()) + return; + + for (i = 0; i < n; i++) { + if (!IS_ALIGNED(perms[i].start, SECTION_SIZE) || + !IS_ALIGNED(perms[i].end, SECTION_SIZE)) { + pr_err("BUG: section %lx-%lx not aligned to %lx\n", + perms[i].start, perms[i].end, + SECTION_SIZE); + continue; + } + + for (addr = perms[i].start; + addr < perms[i].end; + addr += SECTION_SIZE) + section_update(addr, perms[i].mask, + set ? perms[i].prot : perms[i].clear, mm); + } + } -static inline void fix_kernmem_perms(void) +static void update_sections_early(struct section_perm perms[], int n) { - set_section_perms(nx_perms, prot); + struct task_struct *t, *s; + + read_lock(&tasklist_lock); + for_each_process(t) { + if (t->flags & PF_KTHREAD) + continue; + for_each_thread(t, s) + set_section_perms(perms, n, true, s->mm); + } + read_unlock(&tasklist_lock); + set_section_perms(perms, n, true, current->active_mm); + set_section_perms(perms, n, true, &init_mm); +} + +int __fix_kernmem_perms(void *unused) +{ + update_sections_early(nx_perms, ARRAY_SIZE(nx_perms)); + return 0; +} + +void fix_kernmem_perms(void) +{ + stop_machine(__fix_kernmem_perms, NULL, NULL); } #ifdef CONFIG_DEBUG_RODATA +int __mark_rodata_ro(void *unused) +{ + update_sections_early(ro_perms, ARRAY_SIZE(ro_perms)); + return 0; +} + void mark_rodata_ro(void) { - set_section_perms(ro_perms, prot); + stop_machine(__mark_rodata_ro, NULL, NULL); } void set_kernel_text_rw(void) { - set_section_perms(ro_perms, clear); + set_section_perms(ro_perms, ARRAY_SIZE(ro_perms), false, + current->active_mm); } void set_kernel_text_ro(void) { - set_section_perms(ro_perms, prot); + set_section_perms(ro_perms, ARRAY_SIZE(ro_perms), true, + current->active_mm); } #endif /* CONFIG_DEBUG_RODATA */ -- 2.7.0

9 years, 2 months

[GIT PULL] [lsk-v3.14-android] linaro-android-3.14 topic branch updates for 16.02

by Amit Pundir

Hi Mark, Alex, Please consider following linaro-android pull request for "linux-linaro-lsk-v3.14-android" LSK branch for 16.02. This pull request contain patches cherry-picked from android-3.14 branch of https://android.googlesource.com/kernel/common and few linaro-android fixes already submitted to AOSP gerrit for review. android-3.14 test merge into lsk-v3.14-android branch had quiet a few complicated merge conflicts and it was easier to just cherry-pick the AOSP only changes for this pull request and skip the upstream/backported patches from AOSP which are already pulled by LTS. Regards, Amit Pundir The following changes since commit 2f0fc7f6a245e841487908cabe2648fe19e133aa: Merge branch 'linux-linaro-lsk-v3.14' into linux-linaro-lsk-v3.14-android (2016-02-10 18:21:50 +0000) are available in the git repository at: git://android.git.linaro.org/kernel/linaro-android.git lsk-v3.14-android for you to fetch changes up to 7eff2ffe05a8b2c6c83a4f511ac6c31c858e3048: Revert "usb: gadget: composite: Fix corruption when changing configuration" (2016-02-12 20:13:36 +0530) ---------------------------------------------------------------- Amit Pundir (4): Revert "net: wireless: Add CONFIG_WIFI_CONTROL_FUNC option" usb: gadget: rndis: use %z format specifier for size_t Revert "HID: Add input_register callback." Revert "usb: gadget: composite: Fix corruption when changing configuration" Aniroop Mathur (1): Input: initialize device counter variables with -1 Benjamin Valentin (1): Input: xpad - sync device IDs with xboxdrv Dario Scarpa (1): Input: xpad - fix Razer Atrox Arcade Stick button mapping Dmitry Torokhov (1): UPSTREAM: HID: hid-input: allow input_configured callback return errors Erik Lundgren (1): Input: xpad - add Covert Forces edition of the Xbox One controller Frank Razenberg (1): Input: xpad - add VID/PID for Razer Sabertooth Jingoo Han (1): UPSTREAM: rtc: rtc-palmas: make of_device_id array const Kees Cook (1): UPSTREAM: seccomp: cap SECCOMP_RET_ERRNO data to MAX_ERRNO Mark Salyzyn (3): ANDROID: rtc-palmas: correct for bcd year android: recommended.cfg: enable taskstats android: base-cfg: Add CONFIG_IP_MULTICAST Minchan Kim (1): BACKPORT: mm: /proc/pid/smaps:: show proportional swap share of the mapping Ming-ting Yao Wei (1): Input: xpad - add rumble support for Xbox One controller Oleg Nesterov (1): UPSTREAM: proc: actually make proc_fd_permission() thread-friendly Pavel Rojtberg (8): Input: xpad - re-send LED command on present event Input: xpad - clarify LED enumeration Input: xpad - use ida() for finding the pad_nr Input: xpad - remove needless bulk out URB used for LED setup Input: xpad - factor out URB submission in xpad_play_effect Input: xpad - x360w: report dpad as buttons and axes Input: xpad - query wireless controller state at init Input: xpad - fix clash of presence handling with LED setting Pierre-Loup A. Griffais (2): Input: xpad - set the LEDs properly on XBox Wireless controllers Input: xpad - move the input device creation to a new function Stephen Smalley (1): UPSTREAM: selinux: fix bug in conditional rules handling Ted Mielczarek (1): Input: xpad - add support for Xbox One controllers Tommi Rantala (2): Input: xpad - add USB ID for Thrustmaster Ferrari 458 Racing Wheel Input: xpad - add Thrustmaster as Xbox 360 controller vendor Vasily Kulikov (1): UPSTREAM: include/linux/poison.h: fix LIST_POISON{1,2} offset Vlastimil Babka (2): UPSTREAM: mm: always steal split buddies in fallback allocations UPSTREAM: mm: more aggressive page stealing for UNMOVABLE allocations dcashman (6): Revert "arm: mm: support ARCH_MMAP_RND_BITS." Revert "mm: mmap: Add new /proc tunable for mmap_base ASLR." FROMLIST: mm: mmap: Add new /proc tunable for mmap_base ASLR. FROMLIST: arm: mm: support ARCH_MMAP_RND_BITS. BACKPORT: FROMLIST: arm64: mm: support ARCH_MMAP_RND_BITS. FROMLIST: x86: mm: support ARCH_MMAP_RND_BITS. Documentation/filesystems/proc.txt | 18 ++- Documentation/sysctl/kernel.txt | 14 -- Documentation/sysctl/vm.txt | 29 ++++ android/configs/android-base.cfg | 1 + android/configs/android-recommended.cfg | 4 + arch/Kconfig | 68 ++++++++++ arch/arm/Kconfig | 23 +--- arch/arm/mm/mmap.c | 6 +- arch/arm64/Kconfig | 21 +++ arch/arm64/mm/mmap.c | 11 +- arch/x86/Kconfig | 16 +++ arch/x86/mm/mmap.c | 12 +- drivers/hid/hid-appleir.c | 4 +- drivers/hid/hid-elo.c | 4 +- drivers/hid/hid-magicmouse.c | 8 +- drivers/hid/hid-multitouch.c | 10 +- drivers/hid/hid-ntrig.c | 6 +- drivers/input/gameport/gameport.c | 4 +- drivers/input/joystick/xpad.c | 773 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------- drivers/input/misc/ims-pcu.c | 4 +- drivers/input/serio/serio.c | 4 +- drivers/input/serio/serio_raw.c | 4 +- drivers/net/wireless/Kconfig | 5 - drivers/rtc/rtc-palmas.c | 46 ++++++- drivers/usb/gadget/composite.c | 10 +- drivers/usb/gadget/rndis.c | 2 +- fs/proc/fd.c | 14 +- fs/proc/task_mmu.c | 20 ++- include/linux/mm.h | 13 +- include/linux/poison.h | 4 +- include/linux/swap.h | 6 + kernel/seccomp.c | 4 +- kernel/sysctl.c | 33 +++-- mm/mmap.c | 12 ++ mm/page_alloc.c | 72 +++++----- mm/swapfile.c | 42 ++++++ security/selinux/ss/conditional.c | 4 +- 37 files changed, 935 insertions(+), 396 deletions(-)

9 years, 2 months

[PATCH] trace, kasan: silence Kasan warning in check_stack

by Yang Shi

When enabling stack trace via "echo 1 > /proc/sys/kernel/stack_tracer_enabled", the below KASAN warning is triggered: BUG: KASAN: stack-out-of-bounds in check_stack+0x344/0x848 at addr ffffffc0689ebab8 Read of size 8 by task ksoftirqd/4/29 page:ffffffbdc3a27ac0 count:0 mapcount:0 mapping: (null) index:0x0 flags: 0x0() page dumped because: kasan: bad access detected CPU: 4 PID: 29 Comm: ksoftirqd/4 Not tainted 4.5.0-rc1 #129 Hardware name: Freescale Layerscape 2085a RDB Board (DT) Call trace: [<ffffffc000091300>] dump_backtrace+0x0/0x3a0 [<ffffffc0000916c4>] show_stack+0x24/0x30 [<ffffffc0009bbd78>] dump_stack+0xd8/0x168 [<ffffffc000420bb0>] kasan_report_error+0x6a0/0x920 [<ffffffc000421688>] kasan_report+0x70/0xb8 [<ffffffc00041f7f0>] __asan_load8+0x60/0x78 [<ffffffc0002e05c4>] check_stack+0x344/0x848 [<ffffffc0002e0c8c>] stack_trace_call+0x1c4/0x370 [<ffffffc0002af558>] ftrace_ops_no_ops+0x2c0/0x590 [<ffffffc00009f25c>] ftrace_graph_call+0x0/0x14 [<ffffffc0000881bc>] fpsimd_thread_switch+0x24/0x1e8 [<ffffffc000089864>] __switch_to+0x34/0x218 [<ffffffc0011e089c>] __schedule+0x3ac/0x15b8 [<ffffffc0011e1f6c>] schedule+0x5c/0x178 [<ffffffc0001632a8>] smpboot_thread_fn+0x350/0x960 [<ffffffc00015b518>] kthread+0x1d8/0x2b0 [<ffffffc0000874d0>] ret_from_fork+0x10/0x40 Memory state around the buggy address: ffffffc0689eb980: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 f4 f4 f4 ffffffc0689eba00: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00 >ffffffc0689eba80: 00 00 f1 f1 f1 f1 00 f4 f4 f4 f3 f3 f3 f3 00 00 ^ ffffffc0689ebb00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ffffffc0689ebb80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 The stacker tracer traverses the whole kernel stack when saving the max stack trace. It may touch the stack red zones to cause the warning. So, just disable the instrumentation to silence the warning. Signed-off-by: Yang Shi <yang.shi(a)linaro.org> --- kernel/trace/trace_stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_stack.c b/kernel/trace/trace_stack.c index 202df6c..61e5e1e 100644 --- a/kernel/trace/trace_stack.c +++ b/kernel/trace/trace_stack.c @@ -156,7 +156,7 @@ check_stack(unsigned long ip, unsigned long *stack) for (; p < top && i < stack_trace_max.nr_entries; p++) { if (stack_dump_trace[i] == ULONG_MAX) break; - if (*p == stack_dump_trace[i]) { + if ((READ_ONCE_NOCHECK(*p)) == stack_dump_trace[i]) { stack_dump_trace[x] = stack_dump_trace[i++]; this_size = stack_trace_index[x++] = (top - p) * sizeof(unsigned long); -- 2.0.2

9 years, 2 months

[PATCH] arm64: make irq_stack_ptr more robust

by Yang Shi

Switching between stacks is only valid if we are tracing ourselves while on the irq_stack, so it is only valid when in current and non-preemptible context, otherwise is is just zeroed off. Signed-off-by: Yang Shi <yang.shi(a)linaro.org> --- arch/arm64/kernel/stacktrace.c | 13 ++++++------- arch/arm64/kernel/traps.c | 11 ++++++++++- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 12a18cb..d9751a4 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -44,14 +44,13 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame) unsigned long irq_stack_ptr; /* - * Use raw_smp_processor_id() to avoid false-positives from - * CONFIG_DEBUG_PREEMPT. get_wchan() calls unwind_frame() on sleeping - * task stacks, we can be pre-empted in this case, so - * {raw_,}smp_processor_id() may give us the wrong value. Sleeping - * tasks can't ever be on an interrupt stack, so regardless of cpu, - * the checks will always fail. + * Switching between stacks is valid when tracing current and in + * non-preemptible context. */ - irq_stack_ptr = IRQ_STACK_PTR(raw_smp_processor_id()); + if (tsk == current && !preemptible()) + irq_stack_ptr = IRQ_STACK_PTR(smp_processor_id()); + else + irq_stack_ptr = 0; low = frame->sp; /* irq stacks are not THREAD_SIZE aligned */ diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index cbedd72..7d8db3a 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -146,9 +146,18 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) static void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk) { struct stackframe frame; - unsigned long irq_stack_ptr = IRQ_STACK_PTR(smp_processor_id()); + unsigned long irq_stack_ptr; int skip; + /* + * Switching between stacks is valid when tracing current and in + * non-preemptible context. + */ + if (tsk == current && !preemptible()) + irq_stack_ptr = IRQ_STACK_PTR(smp_processor_id()); + else + irq_stack_ptr = 0; + pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk); if (!tsk) -- 2.0.2

9 years, 2 months

next-20160212 build: 2 failures 13 warnings (next-20160212)

by Build bot for Mark Brown

Tree/Branch: next-20160212 Git describe: next-20160212 Commit: 64d9a3617b Add linux-next specific files for 20160212 Build Time: 74 min 37 sec Passed: 7 / 9 ( 77.78 %) Failed: 2 / 9 ( 22.22 %) Errors: 11 Warnings: 13 Section Mismatches: 1 Failed defconfigs: arm64-allmodconfig Errors: arm64-allmodconfig ERROR: "msi_create_irq_domain" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "irq_chip_mask_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "free_msi_entry" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_domain_alloc_irqs" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "of_msi_get_domain" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "irq_chip_eoi_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_domain_set_affinity" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_get_domain_info" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_domain_free_irqs" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "alloc_msi_entry" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "irq_chip_unmask_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 2 warnings 2 mismatches : arm64-allmodconfig 4 warnings 0 mismatches : arm-multi_v7_defconfig 7 warnings 0 mismatches : arm-allmodconfig 6 warnings 0 mismatches : arm64-defconfig ------------------------------------------------------------------------------- Errors summary: 11 1 ERROR: "of_msi_get_domain" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "msi_get_domain_info" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "msi_domain_set_affinity" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "msi_domain_free_irqs" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "msi_domain_alloc_irqs" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "msi_create_irq_domain" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "irq_chip_unmask_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "irq_chip_mask_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "irq_chip_eoi_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "free_msi_entry" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! 1 ERROR: "alloc_msi_entry" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! Warnings Summary: 13 2 ../net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable] 2 ../net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable] 2 ../net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable] 2 ../net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable] 2 ../include/linux/kernel.h:754:17: warning: comparison of distinct pointer types lacks a cast 2 ../drivers/spi/spi.c:2279:9: warning: format '%i' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=] 1 ../lib/lz4/lz4hc_compress.c:514:1: warning: the frame size of 1472 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1 ../include/asm-generic/div64.h:224:22: warning: passing argument 1 of '__div64_32' from incompatible pointer type [-Wincompatible-pointer-types] 1 ../include/asm-generic/div64.h:220:25: warning: right shift count >= width of type [-Wshift-count-overflow] 1 ../include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast 1 ../drivers/ntb/test/ntb_perf.c:214:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1 ../drivers/ntb/test/ntb_perf.c:213:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1 ../drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] Section Mismatch Summary: 1 2 WARNING: drivers/staging/fsl-mc/bus/mc-bus-driver.o(.init.text+0x198): Section mismatch in reference from the function init_module() to the function .exit.text:fsl_mc_allocator_driver_exit() =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm64-allmodconfig : FAIL, 11 errors, 2 warnings, 2 section mismatches Errors: ERROR: "msi_create_irq_domain" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "irq_chip_mask_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "free_msi_entry" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_domain_alloc_irqs" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "of_msi_get_domain" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "irq_chip_eoi_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_domain_set_affinity" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_get_domain_info" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "msi_domain_free_irqs" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "alloc_msi_entry" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! ERROR: "irq_chip_unmask_parent" [drivers/staging/fsl-mc/bus/mc-bus-driver.ko] undefined! Warnings: ../drivers/spi/spi.c:2279:9: warning: format '%i' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=] ../include/linux/kernel.h:754:17: warning: comparison of distinct pointer types lacks a cast Section Mismatches: WARNING: drivers/staging/fsl-mc/bus/mc-bus-driver.o(.init.text+0x198): Section mismatch in reference from the function init_module() to the function .exit.text:fsl_mc_allocator_driver_exit() WARNING: drivers/staging/fsl-mc/bus/mc-bus-driver.o(.init.text+0x198): Section mismatch in reference from the function init_module() to the function .exit.text:fsl_mc_allocator_driver_exit() ------------------------------------------------------------------------------- arm-multi_v7_defconfig : PASS, 0 errors, 4 warnings, 0 section mismatches Warnings: ../net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable] ../net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable] ../net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable] ../net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable] ------------------------------------------------------------------------------- arm-allmodconfig : PASS, 0 errors, 7 warnings, 0 section mismatches Warnings: ../lib/lz4/lz4hc_compress.c:514:1: warning: the frame size of 1472 bytes is larger than 1024 bytes [-Wframe-larger-than=] ../include/asm-generic/div64.h:207:28: warning: comparison of distinct pointer types lacks a cast ../include/asm-generic/div64.h:220:25: warning: right shift count >= width of type [-Wshift-count-overflow] ../include/asm-generic/div64.h:224:22: warning: passing argument 1 of '__div64_32' from incompatible pointer type [-Wincompatible-pointer-types] ../drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] ../drivers/ntb/test/ntb_perf.c:213:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../drivers/ntb/test/ntb_perf.c:214:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ------------------------------------------------------------------------------- arm64-defconfig : PASS, 0 errors, 6 warnings, 0 section mismatches Warnings: ../net/ipv4/igmp.c:1227:14: warning: unused variable 'net' [-Wunused-variable] ../net/ipv4/igmp.c:1319:14: warning: unused variable 'net' [-Wunused-variable] ../net/ipv4/igmp.c:1646:14: warning: unused variable 'net' [-Wunused-variable] ../net/ipv4/igmp.c:1665:14: warning: unused variable 'net' [-Wunused-variable] ../drivers/spi/spi.c:2279:9: warning: format '%i' expects argument of type 'int', but argument 4 has type 'size_t {aka long unsigned int}' [-Wformat=] ../include/linux/kernel.h:754:17: warning: comparison of distinct pointer types lacks a cast ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: x86_64-allnoconfig arm64-allnoconfig arm-allnoconfig arm-multi_v5_defconfig x86_64-defconfig

9 years, 2 months

master build: 0 failures 5 warnings (v4.5-rc3-83-gc05235d)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.5-rc3-83-gc05235d Commit: c05235d50f Merge tag 'gpio-v4.5-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio Build Time: 82 min 55 sec Passed: 9 / 9 (100.00 %) Failed: 0 / 9 ( 0.00 %) Errors: 0 Warnings: 5 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 1 warnings 0 mismatches : arm64-allmodconfig 1 warnings 0 mismatches : arm-multi_v7_defconfig 5 warnings 0 mismatches : arm-allmodconfig 1 warnings 0 mismatches : arm64-defconfig ------------------------------------------------------------------------------- Warnings Summary: 5 4 ../drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable] 1 ../lib/lz4/lz4hc_compress.c:514:1: warning: the frame size of 1472 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1 ../drivers/ntb/test/ntb_perf.c:214:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1 ../drivers/ntb/test/ntb_perf.c:213:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 1 ../drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm64-allmodconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable] ------------------------------------------------------------------------------- arm-multi_v7_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable] ------------------------------------------------------------------------------- arm-allmodconfig : PASS, 0 errors, 5 warnings, 0 section mismatches Warnings: ../lib/lz4/lz4hc_compress.c:514:1: warning: the frame size of 1472 bytes is larger than 1024 bytes [-Wframe-larger-than=] ../drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] ../drivers/ntb/test/ntb_perf.c:213:10: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../drivers/ntb/test/ntb_perf.c:214:14: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] ../drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable] ------------------------------------------------------------------------------- arm64-defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: ../drivers/tty/serial/amba-pl011.c:190:27: warning: 'vendor_zte' defined but not used [-Wunused-variable] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: x86_64-allnoconfig arm64-allnoconfig arm-allnoconfig arm-multi_v5_defconfig x86_64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

9 years, 2 months

[PATCH V5 0/6] cpufreq: Locking fixes and cleanups

by Viresh Kumar

Hi Rafael, These are rest of the patches that fix some more locking issues with policy->rwsem and do some minor optimization/cleanups. V4->V5: - Changelog updated for 1-2 as suggested by Rafael - 4th patch is dropped, which moved common tunable callbacks to cpufreq_governor.c - 5-7 are resend on the V5 sent earlier, as reply to V4 of the series. Viresh Kumar (6): cpufreq: Merge cpufreq_offline_prepare/finish routines cpufreq: Call __cpufreq_governor() with policy->rwsem held cpufreq: Remove cpufreq_governor_lock cpufreq: governor: No need to manage state machine now cpufreq: conservative: Update sample_delay_ns immediately cpufreq: ondemand: Rearrange od_dbs_timer() to avoid updating delay drivers/cpufreq/cpufreq.c | 93 ++++++++++++++++------------------ drivers/cpufreq/cpufreq_conservative.c | 14 ----- drivers/cpufreq/cpufreq_governor.c | 90 ++++++++++++++++++++++++-------- drivers/cpufreq/cpufreq_governor.h | 3 +- drivers/cpufreq/cpufreq_ondemand.c | 78 ++-------------------------- 5 files changed, 117 insertions(+), 161 deletions(-) -- 2.7.1.370.gb2aa7f8

9 years, 2 months

[PATCH] PM / OPP: Fix NULL pointer dereference when no regulator is defined

by Bartlomiej Zolnierkiewicz

Commit 7d34d56ef334 ("PM / OPP: Disable OPPs that aren't supported by the regulator") causes NULL pointer dereference OOPS when no regulator for OPP is defined. Fix it by replacing IS_ERR() check with IS_ERR_OR_NULL() one (since providing regulator for OPP is optional). Cc: Viresh Kumar <viresh.kumar(a)linaro.org> Cc: Stephen Boyd <sboyd(a)codeaurora.org> Cc: Rafael J. Wysocki <rafael.j.wysocki(a)intel.com> Fixes: 7d34d56ef334 ("PM / OPP: Disable OPPs that aren't supported by the regulator") Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie(a)samsung.com> --- This fixes linux-pm/linux-next tree boot hang regression on Exynos4412 SoC based Odroid-U3 board. Rafael, please apply. Thank you! drivers/base/power/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index ab711c2..d7cd4e2 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -975,7 +975,7 @@ static bool _opp_supported_by_regulators(struct dev_pm_opp *opp, { struct regulator *reg = dev_opp->regulator; - if (!IS_ERR(reg) && + if (!IS_ERR_OR_NULL(reg) && !regulator_is_supported_voltage(reg, opp->u_volt_min, opp->u_volt_max)) { pr_warn("%s: OPP minuV: %lu maxuV: %lu, not supported by regulator\n", -- 1.9.1

9 years, 2 months

[PATCH] arm64: use raw_smp_processor_id in stack backtrace dump

by Yang Shi

dump_backtrace may be called in kthread context, which is not bound to a single cpu, i.e. khungtaskd, then calling smp_processor_id may trigger the below bug report: BUG: using smp_processor_id() in preemptible [00000000] code: khungtaskd/71 caller is debug_smp_processor_id+0x1c/0x28 CPU: 3 PID: 71 Comm: khungtaskd Not tainted 4.5.0-rc1 #144 Hardware name: Freescale Layerscape 2085a RDB Board (DT) Call trace: [<ffffffc00008d120>] dump_backtrace+0x0/0x290 [<ffffffc00008d3d4>] show_stack+0x24/0x30 [<ffffffc0006bfd1c>] dump_stack+0x8c/0xd8 [<ffffffc0006fe56c>] check_preemption_disabled+0x184/0x188 [<ffffffc0006fe58c>] debug_smp_processor_id+0x1c/0x28 [<ffffffc00008d1a4>] dump_backtrace+0x84/0x290 [<ffffffc00008d3d4>] show_stack+0x24/0x30 [<ffffffc00012aa5c>] sched_show_task+0x16c/0x280 [<ffffffc0001f3df8>] watchdog+0x560/0x708 [<ffffffc000111bb8>] kthread+0x1b0/0x1d0 [<ffffffc0000864d0>] ret_from_fork+0x10/0x40 Replace it to raw version to prevent from the race condition. Signed-off-by: Yang Shi <yang.shi(a)linaro.org> --- arch/arm64/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index cbedd72..9abe236 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -146,7 +146,7 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) static void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk) { struct stackframe frame; - unsigned long irq_stack_ptr = IRQ_STACK_PTR(smp_processor_id()); + unsigned long irq_stack_ptr = IRQ_STACK_PTR(raw_smp_processor_id()); int skip; pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk); -- 2.0.2

9 years, 2 months

[PATCH] arm64: reenable interrupt when handling ptrace breakpoint

by Yang Shi

The kernel just send out a SIGTRAP signal when handling ptrace breakpoint in debug exception, so it sounds safe to have interrupt enabled if it is not disabled by the parent process. Signed-off-by: Yang Shi <yang.shi(a)linaro.org> --- arch/arm64/kernel/debug-monitors.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/kernel/debug-monitors.c b/arch/arm64/kernel/debug-monitors.c index 8aee3ae..90d70e4 100644 --- a/arch/arm64/kernel/debug-monitors.c +++ b/arch/arm64/kernel/debug-monitors.c @@ -239,6 +239,9 @@ static int single_step_handler(unsigned long addr, unsigned int esr, return 0; if (user_mode(regs)) { + if (interrupts_enabled(regs)) + local_irq_enable(); + info.si_signo = SIGTRAP; info.si_errno = 0; info.si_code = TRAP_HWBKPT; @@ -310,6 +313,9 @@ static int brk_handler(unsigned long addr, unsigned int esr, siginfo_t info; if (user_mode(regs)) { + if (interrupts_enabled(regs)) + local_irq_enable(); + info = (siginfo_t) { .si_signo = SIGTRAP, .si_errno = 0, @@ -337,6 +343,10 @@ int aarch32_break_handler(struct pt_regs *regs) if (!compat_user_mode(regs)) return -EFAULT; + /* COMPAT_PSR_I_BIT has the same bit mask with non-compat one */ + if (interrupts_enabled(regs)) + local_irq_enable(); + if (compat_thumb_mode(regs)) { /* get 16-bit Thumb instruction */ get_user(thumb_instr, (u16 __user *)pc); -- 2.0.2

9 years, 2 months

← Newer
1
...
8
9
10
11
12
13
14
15
16
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel February 2016