linaro-kernel

linaro-kernel@lists.linaro.org

10095 discussions

[PATCH V3] ARM: trace: Add tracepoint for the Inter Processor Interrupt

by Daniel Lezcano

The Inter Processor Interrupt is used on ARM to tell another processor to do a specific action. This is mainly used to emulate a timer interrupt on an idle cpu, force a cpu to reschedule or run a function on another processor context. Add a tracepoint when raising an IPI and in the entry/exit handler functions. When a cpu raises an IPI, the targeted cpus is an interesting information, the cpumask conversion in hexa is added in the trace using the cpumask_scnprintf function. Tested-on Vexpress TC2 (5 processors). Tested-on u8500 (2 processors). Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- arch/arm/include/asm/smp.h | 9 ++++ arch/arm/kernel/smp.c | 34 +++++++------ arch/arm64/include/asm/smp.h | 7 +++ arch/arm64/kernel/smp.c | 21 ++++++-- include/trace/events/ipi.h | 112 ++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 164 insertions(+), 19 deletions(-) create mode 100644 include/trace/events/ipi.h diff --git a/arch/arm/include/asm/smp.h b/arch/arm/include/asm/smp.h index a8cae71c..788706c 100644 --- a/arch/arm/include/asm/smp.h +++ b/arch/arm/include/asm/smp.h @@ -18,6 +18,15 @@ # error "<asm/smp.h> included in non-SMP build" #endif +enum ipi_msg_type { + IPI_WAKEUP, + IPI_TIMER, + IPI_RESCHEDULE, + IPI_CALL_FUNC, + IPI_CALL_FUNC_SINGLE, + IPI_CPU_STOP, +}; + #define raw_smp_processor_id() (current_thread_info()->cpu) struct seq_file; diff --git a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c index 72024ea..9ca8ce8 100644 --- a/arch/arm/kernel/smp.c +++ b/arch/arm/kernel/smp.c @@ -46,6 +46,9 @@ #include <asm/mach/arch.h> #include <asm/mpu.h> +#define CREATE_TRACE_POINTS +#include <trace/events/ipi.h> + /* * as from 2.5, kernels no longer have an init_tasks structure * so we need some other way of telling a new secondary core @@ -59,15 +62,6 @@ struct secondary_data secondary_data; */ volatile int pen_release = -1; -enum ipi_msg_type { - IPI_WAKEUP, - IPI_TIMER, - IPI_RESCHEDULE, - IPI_CALL_FUNC, - IPI_CALL_FUNC_SINGLE, - IPI_CPU_STOP, -}; - static DECLARE_COMPLETION(cpu_running); static struct smp_operations smp_ops; @@ -433,19 +427,25 @@ void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int)) smp_cross_call = fn; } +static void ipi_raise(const struct cpumask *mask, int ipinr) +{ + trace_ipi_raise(mask, ipinr); + smp_cross_call(mask, ipinr); +} + void arch_send_call_function_ipi_mask(const struct cpumask *mask) { - smp_cross_call(mask, IPI_CALL_FUNC); + ipi_raise(mask, IPI_CALL_FUNC); } void arch_send_wakeup_ipi_mask(const struct cpumask *mask) { - smp_cross_call(mask, IPI_WAKEUP); + ipi_raise(mask, IPI_WAKEUP); } void arch_send_call_function_single_ipi(int cpu) { - smp_cross_call(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE); + ipi_raise(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE); } static const char *ipi_types[NR_IPI] = { @@ -487,7 +487,7 @@ u64 smp_irq_stat_cpu(unsigned int cpu) #ifdef CONFIG_GENERIC_CLOCKEVENTS_BROADCAST void tick_broadcast(const struct cpumask *mask) { - smp_cross_call(mask, IPI_TIMER); + ipi_raise(mask, IPI_TIMER); } #endif @@ -528,6 +528,8 @@ void handle_IPI(int ipinr, struct pt_regs *regs) unsigned int cpu = smp_processor_id(); struct pt_regs *old_regs = set_irq_regs(regs); + trace_ipi_handler_entry(ipinr); + if (ipinr < NR_IPI) __inc_irq_stat(cpu, ipi_irqs[ipinr]); @@ -571,11 +573,13 @@ void handle_IPI(int ipinr, struct pt_regs *regs) break; } set_irq_regs(old_regs); + + trace_ipi_handler_exit(ipinr); } void smp_send_reschedule(int cpu) { - smp_cross_call(cpumask_of(cpu), IPI_RESCHEDULE); + ipi_raise(cpumask_of(cpu), IPI_RESCHEDULE); } void smp_send_stop(void) @@ -586,7 +590,7 @@ void smp_send_stop(void) cpumask_copy(&mask, cpu_online_mask); cpumask_clear_cpu(smp_processor_id(), &mask); if (!cpumask_empty(&mask)) - smp_cross_call(&mask, IPI_CPU_STOP); + ipi_raise(&mask, IPI_CPU_STOP); /* Wait up to one second for other CPUs to stop */ timeout = USEC_PER_SEC; diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h index 4b8023c..7ebaa3a 100644 --- a/arch/arm64/include/asm/smp.h +++ b/arch/arm64/include/asm/smp.h @@ -24,6 +24,13 @@ # error "<asm/smp.h> included in non-SMP build" #endif +enum ipi_msg_type { + IPI_RESCHEDULE, + IPI_CALL_FUNC, + IPI_CALL_FUNC_SINGLE, + IPI_CPU_STOP, +}; + #define raw_smp_processor_id() (current_thread_info()->cpu) struct seq_file; diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c index 78db90d..c987b9f 100644 --- a/arch/arm64/kernel/smp.c +++ b/arch/arm64/kernel/smp.c @@ -48,6 +48,9 @@ #include <asm/tlbflush.h> #include <asm/ptrace.h> +#define CREATE_TRACE_POINTS +#include <trace/events/ipi.h> + /* * as from 2.5, kernels no longer have an init_tasks structure * so we need some other way of telling a new secondary core @@ -426,14 +429,20 @@ void __init set_smp_cross_call(void (*fn)(const struct cpumask *, unsigned int)) smp_cross_call = fn; } +static void ipi_raise(const struct cpumask *mask, int ipinr) +{ + trace_ipi_raise(mask, ipinr); + smp_cross_call(mask, ipinr); +} + void arch_send_call_function_ipi_mask(const struct cpumask *mask) { - smp_cross_call(mask, IPI_CALL_FUNC); + ipi_raise(mask, IPI_CALL_FUNC); } void arch_send_call_function_single_ipi(int cpu) { - smp_cross_call(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE); + ipi_raise(cpumask_of(cpu), IPI_CALL_FUNC_SINGLE); } static const char *ipi_types[NR_IPI] = { @@ -501,6 +510,8 @@ void handle_IPI(int ipinr, struct pt_regs *regs) unsigned int cpu = smp_processor_id(); struct pt_regs *old_regs = set_irq_regs(regs); + trace_ipi_handler_entry(ipinr); + if (ipinr >= IPI_RESCHEDULE && ipinr < IPI_RESCHEDULE + NR_IPI) __inc_irq_stat(cpu, ipi_irqs[ipinr - IPI_RESCHEDULE]); @@ -532,11 +543,13 @@ void handle_IPI(int ipinr, struct pt_regs *regs) break; } set_irq_regs(old_regs); + + trace_ipi_handler_exit(ipinr); } void smp_send_reschedule(int cpu) { - smp_cross_call(cpumask_of(cpu), IPI_RESCHEDULE); + ipi_raise(cpumask_of(cpu), IPI_RESCHEDULE); } void smp_send_stop(void) @@ -549,7 +562,7 @@ void smp_send_stop(void) cpumask_copy(&mask, cpu_online_mask); cpu_clear(smp_processor_id(), mask); - smp_cross_call(&mask, IPI_CPU_STOP); + ipi_raise(&mask, IPI_CPU_STOP); } /* Wait up to one second for other CPUs to stop */ diff --git a/include/trace/events/ipi.h b/include/trace/events/ipi.h new file mode 100644 index 0000000..fa22d4f --- /dev/null +++ b/include/trace/events/ipi.h @@ -0,0 +1,112 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM ipi + +#if !defined(_TRACE_IPI_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_IPI_H + +#include <linux/tracepoint.h> + +#define ipi_name(ipinr) { IPI_##ipinr, #ipinr } +#define show_ipi_name(val) \ + __print_symbolic(val, \ + ipi_name(WAKEUP), \ + ipi_name(TIMER), \ + ipi_name(RESCHEDULE), \ + ipi_name(CALL_FUNC), \ + ipi_name(CALL_FUNC_SINGLE), \ + ipi_name(CPU_STOP)) + +#define show_cpumask(srcp) \ + ({ \ + char *buf = __get_dynamic_array(buf); \ + cpumask_scnprintf(buf, NR_CPUS, srcp); \ + buf; \ + }) + +DECLARE_EVENT_CLASS(ipi, + + TP_PROTO(int ipinr), + + TP_ARGS(ipinr), + + TP_STRUCT__entry( + __field(int, ipinr) + ), + + TP_fast_assign( + __entry->ipinr = ipinr; + ), + + TP_printk("ipi=%d, name=%s", __entry->ipinr, + show_ipi_name(__entry->ipinr)) +); + +/** + * ipi_handle_entry - called right before the IPI handler + * @ipinr: the IPI number + * + * The @ipinr value must be valid and the action name associated with + * the IPI value is given in the trace. + */ +DEFINE_EVENT_CONDITION(ipi, ipi_handler_entry, + + TP_PROTO(int ipinr), + + TP_ARGS(ipinr), + + TP_CONDITION(ipinr < NR_IPI && ipinr >= 0) +); + +/** + * ipi_handle_exit - called right after the IPI handler + * @ipinr: the IPI number + * + * The @ipinr value must be valid and the action name associated with + * the IPI value is given in the trace. + */ +DEFINE_EVENT_CONDITION(ipi, ipi_handler_exit, + + TP_PROTO(int ipinr), + + TP_ARGS(ipinr), + + TP_CONDITION(ipinr < NR_IPI && ipinr >= 0) +); + +/** + * ipi_raise - called when a smp cross call is made + * @ipinr: the IPI number + * @cpumask: the recipients for the IPI + * + * The @ipinr value must be valid and the action name associated with + * the IPI value is given in the trace as well as the cpumask of the + * targeted cpus. + */ +TRACE_EVENT_CONDITION(ipi_raise, + + TP_PROTO(const struct cpumask *cpumask, int ipinr), + + TP_ARGS(cpumask, ipinr), + + TP_CONDITION(ipinr < NR_IPI && ipinr >= 0), + + TP_STRUCT__entry( + __field(int, ipinr) + __field(const struct cpumask *, cpumask) + __dynamic_array(char, buf, NR_CPUS) + ), + + TP_fast_assign( + __entry->ipinr = ipinr; + __entry->cpumask = cpumask; + ), + + TP_printk("ipi=%d, cpumask=0x%s, name=%s", __entry->ipinr, + show_cpumask(__entry->cpumask), + show_ipi_name(__entry->ipinr)) +); + +#endif /* _TRACE_IPI_H */ + +/* This part must be outside protection */ +#include <trace/define_trace.h> -- 1.7.9.5

12 years

next boot: 29 pass, 1 fail (next-20131120)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: next Git describe: next-20131120 Failed boot tests (console logs at the end) =========================================== armada-xp-openblocks-ax3-4: FAIL: multi_v7_defconfig Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 27.8 sec omap3-beagle-xm PASS: 0 min 53.1 sec am335x-bone PASS: 0 min 26.6 sec omap4-panda PASS: 1 min 3.3 sec omap4-panda-es PASS: 1 min 6.0 sec omap3-tobi,3730storm PASS: 0 min 21.3 sec omap3-tobi,3530overo PASS: 0 min 24.8 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.9 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.2 sec imx6q-wandboard PASS: 0 min 16.7 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.1 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.7 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.4 sec tegra30-beaver PASS: 0 min 14.2 sec am335x-boneblack PASS: 0 min 34.7 sec omap3-beagle-xm PASS: 0 min 50.3 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 3.8 sec omap4-panda-es PASS: 1 min 0.9 sec armada-xp-openblocks-ax3-4 FAIL: 2 min 22.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.4 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 16.8 sec omap3-tobi,3730storm PASS: 0 min 22.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.7 sec omap3-tobi,3530overo PASS: 0 min 22.9 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 22.0 sec Console logs for failures ========================= multi_v7_defconfig ------------------ armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ [ 159.415110] hub 2-0:1.0: USB hub found [ 159.418914] hub 2-0:1.0: 1 port detected [ 159.423034] SPEAr-ehci: EHCI SPEAr driver [ 159.427109] tegra-ehci: Tegra EHCI driver [ 159.431363] usbcore: registered new interface driver usb-storage [ 159.438013] mousedev: PS/2 mouse device common for all mice [ 159.444317] sdhci: Secure Digital Host Controller Interface driver [ 159.450534] sdhci: Copyright(c) Pierre Ossman [ 159.455107] sdhci-pltfm: SDHCI platform and OF driver helper [ 159.461194] usbcore: registered new interface driver usbhid [ 159.466780] usbhid: USB HID core driver [ 159.470772] TCP: cubic registered [ 159.474389] NET: Registered protocol family 10 [ 159.479225] sit: IPv6 over IPv4 tunneling driver [ 159.484177] Key type dns_resolver registered [ 159.488516] Registering SWP/SWPB emulation handler [ 159.494159] /home/build/work/batch/drivers/rtc/hctosys.c: unable to open rtc device (rtc0) [ 159.648830] ata1: SATA link down (SStatus 0 SControl F300) [ 159.998824] ata2: SATA link down (SStatus 0 SControl F300) [ 160.004605] Freeing unused kernel memory: 480K (c0656000 - c06ce000) ~$off # PYBOOT: Exception: userspace: ERROR: Never found root shell # PYBOOT: Time: 142.14 seconds. # PYBOOT: Result: FAIL

12 years

[RFC] Timer: Migrate running timers

by Viresh Kumar

Hi Thomas, This was earlier discussed here (Well, Not much :)): https://lkml.org/lkml/2012/11/6/160 I am floating the idea again to get more attention on this patch. This is just an idea for now, haven't seen much testing.. Migration of timers from idle cores to non-idle ones for power saving is very well working and really saves a lot of power for us. What's currently not working is the migration of running timers Or timers which re-arms themselves. There are complications with migrating timers which schedules themselves again from their handler. del_timer_sync() can't detect that the timer's handler yet has not finished. __mod_timer migrates the timer with following code: ... spin_lock(&old_base->lock); ... timer_set_base(timer, NULL); spin_unlock(&old_base->lock); ->A spin_lock(&new_base->lock); ->B timer_set_base(timer, new_base); ... After the unlock at time A, old_base->running_timer may get updated to the next timer in queue. After lock at time B, lock_timer_base() will return new_base where another timer might be running timer at that point of time. Whereas, del_timer_sync() depends on below code to check if a timer's handler is currently running or not. if (base->running_timer != timer) Because there is window where timer's handler would be running and at the same time it wasn't marked as running timer for any of the bases (well, it matters only for its current base, i.e. new_base). del_timer_sync() wouldn't know this and will go on and delete the timer, whose handler is currently running. The new approach tries to mark such timers with wait_for_migration_to_complete flag (can be named better and some memory can be saved as PeterZ suggested), which will be used in del_timer_sync() to see if the timer is currently migrating and so isn't marked as running_timer of its base. Benefits: Well, obviously saving power for a core which is being interrupted again and again in its idle loop by this timer event. Which will also prevent the core to go in deeper idle states if possible. Please share your feedback on this approach. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- include/linux/timer.h | 1 + kernel/timer.c | 29 +++++++++++++---------------- 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/include/linux/timer.h b/include/linux/timer.h index 8c5a197..ad00ebe 100644 --- a/include/linux/timer.h +++ b/include/linux/timer.h @@ -20,6 +20,7 @@ struct timer_list { void (*function)(unsigned long); unsigned long data; + int wait_for_migration_to_complete; int slack; diff --git a/kernel/timer.c b/kernel/timer.c index 6582b82..30a93e6 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -748,21 +748,15 @@ __mod_timer(struct timer_list *timer, unsigned long expires, new_base = per_cpu(tvec_bases, cpu); if (base != new_base) { - /* - * We are trying to schedule the timer on the local CPU. - * However we can't change timer's base while it is running, - * otherwise del_timer_sync() can't detect that the timer's - * handler yet has not finished. This also guarantees that - * the timer is serialized wrt itself. - */ - if (likely(base->running_timer != timer)) { - /* See the comment in lock_timer_base() */ - timer_set_base(timer, NULL); - spin_unlock(&base->lock); - base = new_base; - spin_lock(&base->lock); - timer_set_base(timer, base); - } + if (base->running_timer == timer) + timer->wait_for_migration_to_complete = 1; + + /* See the comment in lock_timer_base() */ + timer_set_base(timer, NULL); + spin_unlock(&base->lock); + base = new_base; + spin_lock(&base->lock); + timer_set_base(timer, base); } timer->expires = expires; @@ -992,7 +986,8 @@ int try_to_del_timer_sync(struct timer_list *timer) base = lock_timer_base(timer, &flags); - if (base->running_timer != timer) { + if ((base->running_timer != timer) && + !timer->wait_for_migration_to_complete) { timer_stats_timer_clear_start_info(timer); ret = detach_if_pending(timer, base, true); } @@ -1185,6 +1180,8 @@ static inline void __run_timers(struct tvec_base *base) call_timer_fn(timer, fn, data); spin_lock_irq(&base->lock); } + if (timer->wait_for_migration_to_complete) + timer->wait_for_migration_to_complete = 0; } } base->running_timer = NULL; -- 1.7.12.rc2.18.g61b472e

12 years

Unhandled fault: PCIe network driver

by Pankaj Pandey

Hi All, I am getting kernel panic due to "readl" failure in in realtek network driver "drivers/net/ethernet/realtek/r8169.c" as PCIe card. And readl error because of "Unhandled fault". Please find log below. "Unhandled fault: external abort on non-linefetch (0x1008) at 0xf00d2040". Any suggestion why readl is getting failed in realtet network driver? What is the meaning of above error ? I appreciate if you please suggest some pointers. Please also find below virtual memory layout from 3.10.14 kernel log. ======================== Virtual kernel memory layout: vector : 0xffff0000 - 0xffff1000 ( 4 kB) fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB) vmalloc : 0xf0000000 - 0xff000000 ( 240 MB) lowmem : 0xc0000000 - 0xef800000 ( 760 MB) pkmap : 0xbfe00000 - 0xc0000000 ( 2 MB) modules : 0xbf800000 - 0xbfe00000 ( 6 MB) .text : 0xc0008000 - 0xc02ec340 (2961 kB) .init : 0xc0416000 - 0xc043a300 ( 145 kB) .data : 0xc043c000 - 0xc046e7a0 ( 202 kB) .bss : 0xc046e7a0 - 0xc04ad730 ( 252 kB) ======================== Thanks in Advance !! Regards, Pankaj

12 years

[PATCH] cpufreq/stats: Add "unknown" frequency field in stats tables

by Viresh Kumar

commit 46a310b ([CPUFREQ] Don't set stat->last_index to -1 if the pol->cur has incorrect value.) tries to handle case where policy->cur does not match any entry in freq_table. As indicated in the above commit, the exact match search of freq_table_get index will return a -1 which is stored in stat->last_index. However, as a result of the above commit, cpufreq_stat_notifier_trans which updates the statistics, fails to update any *further* valid transitions that take place as stat->last_index is -1 as the condition occurs at boot and never solved. To fix this issue, lets create another entry for time_in_state and trans_table that will tell the user that CPU was running on unknown frequency for some time. This is how the output looks like on my thinkpad (Removed some entries to keep it simple): $ cat /sys/devices/system/cpu/cpu0/cpufreq/stats/time_in_state 2800000 46 2600000 138 1200000 65 1000000 152 800000 34803 unknown 0 $ cat /sys/devices/system/cpu/cpu0/cpufreq/stats/trans_table From : To : 2801000 2800000 2600000 2400000 2200000 2000000 unknown 2801000: 0 15 20 9 13 17 0 2800000: 13 0 4 1 0 1 0 2600000: 26 1 0 5 1 1 0 2400000: 11 0 6 0 1 1 0 2200000: 8 1 5 3 0 0 0 2000000: 11 1 2 1 2 0 0 unknown: 0 0 0 0 0 0 0 Reported-by: Carlos Hernandez <ceh(a)ti.com> Reported-and-tested-by: Nishanth Menon <nm(a)ti.com> Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/cpufreq_stats.c | 45 ++++++++++++++++++++++++++++------------- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c index 4cf0d28..ebb21cd 100644 --- a/drivers/cpufreq/cpufreq_stats.c +++ b/drivers/cpufreq/cpufreq_stats.c @@ -72,9 +72,13 @@ static ssize_t show_time_in_state(struct cpufreq_policy *policy, char *buf) return 0; cpufreq_stats_update(stat->cpu); for (i = 0; i < stat->state_num; i++) { - len += sprintf(buf + len, "%u %llu\n", stat->freq_table[i], - (unsigned long long) - jiffies_64_to_clock_t(stat->time_in_state[i])); + if (stat->freq_table[i] == -1) + return sprintf(buf + len, "unknown"); + else + return sprintf(buf + len, "%u", stat->freq_table[i]); + + len += sprintf(buf + len, " %llu\n", (unsigned long long) + jiffies_64_to_clock_t(stat->time_in_state[i])); } return len; } @@ -94,8 +98,12 @@ static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf) for (i = 0; i < stat->state_num; i++) { if (len >= PAGE_SIZE) break; - len += snprintf(buf + len, PAGE_SIZE - len, "%9u ", - stat->freq_table[i]); + if (stat->freq_table[i] == -1) + len += snprintf(buf + len, PAGE_SIZE - len, "%9s ", + "unknown"); + else + len += snprintf(buf + len, PAGE_SIZE - len, "%9u ", + stat->freq_table[i]); } if (len >= PAGE_SIZE) return PAGE_SIZE; @@ -106,8 +114,12 @@ static ssize_t show_trans_table(struct cpufreq_policy *policy, char *buf) if (len >= PAGE_SIZE) break; - len += snprintf(buf + len, PAGE_SIZE - len, "%9u: ", - stat->freq_table[i]); + if (stat->freq_table[i] == -1) + len += snprintf(buf + len, PAGE_SIZE - len, "%9s: ", + "unknown"); + else + len += snprintf(buf + len, PAGE_SIZE - len, "%9u: ", + stat->freq_table[i]); for (j = 0; j < stat->state_num; j++) { if (len >= PAGE_SIZE) @@ -145,10 +157,12 @@ static struct attribute_group stats_attr_group = { static int freq_table_get_index(struct cpufreq_stats *stat, unsigned int freq) { int index; - for (index = 0; index < stat->max_state; index++) + for (index = 0; index < stat->max_state - 1; index++) if (stat->freq_table[index] == freq) return index; - return -1; + + /* Last state is INVALID, to mark out of table frequency */ + return stat->max_state - 1; } /* should be called late in the CPU removal sequence so that the stats @@ -222,6 +236,9 @@ static int cpufreq_stats_create_table(struct cpufreq_policy *policy, count++; } + /* An extra entry for Invalid frequencies */ + count++; + alloc_size = count * sizeof(int) + count * sizeof(u64); #ifdef CONFIG_CPU_FREQ_STAT_DETAILS @@ -243,9 +260,13 @@ static int cpufreq_stats_create_table(struct cpufreq_policy *policy, unsigned int freq = table[i].frequency; if (freq == CPUFREQ_ENTRY_INVALID) continue; - if (freq_table_get_index(stat, freq) == -1) + if (freq_table_get_index(stat, freq) == stat->max_state - 1) stat->freq_table[j++] = freq; } + + /* Mark Invalid freq as max value to indicate Invalid freq */ + stat->freq_table[j++] = -1; + stat->state_num = j; spin_lock(&cpufreq_stats_lock); stat->last_time = get_jiffies_64(); @@ -315,10 +336,6 @@ static int cpufreq_stat_notifier_trans(struct notifier_block *nb, old_index = stat->last_index; new_index = freq_table_get_index(stat, freq->new); - /* We can't do stat->time_in_state[-1]= .. */ - if (old_index == -1 || new_index == -1) - return 0; - cpufreq_stats_update(freq->cpu); if (old_index == new_index) -- 1.7.12.rc2.18.g61b472e

12 years

rebuild ubuntu kernel failure

by 林雅

This is what I do: step 1: download image http://releases.linaro.org/13.10/ubuntu/panda/panda-raring_developer_201310… and flash it to my SD card. test it on pandaboard, run well. step 2: setup toolschain with http://releases.linaro.org/13.04/components/toolchain/binaries/gcc-linaro-a… step 3: download kernel source code from http://releases.linaro.org/13.10/components/kernel/linux-linaro/linux-linar…, uncompress to dir kernelSrc cp SdCard/rootfs/boot/config-3.12.0-1-linaro-omap kernelSrc/.config step 4: cd kernelSrc LOADADDR=0x80008000 make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- uImage -j8 copy arch/arm/boot/uImage to SdCard/fat32partion/ replace the offical uImage step 5: test the SD card again, run failure. the console message stop on Starting kernel ... Could you help me, How to rebuild the ubuntu kernel correctly?

12 years

mainline boot: 31 pass, 0 fail (v3.12-10710-gb4789b8)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.12-10710-gb4789b8 Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 32.8 sec omap3-beagle-xm PASS: 0 min 51.6 sec am335x-bone PASS: 0 min 26.6 sec omap4-panda PASS: 1 min 3.8 sec omap4-panda-es PASS: 1 min 3.2 sec omap3-tobi,3730storm PASS: 0 min 20.9 sec omap3-tobi,3530overo PASS: 0 min 21.9 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 20.3 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.2 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.2 sec imx6q-wandboard PASS: 0 min 15.4 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.0 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.7 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 28.4 sec tegra30-beaver PASS: 0 min 16.5 sec am335x-boneblack PASS: 0 min 34.7 sec omap3-beagle-xm PASS: 0 min 50.5 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 2.1 sec omap4-panda-es PASS: 1 min 2.2 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.9 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.6 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 16.8 sec omap3-tobi,3730storm PASS: 0 min 22.2 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.7 sec omap3-tobi,3530overo PASS: 0 min 19.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 31.4 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.4 sec

12 years

mainline boot: 31 pass, 0 fail (v3.12-10709-g1ee2dcc2)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.12-10709-g1ee2dcc2 Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 27.8 sec omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.6 sec omap4-panda PASS: 1 min 5.5 sec omap4-panda-es PASS: 1 min 4.8 sec omap3-tobi,3730storm PASS: 0 min 24.1 sec omap3-tobi,3530overo PASS: 0 min 21.7 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.9 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.2 sec imx6q-wandboard PASS: 0 min 16.5 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.1 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.7 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 28.2 sec tegra30-beaver PASS: 0 min 16.5 sec am335x-boneblack PASS: 0 min 34.7 sec omap3-beagle-xm PASS: 0 min 50.0 sec sun7i-a20-cubieboard2 PASS: 0 min 12.9 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 2.4 sec omap4-panda-es PASS: 1 min 1.3 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.6 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 16.8 sec omap3-tobi,3730storm PASS: 0 min 22.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.7 sec omap3-tobi,3530overo PASS: 0 min 19.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 31.6 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec

12 years

mainline boot: 31 pass, 0 fail (v3.12-10590-gdec8e46)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.12-10590-gdec8e46 Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 27.8 sec omap3-beagle-xm PASS: 0 min 54.2 sec am335x-bone PASS: 0 min 26.7 sec omap4-panda PASS: 1 min 4.8 sec omap4-panda-es PASS: 1 min 3.5 sec omap3-tobi,3730storm PASS: 0 min 20.9 sec omap3-tobi,3530overo PASS: 0 min 24.8 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 16.9 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 16.6 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 19.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.6 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.2 sec tegra30-beaver PASS: 0 min 19.2 sec am335x-boneblack PASS: 0 min 34.7 sec omap3-beagle-xm PASS: 0 min 47.2 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 3.4 sec omap4-panda-es PASS: 1 min 0.8 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.8 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.8 sec am335x-bone PASS: 0 min 33.5 sec imx6q-wandboard PASS: 0 min 17.1 sec omap3-tobi,3730storm PASS: 0 min 19.1 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.9 sec omap3-tobi,3530overo PASS: 0 min 19.8 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 28.7 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.4 sec

12 years

arm-soc boot: 31 pass, 0 fail (v3.12-9688-gad2e65b)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: arm-soc Git describe: v3.12-9688-gad2e65b Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 32.8 sec omap3-beagle-xm PASS: 0 min 52.4 sec am335x-bone PASS: 0 min 26.6 sec omap4-panda PASS: 1 min 5.6 sec omap4-panda-es PASS: 1 min 12.7 sec omap3-tobi,3730storm PASS: 0 min 24.1 sec omap3-tobi,3530overo PASS: 0 min 21.6 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 16.6 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.1 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 30.1 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.1 sec tegra30-beaver PASS: 0 min 17.3 sec am335x-boneblack PASS: 0 min 34.7 sec omap3-beagle-xm PASS: 0 min 52.9 sec sun7i-a20-cubieboard2 PASS: 0 min 16.0 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 3.1 sec omap4-panda-es PASS: 1 min 3.3 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.8 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.5 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 15.9 sec omap3-tobi,3730storm PASS: 0 min 19.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.7 sec omap3-tobi,3530overo PASS: 0 min 19.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 33.0 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.4 sec

12 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel