Re: [PATCH 06/10] PM / OPP: Rename and split _dev_pm_opp_remove_table()

On 12/06, Viresh Kumar wrote:

diff --git a/drivers/base/power/opp/core.c b/drivers/base/power/opp/core.c index ee5fbbd6da93..ef114cf9edcd 100644 --- a/drivers/base/power/opp/core.c +++ b/drivers/base/power/opp/core.c @@ -1897,11 +1897,27 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_get_notifier);

• Free OPPs either created using static entries present in DT or even the
• dynamically added entries based on remove_all param.

*/ -void _dev_pm_opp_remove_table(struct device *dev, bool remove_all) +static void _dev_pm_opp_remove_table(struct opp_table *opp_table,

• 		     struct device *dev, bool remove_all)
  

{

• struct opp_table *opp_table; struct dev_pm_opp *opp, *tmp;

Please add a comment or lockdep check to make sure we're holding the table lock.