On 06/11/2015 06:00 PM, Viresh Kumar wrote:
On 11-06-15, 17:25, Daniel Lezcano wrote:
Please mention in the log you removed the RESUME because it does nothing and the core code will just ignore it.
Okay.
The patch is ok but there is an inconsistency on how are handled the different callbacks. tick_resume can be omitted but not state_shutdown and state_oneshot forcing the drivers to define empty functions.
It was done because they are thought to be compulsory, but even I am not sure if we should make all callbacks as optional.
Yes, I think it would make sense to ignore NULL callback in __clockevents_set_state, otherwise we will end up to fill the different drivers with duplicated noop functions.