On Mon, Oct 14, 2013 at 12:42:28PM +0100, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
Having the typedef in place for the tracepoints causes compiler crashes in some situations. Just using void * directly avoids triggering the issue and should have no effect on the trace.
Signed-off-by: Mark Brown broonie@linaro.org
Acked-by: Liviu Dudau Liviu.Dudau@arm.com
Does this issue only trigger with a version of gcc earlier than 4.8.1?
Best regards, Liviu
include/trace/events/smp.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/trace/events/smp.h b/include/trace/events/smp.h index c8abfd7..da0baf2 100644 --- a/include/trace/events/smp.h +++ b/include/trace/events/smp.h @@ -5,11 +5,10 @@ #define _TRACE_SMP_H #include <linux/tracepoint.h> -typedef void (*__smp_call_func_t)(void *info); DECLARE_EVENT_CLASS(smp_call_class,
- TP_PROTO(__smp_call_func_t fnc),
- TP_PROTO(void * fnc),
TP_ARGS(fnc), @@ -35,7 +34,7 @@ DECLARE_EVENT_CLASS(smp_call_class, */ DEFINE_EVENT(smp_call_class, smp_call_func_entry,
- TP_PROTO(__smp_call_func_t fnc),
- TP_PROTO(void * fnc),
TP_ARGS(fnc) ); @@ -51,7 +50,7 @@ DEFINE_EVENT(smp_call_class, smp_call_func_entry, */ DEFINE_EVENT(smp_call_class, smp_call_func_exit,
- TP_PROTO(__smp_call_func_t fnc),
- TP_PROTO(void * fnc),
TP_ARGS(fnc) ); @@ -67,7 +66,7 @@ DEFINE_EVENT(smp_call_class, smp_call_func_exit, */ TRACE_EVENT(smp_call_func_send,
- TP_PROTO(__smp_call_func_t func, int dest),
- TP_PROTO(void * func, int dest),
TP_ARGS(func, dest), -- 1.8.4.rc3