On 21-03-17, 16:09, Viresh Kumar wrote:
On 21-03-17, 10:37, Jon Hunter wrote:
On 21/03/17 05:24, Viresh Kumar wrote:
The size of the struct tegra_powergate is quite big and if any more fields are added to the internal genpd structure, following warnings are thrown:
drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Hmmm ... AFAICT the size of the tegra_powergate struct is 312 bytes (based upon next-20170321) and so it looks like something massive needs to be added to the genpd struct to blow this up to over 1024 bytes. Are there some genpd changes in-flight that are causing this?
https://marc.info/?l=linux-kernel&m=149000247329743&w=2
This is up for discussion right now though and we don't know if it will surely get merged or not.
@Jon: Regardless of the above series, do you want this patch to be merged as it will still be better to avoid keeping large structures on stack.
Else I would be required to keep this in my above series from now on.