Hi Viresh,
One minor nit
On Thu, Dec 04, 2014 at 04:12:07AM +0000, Viresh Kumar wrote:
get_property() was an over complicated beast with BUGs. It used to believe that cpufreq table is present in ascending or descending order, which might not always be true.
Previous patch has created another freq table in descending order for us and we better use it now. With that get_property() simply goes away and another helper get_level() comes in.
Signed-off-by: Viresh Kumar viresh.kumar@linaro.org
drivers/thermal/cpu_cooling.c | 108 ++++++++---------------------------------- 1 file changed, 19 insertions(+), 89 deletions(-)
diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index cb5a4b9..d97e14d 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -112,85 +112,27 @@ static void release_idr(struct idr *idr, int id) /* Below code defines functions to be used for cpufreq as cooling device */ -enum cpufreq_cooling_property {
- GET_LEVEL,
- GET_FREQ,
-};
/**
- get_property - fetch a property of interest for a given cpu.
- get_level: Find the level for a particular frequency
- @cpufreq_dev: cpufreq_dev for which the property is required
- @input: query parameter
- @output: query return
- @property: type of query (frequency, level)
- This is the common function to
- translate frequency to cooling state
- translate cooling state to frequency
- @freq: Frequency
- Note that the code may be not in good shape
- but it is written in this way in order to:
- a) reduce duplicate code as most of the code can be shared.
- b) make sure the logic is consistent when translating between
- cooling states and frequencies.
- Return: 0 on success, -EINVAL when invalid parameters are passed.
- Returns: level on success, THERMAL_CSTATE_INVALID on error.
Should be "Return:", as it was. See Documentation/kernel-doc-nano-HOWTO.txt
Cheers, Javi