On Thu, Sep 18, 2014 at 06:02:06PM +0100, Catalin Marinas wrote:
On Tue, Sep 16, 2014 at 05:42:33PM +0100, Mark Brown wrote:
default: BUG_ON(1);
}return 0;
Wouldn't there be less lines if we initialise insn to 0 in these functions?
In general that's bad practice since it means that you loose the benefit of flow analysis on that variable throughout the function - it will shut the warning up but if someone introduces a bug later on the compiler won't be able to tell them about it.