On Thu, May 01, 2014 at 01:41:37PM +0000, Mark Hambleton wrote:
Wouldn't it have been better to just revert the patch that added the platform specific pre-processing?
What you are doing now is introducing a second config change into LSK...
Special casing for TC2 was present since the first version of HMP that was merged into the LSK and was included in the base patch that added small task packing (HMP: Implement task packing for small tasks in HMP systems) in that series so we can't just do a straight revert.
It's not ideal to have to change the userspace for TC2 but on the other hand it's probably good that we have the reference systems using best practice since others will doubtless look at what it does when they do their own integration. Equally well it's *possible* someone might be running this stuff with TC2 built into their kernel as a way of getting the feature.