Hi Viresh,
Viresh Kumar viresh.kumar@linaro.org hat am 17. November 2014 um 09:08 geschrieben:
[...]
Now the question is: Should we destroy these OPPs?
Logically kernel drivers *must* free resources they acquired. But in this particular case, the OPPs are created using a static list present in device tree. Destroying and then allocating them again isn't of much benefit. The only benefit of removing OPPs is to save some space if the driver isn't loaded again.
This has its own complications. OPPs can be created either from DT (static) or platform code (dynamic). Driver should only remove static OPPs and not the dynamic ones as they are controlled from platform code. But there is no field in 'struct dev_pm_opp' which has this information to distinguish between different kind of OPPs.
Because of all this, I wasn't sure if drivers should remove static OPPs during their removal. And so just fixing the reported issue by issuing a dev_dbg() instead of dev_warn().
how about adding some kind of FIXME?
beside that
Tested-by: Stefan Wahren stefan.wahren@i2se.com
Thanks
Stefan