Re: [PATCH 1/2] raid6: add NEON implementation of RAID-6 syndrome functions

On Mon, Jun 03, 2013 at 04:02:15PM -0400, Nicolas Pitre wrote:

On Mon, 3 Jun 2013, Vladimir Murzin wrote:

...

Signed-off-by: Vladimir Murzin murzin.v@gmail.com.com

Please check your git setup as gmail.com.com is not a valid host.

Fixed, thanks.

[...]

...

+/*

• • raid6/neon.S
• • NEON implementation of RAID-6 syndrome functions
• • NEON instructions operate on wide 64-bit and 128-bit vector registers,
• • Despite support 128-bit vectors some cores execute with 64 bits at a time.
• • Because of that 64-bit wide operations implemented too.
• */

+#include <linux/linkage.h>

+.data +.align 4 +raid6_neon_constants: +.word 0x1d1d1d1d, 0x1d1d1d1d, 0x1d1d1d1d, 0x1d1d1d1d

+.text

If the above constants are indeed constants, you should put them in the .text section instead.

Yes, they are constants. Doesn't .rodata fit best for them?

Vladimir Murzin

Nicolas