On 17 April 2015 at 07:19, Amit Kucheria amit.kucheria@linaro.org wrote:
On Thu, Apr 16, 2015 at 10:20 PM, Scott Bambrough scott.bambrough@linaro.org wrote:
I have a question:
The following fragment from arch/arm64/kernel/topology.c prints an error
for
all CPU's on the HiKey.
rate = of_get_property(cn, "clock-frequency", &len); if (!rate || len != 4) { pr_err("%s: Missing clock-frequency property\n", cn->full_name); continue; }
This doesn't seem to be fatal, and Juno and other platforms do not seem
to
have it set. If that is the case, why is it an error, rather than a warning? Also if no one uses it why check for it at all? Backwards compatibility with other architectures?
Sounds like Mark's documentation patch[1] for this should be revived. This has come up twice in a week now :)
[1] https://lists.linaro.org/pipermail/linaro-kernel/2013-December/009484.html
Note that this only happens on LSK, not in mainline - mainline misses all the code for CPU cluster capacity scaling.