On Wed, Nov 23, 2016 at 09:16:57AM +0530, Viresh Kumar wrote:
On 22-11-16, 18:41, Mark Brown wrote:
I'm really not at all clear why this has to be in DT. My understanding was that this is basically a helper library for more specific bindings which already have to hard code things like sequencing so surely they'd be specifying the ordering to be used when supplying data?
I am a bit confused and perhaps I am misreading your feedback.
Are you saying that:
"we don't need to identify which microVolts value in the OPP table corresponds to which supply from the DT itself and we can do that with some hard coded stuff" ?
No, of course not. That would be completely incoherent, there would be no way for anything to use the data if the values can just be in any random order.
If yes, then below is from an earlier email from you, which I feel is opposite of what you are suggesting now.
That *really* should be in the binding. Honestly if the binding is this vague I'm not even clear that it's worth documenting these properties at this level, might be better to just put the documentation in the platform driver bindings.
The "platform driver bindings" bit of this is very important here. This is a generic binding that is going to be used by platform specific drivers (as I understand it). I would therefore expect that these things can be described in the platform specific bindings.
Please, take a step back and think about what what the binding means and how it's going to be used. Not only is this a DT binding and therefore an ABI it's also a generic binding that's going to affect a lot of systems probably for a long time. This means it is really important to think things through and make sure we understand what they're doing. When working on kernel internal code it's relatively easy to fix things if we realize later that they don't work well so it's easier to just work quickly but when we're making ABIs that's not possible.