One minor comment ...
On Mon, Mar 28, 2011 at 01:24:48PM +0530, Thomas Abraham wrote:
Enable basic device tree support for Exynos4 smdkv310 board.
Signed-off-by: Thomas Abraham thomas.abraham@linaro.org
[...]
diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c index 88e0275..f6dc8df 100644 --- a/arch/arm/mach-exynos4/mach-smdkv310.c +++ b/arch/arm/mach-exynos4/mach-smdkv310.c @@ -237,6 +237,11 @@ static void __init smdkv310_machine_init(void) platform_add_devices(smdkv310_devices, ARRAY_SIZE(smdkv310_devices)); } +static char const *smdkv310_dt_compat[] = {
__initdata? I'm seeing Grant's guide has this and expecting all the platforms coming later will have this.
- "samsung,smdkv310",
- NULL
+};
MACHINE_START(SMDKV310, "SMDKV310") /* Maintainer: Kukjin Kim kgene.kim@samsung.com */ /* Maintainer: Changhwan Youn chaos.youn@samsung.com */ @@ -245,4 +250,5 @@ MACHINE_START(SMDKV310, "SMDKV310") .map_io = smdkv310_map_io, .init_machine = smdkv310_machine_init, .timer = &exynos4_timer,
- .dt_compat = smdkv310_dt_compat,
MACHINE_END