Re: [PATCH V3 1/8] clockevents: add ->set_dev_mode() to struct clock_event_device

On 29 May 2014 22:14, Kevin Hilman khilman@linaro.org wrote:

Viresh Kumar viresh.kumar@linaro.org writes:

...

@@ -446,8 +453,13 @@ int __clockevents_update_freq(struct clock_event_device *dev, u32 freq) if (dev->mode == CLOCK_EVT_MODE_ONESHOT) return clockevents_program_event(dev, dev->next_event, false);

• if (dev->mode == CLOCK_EVT_MODE_PERIODIC)
  

•         dev->set_mode(CLOCK_EVT_MODE_PERIODIC, dev);
  

• if (dev->mode == CLOCK_EVT_MODE_PERIODIC) {
  

•         if (dev->set_dev_mode)
  

As discussed already, PERIODIC should never fail, so maybe a comment here stating that we don't ever expect periodic mode to fail.

Okay.