Re: [PATCH 2/2][RFC] time : set broadcast irq affinity

On Fri, 22 Feb 2013, Jacob Pan wrote:

On Thu, 21 Feb 2013 23:01:23 +0100 Daniel Lezcano daniel.lezcano@linaro.org wrote:

...

+/*

• • Set broadcast interrupt affinity
• */

+static void tick_broadcast_set_affinity(struct clock_event_device *bc, int cpu) +{

• struct cpumask cpumask;
• if (!(bc->features & CLOCK_EVT_FEAT_DYNIRQ))

• return;
  

• cpumask_clear(&cpumask);
• cpumask_set_cpu(cpu, &cpumask);
• irq_set_affinity(bc->irq, &cpumask);

would it be more efficient to keep track of the current bc->irq affinity via cpumask then set it only if it is different?

You beat me :)