Re: [PATCH CFT] arm: omap1: Migrate debug_ll macros to use 8250.S

On 17 Jul 2014 18:12, "Aaro Koskinen" aaro.koskinen@iki.fi wrote:

Hi,

On Thu, Jul 17, 2014 at 11:54:04AM +0100, Daniel Thompson wrote:

...

The omap1's debug-macro.S is similar to the generic 8250 code. Compared

to

...

the 8520 code the omap1 macro automatically determines what UART to use based on breadcrumbs left by the bootloader and automatically copes with the eccentric register layout on OMAP7XX.

[...]

...

• config DEBUG_OMAP1UART1
  

•         bool "Kernel low-level debugging via OMAP1 UART1"
  

•         depends on ARCH_OMAP1 && !ARCH_OMAP730
  

Did you try this with omap1_defconfig and then running menuconfig to see how it looks like? The patch allows to select only OMAP730 ports, but the kernel should be bootable on all core types...

Yes. I complied tested it and it did what I expected. It's just that what I had expected want wasn't right.

I'll fix this. Thanks.