On 06/13/2013 02:29 AM, Javi Merino wrote:
Linaro kernels include a patch by Tony Lindgren that adds a printascii() to every printk() call. Currently in linux-linaro-tracking, that's 892a9def (ARM: Make low-level printk work). With this patch, every line is printed twice once you've registered a console driver which is a bit of a pain. Speaking to him, he acknowledges that this hack is no longer needed since we now have earlyprintk, so can this patch be removed from linaro kernels?
Yea. As Andy mentioned, we carry a patch to revert that change in the Linaro tree (though occasionally I get forgetful and it gets dropped when migrating to new AOSP releases).
I tried to push the revert w/ Andy's rational to AOSP but the Android devs apparently have a fondness for the patch, and still use it: https://android-review.googlesource.com/#/c/59074/
(My guess is they consider it easier to just keep the patch then to have to remember the boot arguments required when debugging difficult problems.)
thanks -john