Ok, sure.
Thanks, Yuantian
-----Original Message----- From: Viresh Kumar [mailto:viresh.kumar@linaro.org] Sent: Wednesday, September 10, 2014 1:39 PM To: Tang Yuantian-B29983 Cc: Rafael Wysocki; Lists linaro-kernel; linux-pm@vger.kernel.org; Zhang Hongbo-B45939; Li Yang-Leo-R58472 Subject: Re: [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data
On 10 September 2014 11:00, Yuantian Tang Yuantian.Tang@freescale.com wrote:
On 2 September 2014 09:11, Viresh Kumar viresh.kumar@linaro.org wrote:
'cpu_data' is updated for policy->cpu first and then for all CPUs in policy->cpus. policy->cpus is guaranteed to contain policy->cpu as policy->well and so the first write to 'cpu_data' for policy->cpu is redundant. Remove it.
Yeah, your patch should be ok, but is it the best solution? I was thinking about a final solution just like ARM did.
I was talking about an Ack for just 1/2 where we are doing some cleanup, which shouldn't break anything.
Regarding the second patch, yes you should come up with something that can give a list of online+offline CPUs like ARM and even some ppc drivers. We can handle that separately and this patch can be commited by Rafael..
Either you can give a replacement patch for 2/2 or you can let me know what to do and will help there.